From: Max Reitz <mreitz@redhat.com>
To: Sam Eiderman <shmuel.eiderman@oracle.com>,
kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
seabios@seabios.org, kraxel@redhat.com, kevin@koconnor.net
Cc: liran.alon@oracle.com, karl.heubaum@oracle.com, arbel.moshe@oracle.com
Subject: Re: [Qemu-devel] [QEMU] [PATCH v5 3/8] bootdevice: Add interface to gather LCHS
Date: Tue, 13 Aug 2019 20:51:44 +0200 [thread overview]
Message-ID: <a4e72a67-4107-4cbb-10e6-6a77011f34ce@redhat.com> (raw)
In-Reply-To: <20190626123948.10199-4-shmuel.eiderman@oracle.com>
[-- Attachment #1.1: Type: text/plain, Size: 2548 bytes --]
On 26.06.19 14:39, Sam Eiderman wrote:
> Add an interface to provide direct logical CHS values for boot devices.
> We will use this interface in the next commits.
>
> Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
> Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com>
> Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com>
> ---
> bootdevice.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++
> include/sysemu/sysemu.h | 3 +++
> 2 files changed, 58 insertions(+)
I’ve got a couple of “undelivered mail returned to sender” mails for Sam
recently, but anyway...
> diff --git a/bootdevice.c b/bootdevice.c
> index 1d225202f9..bc5e1c2de4 100644
> --- a/bootdevice.c
> +++ b/bootdevice.c
> @@ -343,3 +343,58 @@ void device_add_bootindex_property(Object *obj, int32_t *bootindex,
> /* initialize devices' bootindex property to -1 */
> object_property_set_int(obj, -1, name, NULL);
> }
> +
> +typedef struct FWLCHSEntry FWLCHSEntry;
> +
> +struct FWLCHSEntry {
> + QTAILQ_ENTRY(FWLCHSEntry) link;
> + DeviceState *dev;
> + char *suffix;
> + uint32_t lcyls;
> + uint32_t lheads;
> + uint32_t lsecs;
> +};
> +
> +static QTAILQ_HEAD(, FWLCHSEntry) fw_lchs =
> + QTAILQ_HEAD_INITIALIZER(fw_lchs);
> +
> +void add_boot_device_lchs(DeviceState *dev, const char *suffix,
> + uint32_t lcyls, uint32_t lheads, uint32_t lsecs)
> +{
> + FWLCHSEntry *node;
> +
> + if (!lcyls && !lheads && !lsecs) {
> + return;
> + }
> +
> + assert(dev != NULL || suffix != NULL);
It doesn’t look like any caller actually passes a NULL @dev, so why not
drop the @suffix part?
> + node = g_malloc0(sizeof(FWLCHSEntry));
> + node->suffix = g_strdup(suffix);
> + node->dev = dev;
> + node->lcyls = lcyls;
> + node->lheads = lheads;
> + node->lsecs = lsecs;
> +
> + QTAILQ_INSERT_TAIL(&fw_lchs, node, link);
> +}
> +
> +void del_boot_device_lchs(DeviceState *dev, const char *suffix)
> +{
> + FWLCHSEntry *i;
> +
> + if (dev == NULL) {
> + return;
> + }
> +
> + QTAILQ_FOREACH(i, &fw_lchs, link) {
> + if ((!suffix || !g_strcmp0(i->suffix, suffix)) &&
> + i->dev == dev) {
(Furthermore, it’d be impossible to remove an FWLCHSEntry with .dev ==
NULL.)
Max
> + QTAILQ_REMOVE(&fw_lchs, i, link);
> + g_free(i->suffix);
> + g_free(i);
> +
> + break;
> + }
> + }
> +}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-13 18:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 12:39 [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 1/8] block: Refactor macros - fix tabbing Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 2/8] block: Support providing LCHS from user Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 3/8] bootdevice: Add interface to gather LCHS Sam Eiderman
2019-08-13 18:51 ` Max Reitz [this message]
2019-08-22 15:13 ` Sam Eiderman via Qemu-devel
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 4/8] scsi: Propagate unrealize() callback to scsi-hd Sam Eiderman
2019-08-13 19:06 ` Max Reitz
2019-08-25 13:35 ` Sam Eiderman via Qemu-devel
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 5/8] bootdevice: Gather LCHS from all relevant devices Sam Eiderman
2019-08-13 19:05 ` Max Reitz
2019-08-25 13:38 ` Sam Eiderman via Qemu-devel
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 6/8] bootdevice: Refactor get_boot_devices_list Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 7/8] bootdevice: FW_CFG interface for LCHS values Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 8/8] hd-geo-test: Add tests for lchs override Sam Eiderman
2019-07-01 7:41 ` [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface Gerd Hoffmann
2019-07-08 17:30 ` Sam Eiderman
2019-07-17 19:03 ` Sam Eiderman
2019-07-17 19:46 ` Kevin Wolf
2019-07-19 10:10 ` Sam Eiderman
2019-07-25 0:47 ` [Qemu-devel] [Qemu-block] " John Snow
2019-07-25 0:50 ` John Snow
2019-07-25 19:42 ` Laszlo Ersek
2019-07-30 11:35 ` Gerd Hoffmann
2019-08-13 19:35 ` [Qemu-devel] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e72a67-4107-4cbb-10e6-6a77011f34ce@redhat.com \
--to=mreitz@redhat.com \
--cc=arbel.moshe@oracle.com \
--cc=karl.heubaum@oracle.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=liran.alon@oracle.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=shmuel.eiderman@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).