* [Qemu-devel] Fix cacheline size retrieval on FreeBSD/PowerPC(64) @ 2019-06-07 18:56 Justin Hibbits 2019-06-26 16:14 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier 0 siblings, 1 reply; 14+ messages in thread From: Justin Hibbits @ 2019-06-07 18:56 UTC (permalink / raw) To: qemu-devel; +Cc: qemu-trivial [-- Attachment #1: Type: text/plain, Size: 139 bytes --] The attached very trivial patch fixes a startup bug that prevents at least Qemu 3.1 and later from working on FreeBSD/powerpc64. - Justin [-- Attachment #2: 0001-Fix-cacheline-detection-on-FreeBSD-powerpc.patch --] [-- Type: text/x-patch, Size: 1089 bytes --] From 74a70fdcfa5347e7637aa36276c55781f19de72a Mon Sep 17 00:00:00 2001 From: Justin Hibbits <chmeeedalf@gmail.com> Date: Fri, 7 Jun 2019 13:44:51 -0500 Subject: [PATCH] Fix cacheline detection on FreeBSD/powerpc. machdep.cacheline_size is an integer, not a long. Since PowerPC is big-endian this causes sysctlbyname() to fill in the upper bits of the argument, rather than the correct 'lower bits' of the word. Specify the correct type to fix this. Signed-off-by: Justin Hibbits <chmeeedalf@gmail.com> --- util/cacheinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cacheinfo.c b/util/cacheinfo.c index eebe1ce9c5..516f837748 100644 --- a/util/cacheinfo.c +++ b/util/cacheinfo.c @@ -77,7 +77,7 @@ static void sys_cache_info(int *isize, int *dsize) static void sys_cache_info(int *isize, int *dsize) { /* There's only a single sysctl for both I/D cache line sizes. */ - long size; + int size; size_t len = sizeof(size); if (!sysctlbyname(SYSCTL_CACHELINE_NAME, &size, &len, NULL, 0)) { *isize = *dsize = size; -- 2.21.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-07 18:56 [Qemu-devel] Fix cacheline size retrieval on FreeBSD/PowerPC(64) Justin Hibbits @ 2019-06-26 16:14 ` Laurent Vivier 2019-06-26 16:16 ` Laurent Vivier 0 siblings, 1 reply; 14+ messages in thread From: Laurent Vivier @ 2019-06-26 16:14 UTC (permalink / raw) To: Justin Hibbits, qemu-devel; +Cc: qemu-trivial Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > The attached very trivial patch fixes a startup bug that prevents at > least Qemu 3.1 and later from working on FreeBSD/powerpc64. > > - Justin > Please don't send a patch in attachment but inlined in the message (you may use "git send-email" for that). This patch fixes "util: add cacheinfo" that has changed the type from unsigned to long. You can add the following line in the commit message: Fixes: b255b2c8a548 ("util: add cacheinfo") Reviewed-by: Laurent Vivier <laurent@vivier.eu> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-26 16:14 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier @ 2019-06-26 16:16 ` Laurent Vivier 2019-06-26 16:37 ` Justin Hibbits 0 siblings, 1 reply; 14+ messages in thread From: Laurent Vivier @ 2019-06-26 16:16 UTC (permalink / raw) To: Justin Hibbits, qemu-devel; +Cc: qemu-trivial, Emilio G. Cota Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > Le 07/06/2019 à 20:56, Justin Hibbits a écrit : >> The attached very trivial patch fixes a startup bug that prevents at >> least Qemu 3.1 and later from working on FreeBSD/powerpc64. >> >> - Justin >> > > Please don't send a patch in attachment but inlined in the message > (you may use "git send-email" for that). > > This patch fixes "util: add cacheinfo" that has changed the type from > unsigned to long. > > You can add the following line in the commit message: > > Fixes: b255b2c8a548 ("util: add cacheinfo") > > Reviewed-by: Laurent Vivier <laurent@vivier.eu> > CC: author of b255b2c8a548 ("util: add cacheinfo") Thanks, Laurent ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-26 16:16 ` Laurent Vivier @ 2019-06-26 16:37 ` Justin Hibbits 2019-06-26 16:47 ` Laurent Vivier 2019-07-01 14:08 ` Christophe de Dinechin 0 siblings, 2 replies; 14+ messages in thread From: Justin Hibbits @ 2019-06-26 16:37 UTC (permalink / raw) To: Laurent Vivier; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel On Wed, 26 Jun 2019 18:16:36 +0200 Laurent Vivier <laurent@vivier.eu> wrote: > Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > > Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > >> The attached very trivial patch fixes a startup bug that prevents > >> at least Qemu 3.1 and later from working on FreeBSD/powerpc64. > >> > >> - Justin > >> > > > > Please don't send a patch in attachment but inlined in the message > > (you may use "git send-email" for that). > > > > This patch fixes "util: add cacheinfo" that has changed the type > > from unsigned to long. > > > > You can add the following line in the commit message: > > > > Fixes: b255b2c8a548 ("util: add cacheinfo") > > > > Reviewed-by: Laurent Vivier <laurent@vivier.eu> > > > > CC: author of b255b2c8a548 ("util: add cacheinfo") > > Thanks, > Laurent Hi Laurent, Sorry. I had never used git send-email before, so wasn't comfortable with it. I just updated the commit message with your feedback and used git send-email to submit the patch. I hope everything went well. Thanks for your feedback. - Justin ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-26 16:37 ` Justin Hibbits @ 2019-06-26 16:47 ` Laurent Vivier 2019-06-26 18:04 ` Justin Hibbits 2019-07-01 14:08 ` Christophe de Dinechin 1 sibling, 1 reply; 14+ messages in thread From: Laurent Vivier @ 2019-06-26 16:47 UTC (permalink / raw) To: Justin Hibbits; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > On Wed, 26 Jun 2019 18:16:36 +0200 > Laurent Vivier <laurent@vivier.eu> wrote: > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : >>>> The attached very trivial patch fixes a startup bug that prevents >>>> at least Qemu 3.1 and later from working on FreeBSD/powerpc64. >>>> >>>> - Justin >>>> >>> >>> Please don't send a patch in attachment but inlined in the message >>> (you may use "git send-email" for that). >>> >>> This patch fixes "util: add cacheinfo" that has changed the type >>> from unsigned to long. >>> >>> You can add the following line in the commit message: >>> >>> Fixes: b255b2c8a548 ("util: add cacheinfo") >>> >>> Reviewed-by: Laurent Vivier <laurent@vivier.eu> >>> >> >> CC: author of b255b2c8a548 ("util: add cacheinfo") >> >> Thanks, >> Laurent > > Hi Laurent, > > Sorry. I had never used git send-email before, so wasn't comfortable > with it. I just updated the commit message with your feedback and used > git send-email to submit the patch. I hope everything went well. It seems not. I didn't receive it. Did you configure the SMTP server. See git-send-email(1): Use gmail as the smtp server To use git send-email to send your patches through the GMail SMTP server, edit ~/.gitconfig to specify your account settings: [sendemail] smtpEncryption = tls smtpServer = smtp.gmail.com smtpUser = yourname@gmail.com smtpServerPort = 587 If you have multifactor authentication setup on your gmail account, you will need to generate an app-specific password for use with git send-email. Visit https://security.google.com/settings/security/apppasswords to create it. Once your commits are ready to be sent to the mailing list, run the following commands: $ git format-patch --cover-letter -M origin/master -o outgoing/ $ edit outgoing/0000-* $ git send-email outgoing/* The first time you run it, you will be prompted for your credentials. Enter the app-specific or your regular password as appropriate. If you have credential helper configured (see git-credential(1)), the password will be saved in the credential store so you won’t have to type it the next time. Note: the following perl modules are required Net::SMTP::SSL, MIME::Base64 and Authen::SASL Thanks, Laurent ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-26 16:47 ` Laurent Vivier @ 2019-06-26 18:04 ` Justin Hibbits 2019-06-27 0:02 ` Justin Hibbits 0 siblings, 1 reply; 14+ messages in thread From: Justin Hibbits @ 2019-06-26 18:04 UTC (permalink / raw) To: Laurent Vivier; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel On Wed, 26 Jun 2019 18:47:42 +0200 Laurent Vivier <laurent@vivier.eu> wrote: > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > On Wed, 26 Jun 2019 18:16:36 +0200 > > Laurent Vivier <laurent@vivier.eu> wrote: > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > >>>> The attached very trivial patch fixes a startup bug that prevents > >>>> at least Qemu 3.1 and later from working on FreeBSD/powerpc64. > >>>> > >>>> - Justin > >>>> > >>> > >>> Please don't send a patch in attachment but inlined in the message > >>> (you may use "git send-email" for that). > >>> > >>> This patch fixes "util: add cacheinfo" that has changed the type > >>> from unsigned to long. > >>> > >>> You can add the following line in the commit message: > >>> > >>> Fixes: b255b2c8a548 ("util: add cacheinfo") > >>> > >>> Reviewed-by: Laurent Vivier <laurent@vivier.eu> > >>> > >> > >> CC: author of b255b2c8a548 ("util: add cacheinfo") > >> > >> Thanks, > >> Laurent > > > > Hi Laurent, > > > > Sorry. I had never used git send-email before, so wasn't > > comfortable with it. I just updated the commit message with your > > feedback and used git send-email to submit the patch. I hope > > everything went well. > > It seems not. I didn't receive it. > > Did you configure the SMTP server. See git-send-email(1): > > Use gmail as the smtp server > > To use git send-email to send your patches through the GMail > SMTP server, edit ~/.gitconfig to specify your account settings: > > [sendemail] > smtpEncryption = tls > smtpServer = smtp.gmail.com > smtpUser = yourname@gmail.com > smtpServerPort = 587 > > If you have multifactor authentication setup on your gmail > account, you will need to generate an app-specific password for use > with git send-email. Visit > https://security.google.com/settings/security/apppasswords to > create it. > > Once your commits are ready to be sent to the mailing list, > run the following commands: > > $ git format-patch --cover-letter -M origin/master -o > outgoing/ $ edit outgoing/0000-* > $ git send-email outgoing/* > > The first time you run it, you will be prompted for your > credentials. Enter the app-specific or your regular password as > appropriate. If you have credential helper configured (see > git-credential(1)), the password will be saved in the credential > store so you won’t have to type it the next time. > > Note: the following perl modules are required Net::SMTP::SSL, > MIME::Base64 and Authen::SASL > > Thanks, > Laurent > > Hm, you're right. Even after making the config changes and installing the necessary packages, I still have no luck with git send-email. Might take a bit to debug this. - Justin ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-26 18:04 ` Justin Hibbits @ 2019-06-27 0:02 ` Justin Hibbits 2019-06-27 0:08 ` Laurent Vivier 0 siblings, 1 reply; 14+ messages in thread From: Justin Hibbits @ 2019-06-27 0:02 UTC (permalink / raw) To: Laurent Vivier; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel On Wed, Jun 26, 2019, 13:04 Justin Hibbits <chmeeedalf@gmail.com> wrote: > On Wed, 26 Jun 2019 18:47:42 +0200 > Laurent Vivier <laurent@vivier.eu> wrote: > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > > On Wed, 26 Jun 2019 18:16:36 +0200 > > > Laurent Vivier <laurent@vivier.eu> wrote: > > > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > > >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > > >>>> The attached very trivial patch fixes a startup bug that prevents > > >>>> at least Qemu 3.1 and later from working on FreeBSD/powerpc64. > > >>>> > > >>>> - Justin > > >>>> > > >>> > > >>> Please don't send a patch in attachment but inlined in the message > > >>> (you may use "git send-email" for that). > > >>> > > >>> This patch fixes "util: add cacheinfo" that has changed the type > > >>> from unsigned to long. > > >>> > > >>> You can add the following line in the commit message: > > >>> > > >>> Fixes: b255b2c8a548 ("util: add cacheinfo") > > >>> > > >>> Reviewed-by: Laurent Vivier <laurent@vivier.eu> > > >>> > > >> > > >> CC: author of b255b2c8a548 ("util: add cacheinfo") > > >> > > >> Thanks, > > >> Laurent > > > > > > Hi Laurent, > > > > > > Sorry. I had never used git send-email before, so wasn't > > > comfortable with it. I just updated the commit message with your > > > feedback and used git send-email to submit the patch. I hope > > > everything went well. > > > > It seems not. I didn't receive it. > > > > Did you configure the SMTP server. See git-send-email(1): > > > > Use gmail as the smtp server > > > > To use git send-email to send your patches through the GMail > > SMTP server, edit ~/.gitconfig to specify your account settings: > > > > [sendemail] > > smtpEncryption = tls > > smtpServer = smtp.gmail.com > > smtpUser = yourname@gmail.com > > smtpServerPort = 587 > > > > If you have multifactor authentication setup on your gmail > > account, you will need to generate an app-specific password for use > > with git send-email. Visit > > https://security.google.com/settings/security/apppasswords to > > create it. > > > > Once your commits are ready to be sent to the mailing list, > > run the following commands: > > > > $ git format-patch --cover-letter -M origin/master -o > > outgoing/ $ edit outgoing/0000-* > > $ git send-email outgoing/* > > > > The first time you run it, you will be prompted for your > > credentials. Enter the app-specific or your regular password as > > appropriate. If you have credential helper configured (see > > git-credential(1)), the password will be saved in the credential > > store so you won’t have to type it the next time. > > > > Note: the following perl modules are required Net::SMTP::SSL, > > MIME::Base64 and Authen::SASL > > > > Thanks, > > Laurent > > > > > > Hm, you're right. Even after making the config changes and installing > the necessary packages, I still have no luck with git send-email. Might > take a bit to debug this. > > - Justin > Sorry for the multiplicity, looks like Gmail forwarded it eventually, but not until I tried several times debugging it. - Justin > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-27 0:02 ` Justin Hibbits @ 2019-06-27 0:08 ` Laurent Vivier 2019-06-27 0:15 ` Justin Hibbits 0 siblings, 1 reply; 14+ messages in thread From: Laurent Vivier @ 2019-06-27 0:08 UTC (permalink / raw) To: Justin Hibbits; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits <chmeeedalf@gmail.com > <mailto:chmeeedalf@gmail.com>> wrote: > > On Wed, 26 Jun 2019 18:47:42 +0200 > Laurent Vivier <laurent@vivier.eu <mailto:laurent@vivier.eu>> wrote: > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > > On Wed, 26 Jun 2019 18:16:36 +0200 > > > Laurent Vivier <laurent@vivier.eu <mailto:laurent@vivier.eu>> wrote: > > > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > > >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > > >>>> The attached very trivial patch fixes a startup bug that prevents > > >>>> at least Qemu 3.1 and later from working on FreeBSD/powerpc64. > > >>>> > > >>>> - Justin > > >>>> > > >>> > > >>> Please don't send a patch in attachment but inlined in the message > > >>> (you may use "git send-email" for that). > > >>> > > >>> This patch fixes "util: add cacheinfo" that has changed the type > > >>> from unsigned to long. > > >>> > > >>> You can add the following line in the commit message: > > >>> > > >>> Fixes: b255b2c8a548 ("util: add cacheinfo") > > >>> > > >>> Reviewed-by: Laurent Vivier <laurent@vivier.eu > <mailto:laurent@vivier.eu>> > > >>> > > >> > > >> CC: author of b255b2c8a548 ("util: add cacheinfo") > > >> > > >> Thanks, > > >> Laurent > > > > > > Hi Laurent, > > > > > > Sorry. I had never used git send-email before, so wasn't > > > comfortable with it. I just updated the commit message with your > > > feedback and used git send-email to submit the patch. I hope > > > everything went well. > > > > It seems not. I didn't receive it. > > > > Did you configure the SMTP server. See git-send-email(1): > > > > Use gmail as the smtp server > > > > To use git send-email to send your patches through the GMail > > SMTP server, edit ~/.gitconfig to specify your account settings: > > > > [sendemail] > > smtpEncryption = tls > > smtpServer = smtp.gmail.com <http://smtp.gmail.com> > > smtpUser = yourname@gmail.com > <mailto:yourname@gmail.com> > > smtpServerPort = 587 > > > > If you have multifactor authentication setup on your gmail > > account, you will need to generate an app-specific password for use > > with git send-email. Visit > > https://security.google.com/settings/security/apppasswords to > > create it. > > > > Once your commits are ready to be sent to the mailing list, > > run the following commands: > > > > $ git format-patch --cover-letter -M origin/master -o > > outgoing/ $ edit outgoing/0000-* > > $ git send-email outgoing/* > > > > The first time you run it, you will be prompted for your > > credentials. Enter the app-specific or your regular password as > > appropriate. If you have credential helper configured (see > > git-credential(1)), the password will be saved in the credential > > store so you won’t have to type it the next time. > > > > Note: the following perl modules are required Net::SMTP::SSL, > > MIME::Base64 and Authen::SASL > > > > Thanks, > > Laurent > > > > > > Hm, you're right. Even after making the config changes and installing > the necessary packages, I still have no luck with git send-email. Might > take a bit to debug this. > > - Justin > > > Sorry for the multiplicity, looks like Gmail forwarded it eventually, > but not until I tried several times debugging it. Not sure, I didn't receive any of them. Thanks, Laurent ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-27 0:08 ` Laurent Vivier @ 2019-06-27 0:15 ` Justin Hibbits 2019-07-01 8:54 ` Laurent Vivier 0 siblings, 1 reply; 14+ messages in thread From: Justin Hibbits @ 2019-06-27 0:15 UTC (permalink / raw) To: Laurent Vivier; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel On Wed, Jun 26, 2019, 19:08 Laurent Vivier <laurent@vivier.eu> wrote: > Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits <chmeeedalf@gmail.com > > <mailto:chmeeedalf@gmail.com>> wrote: > > > > On Wed, 26 Jun 2019 18:47:42 +0200 > > Laurent Vivier <laurent@vivier.eu <mailto:laurent@vivier.eu>> wrote: > > > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > > > On Wed, 26 Jun 2019 18:16:36 +0200 > > > > Laurent Vivier <laurent@vivier.eu <mailto:laurent@vivier.eu>> > wrote: > > > > > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > > > >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > > > >>>> The attached very trivial patch fixes a startup bug that > prevents > > > >>>> at least Qemu 3.1 and later from working on FreeBSD/powerpc64. > > > >>>> > > > >>>> - Justin > > > >>>> > > > >>> > > > >>> Please don't send a patch in attachment but inlined in the > message > > > >>> (you may use "git send-email" for that). > > > >>> > > > >>> This patch fixes "util: add cacheinfo" that has changed the > type > > > >>> from unsigned to long. > > > >>> > > > >>> You can add the following line in the commit message: > > > >>> > > > >>> Fixes: b255b2c8a548 ("util: add cacheinfo") > > > >>> > > > >>> Reviewed-by: Laurent Vivier <laurent@vivier.eu > > <mailto:laurent@vivier.eu>> > > > >>> > > > >> > > > >> CC: author of b255b2c8a548 ("util: add cacheinfo") > > > >> > > > >> Thanks, > > > >> Laurent > > > > > > > > Hi Laurent, > > > > > > > > Sorry. I had never used git send-email before, so wasn't > > > > comfortable with it. I just updated the commit message with your > > > > feedback and used git send-email to submit the patch. I hope > > > > everything went well. > > > > > > It seems not. I didn't receive it. > > > > > > Did you configure the SMTP server. See git-send-email(1): > > > > > > Use gmail as the smtp server > > > > > > To use git send-email to send your patches through the GMail > > > SMTP server, edit ~/.gitconfig to specify your account settings: > > > > > > [sendemail] > > > smtpEncryption = tls > > > smtpServer = smtp.gmail.com < > http://smtp.gmail.com> > > > smtpUser = yourname@gmail.com > > <mailto:yourname@gmail.com> > > > smtpServerPort = 587 > > > > > > If you have multifactor authentication setup on your gmail > > > account, you will need to generate an app-specific password for use > > > with git send-email. Visit > > > https://security.google.com/settings/security/apppasswords > to > > > create it. > > > > > > Once your commits are ready to be sent to the mailing list, > > > run the following commands: > > > > > > $ git format-patch --cover-letter -M origin/master -o > > > outgoing/ $ edit outgoing/0000-* > > > $ git send-email outgoing/* > > > > > > The first time you run it, you will be prompted for your > > > credentials. Enter the app-specific or your regular password as > > > appropriate. If you have credential helper configured (see > > > git-credential(1)), the password will be saved in the credential > > > store so you won’t have to type it the next time. > > > > > > Note: the following perl modules are required > Net::SMTP::SSL, > > > MIME::Base64 and Authen::SASL > > > > > > Thanks, > > > Laurent > > > > > > > > > > Hm, you're right. Even after making the config changes and > installing > > the necessary packages, I still have no luck with git send-email. > Might > > take a bit to debug this. > > > > - Justin > > > > > > Sorry for the multiplicity, looks like Gmail forwarded it eventually, > > but not until I tried several times debugging it. > > Not sure, I didn't receive any of them. > > Thanks, > Laurent > Sigh, 4 copies ended up in my Gmail spam folder, so I thought it made it through. - Justin > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-27 0:15 ` Justin Hibbits @ 2019-07-01 8:54 ` Laurent Vivier 2019-07-01 13:02 ` Justin Hibbits 0 siblings, 1 reply; 14+ messages in thread From: Laurent Vivier @ 2019-07-01 8:54 UTC (permalink / raw) To: Justin Hibbits; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel Le 27/06/2019 à 02:15, Justin Hibbits a écrit : > > > On Wed, Jun 26, 2019, 19:08 Laurent Vivier <laurent@vivier.eu > <mailto:laurent@vivier.eu>> wrote: > > Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits <chmeeedalf@gmail.com > <mailto:chmeeedalf@gmail.com> > > <mailto:chmeeedalf@gmail.com <mailto:chmeeedalf@gmail.com>>> wrote: > > > > On Wed, 26 Jun 2019 18:47:42 +0200 > > Laurent Vivier <laurent@vivier.eu <mailto:laurent@vivier.eu> > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>> wrote: > > > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > > > On Wed, 26 Jun 2019 18:16:36 +0200 > > > > Laurent Vivier <laurent@vivier.eu > <mailto:laurent@vivier.eu> <mailto:laurent@vivier.eu > <mailto:laurent@vivier.eu>>> wrote: > > > > > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > > > >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > > > >>>> The attached very trivial patch fixes a startup bug > that prevents > > > >>>> at least Qemu 3.1 and later from working on > FreeBSD/powerpc64. > > > >>>> > > > >>>> - Justin > > > >>>> > > > >>> > > > >>> Please don't send a patch in attachment but inlined in > the message > > > >>> (you may use "git send-email" for that). > > > >>> > > > >>> This patch fixes "util: add cacheinfo" that has changed > the type > > > >>> from unsigned to long. > > > >>> > > > >>> You can add the following line in the commit message: > > > >>> > > > >>> Fixes: b255b2c8a548 ("util: add cacheinfo") > > > >>> > > > >>> Reviewed-by: Laurent Vivier <laurent@vivier.eu > <mailto:laurent@vivier.eu> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>> > > > >>> > > > >> > > > >> CC: author of b255b2c8a548 ("util: add cacheinfo") > > > >> > > > >> Thanks, > > > >> Laurent > > > > > > > > Hi Laurent, > > > > > > > > Sorry. I had never used git send-email before, so wasn't > > > > comfortable with it. I just updated the commit message > with your > > > > feedback and used git send-email to submit the patch. I hope > > > > everything went well. > > > > > > It seems not. I didn't receive it. > > > > > > Did you configure the SMTP server. See git-send-email(1): > > > > > > Use gmail as the smtp server > > > > > > To use git send-email to send your patches through > the GMail > > > SMTP server, edit ~/.gitconfig to specify your account settings: > > > > > > [sendemail] > > > smtpEncryption = tls > > > smtpServer = smtp.gmail.com > <http://smtp.gmail.com> <http://smtp.gmail.com> > > > smtpUser = yourname@gmail.com > <mailto:yourname@gmail.com> > > <mailto:yourname@gmail.com <mailto:yourname@gmail.com>> > > > smtpServerPort = 587 > > > > > > If you have multifactor authentication setup on your > gmail > > > account, you will need to generate an app-specific password > for use > > > with git send-email. Visit > > > > https://security.google.com/settings/security/apppasswords to > > > create it. > > > > > > Once your commits are ready to be sent to the mailing > list, > > > run the following commands: > > > > > > $ git format-patch --cover-letter -M origin/master -o > > > outgoing/ $ edit outgoing/0000-* > > > $ git send-email outgoing/* > > > > > > The first time you run it, you will be prompted for your > > > credentials. Enter the app-specific or your regular password as > > > appropriate. If you have credential helper configured (see > > > git-credential(1)), the password will be saved in the credential > > > store so you won’t have to type it the next time. > > > > > > Note: the following perl modules are required > Net::SMTP::SSL, > > > MIME::Base64 and Authen::SASL > > > > > > Thanks, > > > Laurent > > > > > > > > > > Hm, you're right. Even after making the config changes and > installing > > the necessary packages, I still have no luck with git > send-email. Might > > take a bit to debug this. > > > > - Justin > > > > > > Sorry for the multiplicity, looks like Gmail forwarded it eventually, > > but not until I tried several times debugging it. > > Not sure, I didn't receive any of them. > > Thanks, > Laurent > > > Sigh, 4 copies ended up in my Gmail spam folder, so I thought it made it > through. > Any news? Freeze is coming. Thanks, Laurent ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-07-01 8:54 ` Laurent Vivier @ 2019-07-01 13:02 ` Justin Hibbits 2019-07-01 13:17 ` Laurent Vivier 0 siblings, 1 reply; 14+ messages in thread From: Justin Hibbits @ 2019-07-01 13:02 UTC (permalink / raw) To: Laurent Vivier; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel On Mon, Jul 1, 2019, 03:54 Laurent Vivier <laurent@vivier.eu> wrote: > Le 27/06/2019 à 02:15, Justin Hibbits a écrit : > > > > > > On Wed, Jun 26, 2019, 19:08 Laurent Vivier <laurent@vivier.eu > > <mailto:laurent@vivier.eu>> wrote: > > > > Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > > > > > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits <chmeeedalf@gmail.com > > <mailto:chmeeedalf@gmail.com> > > > <mailto:chmeeedalf@gmail.com <mailto:chmeeedalf@gmail.com>>> > wrote: > > > > > > On Wed, 26 Jun 2019 18:47:42 +0200 > > > Laurent Vivier <laurent@vivier.eu <mailto:laurent@vivier.eu> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>> wrote: > > > > > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > > > > On Wed, 26 Jun 2019 18:16:36 +0200 > > > > > Laurent Vivier <laurent@vivier.eu > > <mailto:laurent@vivier.eu> <mailto:laurent@vivier.eu > > <mailto:laurent@vivier.eu>>> wrote: > > > > > > > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > > > > >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > > > > >>>> The attached very trivial patch fixes a startup bug > > that prevents > > > > >>>> at least Qemu 3.1 and later from working on > > FreeBSD/powerpc64. > > > > >>>> > > > > >>>> - Justin > > > > >>>> > > > > >>> > > > > >>> Please don't send a patch in attachment but inlined in > > the message > > > > >>> (you may use "git send-email" for that). > > > > >>> > > > > >>> This patch fixes "util: add cacheinfo" that has changed > > the type > > > > >>> from unsigned to long. > > > > >>> > > > > >>> You can add the following line in the commit message: > > > > >>> > > > > >>> Fixes: b255b2c8a548 ("util: add cacheinfo") > > > > >>> > > > > >>> Reviewed-by: Laurent Vivier <laurent@vivier.eu > > <mailto:laurent@vivier.eu> > > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>> > > > > >>> > > > > >> > > > > >> CC: author of b255b2c8a548 ("util: add cacheinfo") > > > > >> > > > > >> Thanks, > > > > >> Laurent > > > > > > > > > > Hi Laurent, > > > > > > > > > > Sorry. I had never used git send-email before, so wasn't > > > > > comfortable with it. I just updated the commit message > > with your > > > > > feedback and used git send-email to submit the patch. I > hope > > > > > everything went well. > > > > > > > > It seems not. I didn't receive it. > > > > > > > > Did you configure the SMTP server. See git-send-email(1): > > > > > > > > Use gmail as the smtp server > > > > > > > > To use git send-email to send your patches through > > the GMail > > > > SMTP server, edit ~/.gitconfig to specify your account > settings: > > > > > > > > [sendemail] > > > > smtpEncryption = tls > > > > smtpServer = smtp.gmail.com > > <http://smtp.gmail.com> <http://smtp.gmail.com> > > > > smtpUser = yourname@gmail.com > > <mailto:yourname@gmail.com> > > > <mailto:yourname@gmail.com <mailto:yourname@gmail.com>> > > > > smtpServerPort = 587 > > > > > > > > If you have multifactor authentication setup on your > > gmail > > > > account, you will need to generate an app-specific password > > for use > > > > with git send-email. Visit > > > > > > https://security.google.com/settings/security/apppasswords to > > > > create it. > > > > > > > > Once your commits are ready to be sent to the mailing > > list, > > > > run the following commands: > > > > > > > > $ git format-patch --cover-letter -M > origin/master -o > > > > outgoing/ $ edit outgoing/0000-* > > > > $ git send-email outgoing/* > > > > > > > > The first time you run it, you will be prompted for > your > > > > credentials. Enter the app-specific or your regular password > as > > > > appropriate. If you have credential helper configured (see > > > > git-credential(1)), the password will be saved in the > credential > > > > store so you won’t have to type it the next time. > > > > > > > > Note: the following perl modules are required > > Net::SMTP::SSL, > > > > MIME::Base64 and Authen::SASL > > > > > > > > Thanks, > > > > Laurent > > > > > > > > > > > > > > Hm, you're right. Even after making the config changes and > > installing > > > the necessary packages, I still have no luck with git > > send-email. Might > > > take a bit to debug this. > > > > > > - Justin > > > > > > > > > Sorry for the multiplicity, looks like Gmail forwarded it > eventually, > > > but not until I tried several times debugging it. > > > > Not sure, I didn't receive any of them. > > > > Thanks, > > Laurent > > > > > > Sigh, 4 copies ended up in my Gmail spam folder, so I thought it made it > > through. > > > > Any news? Freeze is coming. > > Thanks, > Laurent > I'll manually do it when I get home tomorrow. Fixing git send-email will have to wait. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-07-01 13:02 ` Justin Hibbits @ 2019-07-01 13:17 ` Laurent Vivier 2019-07-02 22:11 ` Justin Hibbits 0 siblings, 1 reply; 14+ messages in thread From: Laurent Vivier @ 2019-07-01 13:17 UTC (permalink / raw) To: Justin Hibbits; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel Le 01/07/2019 à 15:02, Justin Hibbits a écrit : > > > On Mon, Jul 1, 2019, 03:54 Laurent Vivier <laurent@vivier.eu > <mailto:laurent@vivier.eu>> wrote: > > Le 27/06/2019 à 02:15, Justin Hibbits a écrit : > > > > > > On Wed, Jun 26, 2019, 19:08 Laurent Vivier <laurent@vivier.eu > <mailto:laurent@vivier.eu> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>> wrote: > > > > Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > > > > > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits > <chmeeedalf@gmail.com <mailto:chmeeedalf@gmail.com> > > <mailto:chmeeedalf@gmail.com <mailto:chmeeedalf@gmail.com>> > > > <mailto:chmeeedalf@gmail.com <mailto:chmeeedalf@gmail.com> > <mailto:chmeeedalf@gmail.com <mailto:chmeeedalf@gmail.com>>>> wrote: > > > > > > On Wed, 26 Jun 2019 18:47:42 +0200 > > > Laurent Vivier <laurent@vivier.eu > <mailto:laurent@vivier.eu> <mailto:laurent@vivier.eu > <mailto:laurent@vivier.eu>> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu> > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>>> wrote: > > > > > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > > > > On Wed, 26 Jun 2019 18:16:36 +0200 > > > > > Laurent Vivier <laurent@vivier.eu > <mailto:laurent@vivier.eu> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>> > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>>> wrote: > > > > > > > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : > > > > >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit : > > > > >>>> The attached very trivial patch fixes a startup bug > > that prevents > > > > >>>> at least Qemu 3.1 and later from working on > > FreeBSD/powerpc64. > > > > >>>> > > > > >>>> - Justin > > > > >>>> > > > > >>> > > > > >>> Please don't send a patch in attachment but inlined in > > the message > > > > >>> (you may use "git send-email" for that). > > > > >>> > > > > >>> This patch fixes "util: add cacheinfo" that has > changed > > the type > > > > >>> from unsigned to long. > > > > >>> > > > > >>> You can add the following line in the commit message: > > > > >>> > > > > >>> Fixes: b255b2c8a548 ("util: add cacheinfo") > > > > >>> > > > > >>> Reviewed-by: Laurent Vivier <laurent@vivier.eu > <mailto:laurent@vivier.eu> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>> > > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu> > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>>> > > > > >>> > > > > >> > > > > >> CC: author of b255b2c8a548 ("util: add cacheinfo") > > > > >> > > > > >> Thanks, > > > > >> Laurent > > > > > > > > > > Hi Laurent, > > > > > > > > > > Sorry. I had never used git send-email before, so > wasn't > > > > > comfortable with it. I just updated the commit message > > with your > > > > > feedback and used git send-email to submit the > patch. I hope > > > > > everything went well. > > > > > > > > It seems not. I didn't receive it. > > > > > > > > Did you configure the SMTP server. See git-send-email(1): > > > > > > > > Use gmail as the smtp server > > > > > > > > To use git send-email to send your patches through > > the GMail > > > > SMTP server, edit ~/.gitconfig to specify your account > settings: > > > > > > > > [sendemail] > > > > smtpEncryption = tls > > > > smtpServer = smtp.gmail.com > <http://smtp.gmail.com> > > <http://smtp.gmail.com> <http://smtp.gmail.com> > > > > smtpUser = yourname@gmail.com > <mailto:yourname@gmail.com> > > <mailto:yourname@gmail.com <mailto:yourname@gmail.com>> > > > <mailto:yourname@gmail.com <mailto:yourname@gmail.com> > <mailto:yourname@gmail.com <mailto:yourname@gmail.com>>> > > > > smtpServerPort = 587 > > > > > > > > If you have multifactor authentication setup on > your > > gmail > > > > account, you will need to generate an app-specific > password > > for use > > > > with git send-email. Visit > > > > > > https://security.google.com/settings/security/apppasswords to > > > > create it. > > > > > > > > Once your commits are ready to be sent to the > mailing > > list, > > > > run the following commands: > > > > > > > > $ git format-patch --cover-letter -M > origin/master -o > > > > outgoing/ $ edit outgoing/0000-* > > > > $ git send-email outgoing/* > > > > > > > > The first time you run it, you will be prompted > for your > > > > credentials. Enter the app-specific or your regular > password as > > > > appropriate. If you have credential helper configured (see > > > > git-credential(1)), the password will be saved in the > credential > > > > store so you won’t have to type it the next time. > > > > > > > > Note: the following perl modules are required > > Net::SMTP::SSL, > > > > MIME::Base64 and Authen::SASL > > > > > > > > Thanks, > > > > Laurent > > > > > > > > > > > > > > Hm, you're right. Even after making the config changes and > > installing > > > the necessary packages, I still have no luck with git > > send-email. Might > > > take a bit to debug this. > > > > > > - Justin > > > > > > > > > Sorry for the multiplicity, looks like Gmail forwarded it > eventually, > > > but not until I tried several times debugging it. > > > > Not sure, I didn't receive any of them. > > > > Thanks, > > Laurent > > > > > > Sigh, 4 copies ended up in my Gmail spam folder, so I thought it > made it > > through. > > > > Any news? Freeze is coming. > > Thanks, > Laurent > > > I'll manually do it when I get home tomorrow. Fixing git send-email > will have to wait. Don't bother: if you have problems with "git send-email" I can apply the attachment. Thanks, Laurent ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-07-01 13:17 ` Laurent Vivier @ 2019-07-02 22:11 ` Justin Hibbits 0 siblings, 0 replies; 14+ messages in thread From: Justin Hibbits @ 2019-07-02 22:11 UTC (permalink / raw) To: Laurent Vivier; +Cc: qemu-trivial, Emilio G. Cota, qemu-devel On Mon, 1 Jul 2019 15:17:06 +0200 Laurent Vivier <laurent@vivier.eu> wrote: > Le 01/07/2019 à 15:02, Justin Hibbits a écrit : > > > > > > On Mon, Jul 1, 2019, 03:54 Laurent Vivier <laurent@vivier.eu > > <mailto:laurent@vivier.eu>> wrote: > > > > Le 27/06/2019 à 02:15, Justin Hibbits a écrit : > > > > > > > > > On Wed, Jun 26, 2019, 19:08 Laurent Vivier > > > <laurent@vivier.eu > > <mailto:laurent@vivier.eu> > > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>> wrote: > > > > > > Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > > > > > > > > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits > > <chmeeedalf@gmail.com <mailto:chmeeedalf@gmail.com> > > > <mailto:chmeeedalf@gmail.com > > ><mailto:chmeeedalf@gmail.com>> > <mailto:chmeeedalf@gmail.com > > ><mailto:chmeeedalf@gmail.com> > > <mailto:chmeeedalf@gmail.com <mailto:chmeeedalf@gmail.com>>>> > > wrote: > > > > > > > > On Wed, 26 Jun 2019 18:47:42 +0200 > > > > Laurent Vivier <laurent@vivier.eu > > <mailto:laurent@vivier.eu> <mailto:laurent@vivier.eu > > <mailto:laurent@vivier.eu>> > > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>>> wrote: > > > > > > > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > > > > > On Wed, 26 Jun 2019 18:16:36 +0200 > > > > > > Laurent Vivier <laurent@vivier.eu > > <mailto:laurent@vivier.eu> > > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu> > > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>>> > > >wrote: > > > > > > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a > > >écrit : > > >>> Le 07/06/2019 à 20:56, Justin Hibbits a > > >écrit : > > >>>> The attached very trivial patch fixes a > > >startup bug that prevents > > > > > >>>> at least Qemu 3.1 and later from working on > > > FreeBSD/powerpc64. > > > > > >>>> > > > > > >>>> - Justin > > > > > >>>> > > > > > >>> > > > > > >>> Please don't send a patch in attachment but > > >inlined in the message > > > > > >>> (you may use "git send-email" for that). > > > > > >>> > > > > > >>> This patch fixes "util: add cacheinfo" that > > >has > > changed > > > the type > > > > > >>> from unsigned to long. > > > > > >>> > > > > > >>> You can add the following line in the commit > > >message: > > >>> > > > > > >>> Fixes: b255b2c8a548 ("util: add cacheinfo") > > > > > >>> > > > > > >>> Reviewed-by: Laurent Vivier > > ><laurent@vivier.eu > > <mailto:laurent@vivier.eu> > > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>> > > > > <mailto:laurent@vivier.eu > > ><mailto:laurent@vivier.eu> > > <mailto:laurent@vivier.eu <mailto:laurent@vivier.eu>>>> > > > > > >>> > > > > > >> > > > > > >> CC: author of b255b2c8a548 ("util: add > > >cacheinfo") > > >> > > > > > >> Thanks, > > > > > >> Laurent > > > > > > > > > > > > Hi Laurent, > > > > > > > > > > > > Sorry. I had never used git send-email before, > > >so > > wasn't > > > > > > comfortable with it. I just updated the commit > > >message with your > > > > > > feedback and used git send-email to submit the > > patch. I hope > > > > > > everything went well. > > > > > > > > > > It seems not. I didn't receive it. > > > > > > > > > > Did you configure the SMTP server. See > > >git-send-email(1): > > > > > > > Use gmail as the smtp server > > > > > > > > > > To use git send-email to send your patches > > >through the GMail > > > > > SMTP server, edit ~/.gitconfig to specify your > > >account > > settings: > > > > > > > > > > [sendemail] > > > > > smtpEncryption = tls > > > > > smtpServer = smtp.gmail.com > > <http://smtp.gmail.com> > > > <http://smtp.gmail.com> <http://smtp.gmail.com> > > > > > smtpUser = yourname@gmail.com > > <mailto:yourname@gmail.com> > > > <mailto:yourname@gmail.com <mailto:yourname@gmail.com>> > > > > <mailto:yourname@gmail.com > > ><mailto:yourname@gmail.com> > > <mailto:yourname@gmail.com <mailto:yourname@gmail.com>>> > > > > > smtpServerPort = 587 > > > > > > > > > > If you have multifactor authentication > > >setup on > > your > > > gmail > > > > > account, you will need to generate an > > >app-specific > > password > > > for use > > > > > with git send-email. Visit > > > > > > > > https://security.google.com/settings/security/apppasswords > > >to > > create it. > > > > > > > > > > Once your commits are ready to be sent to > > >the > > mailing > > > list, > > > > > run the following commands: > > > > > > > > > > $ git format-patch --cover-letter -M > > origin/master -o > > > > > outgoing/ $ edit outgoing/0000-* > > > > > $ git send-email outgoing/* > > > > > > > > > > The first time you run it, you will be > > >prompted > > for your > > > > > credentials. Enter the app-specific or your > > >regular > > password as > > > > > appropriate. If you have credential helper > > >configured (see > > git-credential(1)), the password will > > >be saved in the > > credential > > > > > store so you won’t have to type it the next time. > > > > > > > > > > Note: the following perl modules are > > >required Net::SMTP::SSL, > > > > > MIME::Base64 and Authen::SASL > > > > > > > > > > Thanks, > > > > > Laurent > > > > > > > > > > > > > > > > > > Hm, you're right. Even after making the config > > >changes and installing > > > > the necessary packages, I still have no luck with > > >git send-email. Might > > > > take a bit to debug this. > > > > > > > > - Justin > > > > > > > > > > > > Sorry for the multiplicity, looks like Gmail forwarded > > >it > > eventually, > > > > but not until I tried several times debugging it. > > > > > > Not sure, I didn't receive any of them. > > > > > > Thanks, > > > Laurent > > > > > > > > > Sigh, 4 copies ended up in my Gmail spam folder, so I thought > > > it > > made it > > > through. > > > > > > > Any news? Freeze is coming. > > > > Thanks, > > Laurent > > > > > > I'll manually do it when I get home tomorrow. Fixing git send-email > > will have to wait. > > Don't bother: if you have problems with "git send-email" I can apply > the attachment. > > Thanks, > Laurent Thanks. Sorry for the troubles. I'll have to spend some time trying to fix git send-email, for the future. - Justin ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64) 2019-06-26 16:37 ` Justin Hibbits 2019-06-26 16:47 ` Laurent Vivier @ 2019-07-01 14:08 ` Christophe de Dinechin 1 sibling, 0 replies; 14+ messages in thread From: Christophe de Dinechin @ 2019-07-01 14:08 UTC (permalink / raw) To: qemu-devel Justin Hibbits writes: > On Wed, 26 Jun 2019 18:16:36 +0200 > Laurent Vivier <laurent@vivier.eu> wrote: > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : >> > Le 07/06/2019 à 20:56, Justin Hibbits a écrit : >> >> The attached very trivial patch fixes a startup bug that prevents >> >> at least Qemu 3.1 and later from working on FreeBSD/powerpc64. >> >> >> >> - Justin >> >> >> > >> > Please don't send a patch in attachment but inlined in the message >> > (you may use "git send-email" for that). >> > >> > This patch fixes "util: add cacheinfo" that has changed the type >> > from unsigned to long. >> > >> > You can add the following line in the commit message: >> > >> > Fixes: b255b2c8a548 ("util: add cacheinfo") >> > >> > Reviewed-by: Laurent Vivier <laurent@vivier.eu> >> > >> >> CC: author of b255b2c8a548 ("util: add cacheinfo") >> >> Thanks, >> Laurent > > Hi Laurent, > > Sorry. I had never used git send-email before, so wasn't comfortable > with it. I just updated the commit message with your feedback and used > git send-email to submit the patch. I hope everything went well. FWIW, there is also a handy git-publish script that is worth looking at. It deals with multiple iterations of a patch and other niceties. https://github.com/stefanha/git-publish > > Thanks for your feedback. > > - Justin -- Cheers, Christophe de Dinechin (IRC c3d) ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-07-02 22:14 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-06-07 18:56 [Qemu-devel] Fix cacheline size retrieval on FreeBSD/PowerPC(64) Justin Hibbits 2019-06-26 16:14 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier 2019-06-26 16:16 ` Laurent Vivier 2019-06-26 16:37 ` Justin Hibbits 2019-06-26 16:47 ` Laurent Vivier 2019-06-26 18:04 ` Justin Hibbits 2019-06-27 0:02 ` Justin Hibbits 2019-06-27 0:08 ` Laurent Vivier 2019-06-27 0:15 ` Justin Hibbits 2019-07-01 8:54 ` Laurent Vivier 2019-07-01 13:02 ` Justin Hibbits 2019-07-01 13:17 ` Laurent Vivier 2019-07-02 22:11 ` Justin Hibbits 2019-07-01 14:08 ` Christophe de Dinechin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).