From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: jasowang@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature
Date: Wed, 17 Jul 2019 07:00:25 -0400 [thread overview]
Message-ID: <20190717065951-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190612021157.GA23850@___>
On Wed, Jun 12, 2019 at 10:11:57AM +0800, Tiwei Bie wrote:
> On Tue, Jun 11, 2019 at 10:10:14AM -0400, Michael S. Tsirkin wrote:
> > On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote:
> > > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of
> > > vhost-user backend. But it will be advertised to guest driver
> > > as long as it's enabled by users in QEMU, while it's not
> > > supported by vhost-user backend. This patch fixes this issue.
> >
> > Fixes by making guest refuse to send vlan tags?
>
> Fixes by not advertising this feature bit to guest driver
> when it's not supported, and guest won't expect the device
> to do vlan filtering then.
>
> > I agree it seems cleaner, but which guests does this actually help?
> >
> > > Fixes: 72018d1e1917 ("vhost-user: ignore qemu-only features")
> > > Cc: qemu-stable@nongnu.org
> > >
> > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> >
> > A change like that will break migration compatibility, will it not?
>
> Yeah, that's a problem...
>
> > Maybe we need to tie it to a machine version somehow...
> >
> >
> > > ---
> > > It's not clear in the spec that, whether vlan filtering is
> > > also best-effort:
> > > https://github.com/oasis-tcs/virtio-spec/blob/37057052e7/content.tex#L3372
> >
> > So what breaks if we declare it best effort for now?
> > And does it really help if we report that vlan filtering
> > is not supported to guests?
>
> If it's best effort, then it won't violate the spec to
> advertise this feature when it's not supported in backends.
>
OK so it's up to you. Want to propose a spec patch?
We already say mac filter is best effort ...
> >
> >
> >
> > > hw/net/vhost_net.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> > > index a6b719035c..1444fc9230 100644
> > > --- a/hw/net/vhost_net.c
> > > +++ b/hw/net/vhost_net.c
> > > @@ -75,6 +75,8 @@ static const int user_feature_bits[] = {
> > > VIRTIO_NET_F_MTU,
> > > VIRTIO_F_IOMMU_PLATFORM,
> > >
> > > + VIRTIO_NET_F_CTRL_VLAN,
> > > +
> > > /* This bit implies RARP isn't sent by QEMU out of band */
> > > VIRTIO_NET_F_GUEST_ANNOUNCE,
> > >
> > > --
> > > 2.17.1
next prev parent reply other threads:[~2019-07-17 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 6:51 [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature Tiwei Bie
2019-06-11 7:22 ` Jason Wang
2019-06-12 2:11 ` Tiwei Bie
2019-06-11 14:10 ` Michael S. Tsirkin
2019-06-12 2:11 ` Tiwei Bie
2019-07-17 11:00 ` Michael S. Tsirkin [this message]
2019-07-17 12:30 ` Jason Wang
2019-07-17 14:27 ` Michael S. Tsirkin
2019-07-18 7:04 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717065951-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).