From: Tiwei Bie <tiwei.bie@intel.com>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature
Date: Wed, 12 Jun 2019 10:11:33 +0800 [thread overview]
Message-ID: <20190612021132.GA23690@___> (raw)
In-Reply-To: <15f37c7d-5246-e093-e92c-1bd6ff77786a@redhat.com>
On Tue, Jun 11, 2019 at 03:22:47PM +0800, Jason Wang wrote:
>
> On 2019/6/11 下午2:51, Tiwei Bie wrote:
> > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of
> > vhost-user backend. But it will be advertised to guest driver
> > as long as it's enabled by users in QEMU, while it's not
> > supported by vhost-user backend. This patch fixes this issue.
> >
> > Fixes: 72018d1e1917 ("vhost-user: ignore qemu-only features")
>
>
> My understanding is if may want to revert this patch.
>
>
> > Cc: qemu-stable@nongnu.org
> >
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > ---
> > It's not clear in the spec that, whether vlan filtering is
> > also best-effort:
> > https://github.com/oasis-tcs/virtio-spec/blob/37057052e7/content.tex#L3372
>
>
> It should be a bug of the code, we should consider to implement ctrl command
> for vhost-user.
Yeah, we need to pass these information to backends if we
want to make it possible to support it in vhost-user.
>
> Thanks
>
>
> >
> > hw/net/vhost_net.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> > index a6b719035c..1444fc9230 100644
> > --- a/hw/net/vhost_net.c
> > +++ b/hw/net/vhost_net.c
> > @@ -75,6 +75,8 @@ static const int user_feature_bits[] = {
> > VIRTIO_NET_F_MTU,
> > VIRTIO_F_IOMMU_PLATFORM,
> > + VIRTIO_NET_F_CTRL_VLAN,
> > +
> > /* This bit implies RARP isn't sent by QEMU out of band */
> > VIRTIO_NET_F_GUEST_ANNOUNCE,
next prev parent reply other threads:[~2019-06-12 2:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 6:51 [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature Tiwei Bie
2019-06-11 7:22 ` Jason Wang
2019-06-12 2:11 ` Tiwei Bie [this message]
2019-06-11 14:10 ` Michael S. Tsirkin
2019-06-12 2:11 ` Tiwei Bie
2019-07-17 11:00 ` Michael S. Tsirkin
2019-07-17 12:30 ` Jason Wang
2019-07-17 14:27 ` Michael S. Tsirkin
2019-07-18 7:04 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612021132.GA23690@___ \
--to=tiwei.bie@intel.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).