From: Aarushi Mehta <mehta.aaru20@gmail.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Sergio Lopez <slp@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
saket.sinha89@gmail.com, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefan@redhat.com>,
Julia Suvorova <jusual@mail.ru>,
Aarushi Mehta <mehta.aaru20@gmail.com>
Subject: [Qemu-devel] [PATCH v6 12/14] qemu-img: adds option to use aio engine
Date: Fri, 19 Jul 2019 19:05:28 +0530 [thread overview]
Message-ID: <20190719133530.28688-13-mehta.aaru20@gmail.com> (raw)
In-Reply-To: <20190719133530.28688-1-mehta.aaru20@gmail.com>
Use -i AIOMODE instead of -n.
Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
---
qemu-img.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 79983772de..b7a962afff 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -4192,7 +4192,7 @@ static int img_bench(int argc, char **argv)
{"force-share", no_argument, 0, 'U'},
{0, 0, 0, 0}
};
- c = getopt_long(argc, argv, ":hc:d:f:no:qs:S:t:wU", long_options, NULL);
+ c = getopt_long(argc, argv, ":hc:d:f:io:qs:S:t:wU", long_options, NULL);
if (c == -1) {
break;
}
@@ -4232,8 +4232,13 @@ static int img_bench(int argc, char **argv)
case 'f':
fmt = optarg;
break;
- case 'n':
- flags |= BDRV_O_NATIVE_AIO;
+ case 'i':
+ ret = bdrv_parse_aio(optarg, &flags);
+ if (ret < 0) {
+ error_report("Invalid aio option: %s", optarg);
+ ret = -1;
+ goto out;
+ }
break;
case 'o':
{
--
2.21.0
next prev parent reply other threads:[~2019-07-19 13:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 13:35 [Qemu-devel] [PATCH v6 00/14] Add support for io_uring Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 01/14] configure: permit use of io_uring Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 02/14] qapi/block-core: add option for io_uring Aarushi Mehta
2019-07-19 15:20 ` Stefan Hajnoczi
2019-07-19 15:49 ` Eric Blake
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 03/14] block/block: add BDRV flag " Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 04/14] block/io_uring: implements interfaces " Aarushi Mehta
2019-07-19 15:34 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 05/14] stubs: add stubs for io_uring interface Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 06/14] util/async: add aio interfaces for io_uring Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 07/14] blockdev: accept io_uring as option Aarushi Mehta
2019-07-19 15:36 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 08/14] block/file-posix.c: extend to use io_uring Aarushi Mehta
2019-07-19 15:36 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 09/14] block: add trace events for io_uring Aarushi Mehta
2019-07-19 15:37 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 10/14] block/io_uring: adds userspace completion polling Aarushi Mehta
2019-07-19 15:39 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 11/14] qemu-io: adds option to use aio engine Aarushi Mehta
2019-07-19 15:41 ` Stefan Hajnoczi
2019-07-19 15:44 ` Daniel P. Berrangé
2019-07-24 16:42 ` Julia Suvorova
2019-07-19 13:35 ` Aarushi Mehta [this message]
2019-07-19 15:42 ` [Qemu-devel] [PATCH v6 12/14] qemu-img: " Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 13/14] qemu-nbd: adds option for aio engines Aarushi Mehta
2019-07-19 15:43 ` Stefan Hajnoczi
2019-07-19 15:55 ` Eric Blake
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 14/14] qemu-iotest: enable testing with qemu-io aio options Aarushi Mehta
2019-07-19 15:54 ` Stefan Hajnoczi
2019-07-24 16:49 ` Julia Suvorova
2019-07-19 22:33 ` [Qemu-devel] [PATCH v6 00/14] Add support for io_uring no-reply
2019-07-19 23:25 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719133530.28688-13-mehta.aaru20@gmail.com \
--to=mehta.aaru20@gmail.com \
--cc=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=jusual@mail.ru \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=saket.sinha89@gmail.com \
--cc=slp@redhat.com \
--cc=stefan@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).