From: Stefan Hajnoczi <stefanha@redhat.com>
To: Aarushi Mehta <mehta.aaru20@gmail.com>
Cc: Fam Zheng <fam@euphon.net>, Maxim Levitsky <mlevitsk@redhat.com>,
qemu-block@nongnu.org, Sergio Lopez <slp@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
saket.sinha89@gmail.com, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefan@redhat.com>,
Julia Suvorova <jusual@mail.ru>
Subject: Re: [Qemu-devel] [PATCH v6 04/14] block/io_uring: implements interfaces for io_uring
Date: Fri, 19 Jul 2019 16:34:40 +0100 [thread overview]
Message-ID: <20190719153440.GB24412@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190719133530.28688-5-mehta.aaru20@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2680 bytes --]
On Fri, Jul 19, 2019 at 07:05:20PM +0530, Aarushi Mehta wrote:
> diff --git a/block.c b/block.c
> index 29e931e217..4aa3500ad8 100644
> --- a/block.c
> +++ b/block.c
> @@ -844,6 +844,28 @@ static BlockdevDetectZeroesOptions bdrv_parse_detect_zeroes(QemuOpts *opts,
> return detect_zeroes;
> }
>
> +/**
> + * Set flags for aio engine
Other parse_*() functions are more specific about which type of flags
are produced:
s/flags/open flags/
> + *
> + * Return 0 on success, -1 if the engine specifies is invalid
s/specifies/specified/
> + */
> +int bdrv_parse_aio(const char *mode, int *flags)
> +{
> + if (!strcmp(mode, "threads")) {
> + /* do nothing, default */
> + } else if (!strcmp(mode, "native")) {
> + *flags |= BDRV_O_NATIVE_AIO;
> +#ifdef CONFIG_LINUX_IO_URING
> + } else if (!strcmp(mode, "io_uring")) {
> + *flags |= BDRV_O_IO_URING;
> +#endif
> + } else {
> + return -1;
> + }
> +
> + return 0;
> +}
Can you move this change to the patch that uses bdrv_parse_aio()? I
don't see any callers in this patch.
> + if (ret < 0) {
> + if (ret == -EINTR) {
> + luring_resubmit(s, luringcb);
> + continue;
> + }
> + } else if (!luringcb->qiov) {
> + goto end;
> + } else if (total_bytes == luringcb->qiov->size) {
> + ret = 0;
Indentation is off here.
> +static int luring_do_submit(int fd, LuringAIOCB *luringcb, LuringState *s,
> + uint64_t offset, int type)
> +{
> + struct io_uring_sqe *sqes = &luringcb->sqeq;
> +
> + switch (type) {
> + case QEMU_AIO_WRITE:
> + io_uring_prep_writev(sqes, fd, luringcb->qiov->iov,
> + luringcb->qiov->niov, offset);
> + break;
> + case QEMU_AIO_READ:
> + io_uring_prep_readv(sqes, fd, luringcb->qiov->iov,
> + luringcb->qiov->niov, offset);
> + break;
> + case QEMU_AIO_FLUSH:
> + io_uring_prep_fsync(sqes, fd, 0);
In QEMU QEMU_AIO_FLUSH is fdatasync so the IORING_FSYNC_DATASYNC flag
can be used for a slightly cheaper fsync operation.
> + break;
> + default:
> + fprintf(stderr, "%s: invalid AIO request type, aborting 0x%x.\n",
> + __func__, type);
> + abort();
> + }
> + io_uring_sqe_set_data(sqes, luringcb);
> +
> + QSIMPLEQ_INSERT_TAIL(&s->io_q.sq_overflow, luringcb, next);
Now that we use sq_overflow unconditionally it can be renamed to
submit_queue, making the code easier to understand.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-19 15:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 13:35 [Qemu-devel] [PATCH v6 00/14] Add support for io_uring Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 01/14] configure: permit use of io_uring Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 02/14] qapi/block-core: add option for io_uring Aarushi Mehta
2019-07-19 15:20 ` Stefan Hajnoczi
2019-07-19 15:49 ` Eric Blake
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 03/14] block/block: add BDRV flag " Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 04/14] block/io_uring: implements interfaces " Aarushi Mehta
2019-07-19 15:34 ` Stefan Hajnoczi [this message]
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 05/14] stubs: add stubs for io_uring interface Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 06/14] util/async: add aio interfaces for io_uring Aarushi Mehta
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 07/14] blockdev: accept io_uring as option Aarushi Mehta
2019-07-19 15:36 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 08/14] block/file-posix.c: extend to use io_uring Aarushi Mehta
2019-07-19 15:36 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 09/14] block: add trace events for io_uring Aarushi Mehta
2019-07-19 15:37 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 10/14] block/io_uring: adds userspace completion polling Aarushi Mehta
2019-07-19 15:39 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 11/14] qemu-io: adds option to use aio engine Aarushi Mehta
2019-07-19 15:41 ` Stefan Hajnoczi
2019-07-19 15:44 ` Daniel P. Berrangé
2019-07-24 16:42 ` Julia Suvorova
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 12/14] qemu-img: " Aarushi Mehta
2019-07-19 15:42 ` Stefan Hajnoczi
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 13/14] qemu-nbd: adds option for aio engines Aarushi Mehta
2019-07-19 15:43 ` Stefan Hajnoczi
2019-07-19 15:55 ` Eric Blake
2019-07-19 13:35 ` [Qemu-devel] [PATCH v6 14/14] qemu-iotest: enable testing with qemu-io aio options Aarushi Mehta
2019-07-19 15:54 ` Stefan Hajnoczi
2019-07-24 16:49 ` Julia Suvorova
2019-07-19 22:33 ` [Qemu-devel] [PATCH v6 00/14] Add support for io_uring no-reply
2019-07-19 23:25 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719153440.GB24412@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=jusual@mail.ru \
--cc=kwolf@redhat.com \
--cc=mehta.aaru20@gmail.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=saket.sinha89@gmail.com \
--cc=slp@redhat.com \
--cc=stefan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).