From: Igor Mammedov <imammedo@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, david@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] memory-device: break the loop if tmp exceed the hinted range
Date: Tue, 30 Jul 2019 11:30:25 +0200 [thread overview]
Message-ID: <20190730113025.7e82bdee@Igors-MacBook-Pro> (raw)
In-Reply-To: <20190730003740.20694-3-richardw.yang@linux.intel.com>
On Tue, 30 Jul 2019 08:37:40 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> The memory-device list built by memory_device_build_list is ordered by
> its address, this means if the tmp range exceed the hinted range, all
> the following range will not overlap with it.
>
> And this won't change default pc-dimm mapping and address assignment stay
> the same as before this change.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/mem/memory-device.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> index df3261b32a..df4e338b83 100644
> --- a/hw/mem/memory-device.c
> +++ b/hw/mem/memory-device.c
> @@ -180,6 +180,8 @@ static uint64_t memory_device_get_free_addr(MachineState *ms,
> range_make_empty(&new);
> break;
> }
> + } else if (range_lob(&tmp) > range_upb(&new)) {
> + break;
> }
> }
>
next prev parent reply other threads:[~2019-07-30 9:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 0:37 [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr Wei Yang
2019-07-30 0:37 ` [Qemu-devel] [PATCH v2 1/2] memory-device: not necessary to use goto for the last check Wei Yang
2019-08-08 1:42 ` Zeng, Star
2019-08-08 2:13 ` Wei Yang
2019-08-08 2:30 ` Zeng, Star
2019-08-08 2:38 ` Wei Yang
2019-08-08 7:06 ` David Hildenbrand
2019-08-19 2:38 ` Wei Yang
2019-08-19 5:32 ` Zeng, Star
2019-08-19 6:36 ` Wei Yang
2019-07-30 0:37 ` [Qemu-devel] [PATCH v2 2/2] memory-device: break the loop if tmp exceed the hinted range Wei Yang
2019-07-30 7:38 ` David Hildenbrand
2019-07-30 9:30 ` Igor Mammedov [this message]
2019-09-13 23:47 ` [Qemu-devel] [PATCH v2 0/2] refine memory_device_get_free_addr Wei Yang
2019-09-14 19:40 ` Michael S. Tsirkin
2019-10-12 9:02 ` Wei Yang
2019-10-14 15:05 ` Eduardo Habkost
2019-10-14 22:00 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730113025.7e82bdee@Igors-MacBook-Pro \
--to=imammedo@redhat.com \
--cc=david@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).