qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	qemu-block@nongnu.org, Amit Shah <amit@kernel.org>,
	John Snow <jsnow@redhat.com>, Jason Wang <jasowang@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Markus Armbruster <armbru@redhat.com>, Greg Kurz <groug@kaod.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 4/6] tests/libqtest: Clean up qtest_cb_for_every_machine() wrt global_qtest
Date: Tue, 13 Aug 2019 11:30:45 +0200	[thread overview]
Message-ID: <20190813093047.27948-5-thuth@redhat.com> (raw)
In-Reply-To: <20190813093047.27948-1-thuth@redhat.com>

The generic libqtest library functions should not use functions that
require the global_qtest variable.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/libqtest.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/libqtest.c b/tests/libqtest.c
index 3e9245d4c9..d1aead30ed 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -1189,9 +1189,10 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine),
     QObject *qobj;
     QString *qstr;
     const char *mname;
+    QTestState *qts;
 
-    qtest_start("-machine none");
-    response = qmp("{ 'execute': 'query-machines' }");
+    qts = qtest_init("-machine none");
+    response = qtest_qmp(qts, "{ 'execute': 'query-machines' }");
     g_assert(response);
     list = qdict_get_qlist(response, "return");
     g_assert(list);
@@ -1209,7 +1210,7 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine),
         }
     }
 
-    qtest_end();
+    qtest_quit(qts);
     qobject_unref(response);
 }
 
-- 
2.18.1



  parent reply	other threads:[~2019-08-13  9:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  9:30 [Qemu-devel] [PATCH 0/6] First batch of global_qtest-removement patches for QEMU 4.2 Thomas Huth
2019-08-13  9:30 ` [Qemu-devel] [PATCH 1/6] tests/libqos: Make generic virtio code independent from global_qtest Thomas Huth
2019-08-13 15:18   ` Eric Blake
2019-08-14 19:59     ` [Qemu-devel] [PATCH v2] " Thomas Huth
2019-08-13  9:30 ` [Qemu-devel] [PATCH 2/6] tests/libqos: Make virtio-pci " Thomas Huth
2019-08-13 15:19   ` Eric Blake
2019-08-13  9:30 ` [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp() Thomas Huth
2019-08-13 15:20   ` Eric Blake
2019-08-13 17:38     ` Thomas Huth
2019-08-13  9:30 ` Thomas Huth [this message]
2019-08-13 15:21   ` [Qemu-devel] [PATCH 4/6] tests/libqtest: Clean up qtest_cb_for_every_machine() wrt global_qtest Eric Blake
2019-08-13  9:30 ` [Qemu-devel] [PATCH 5/6] tests/libqtest: Make qtest_qmp_device_add/del independent from global_qtest Thomas Huth
2019-08-13 15:22   ` Eric Blake
2019-08-13  9:30 ` [Qemu-devel] [PATCH 6/6] tests/libqtest: Make qmp_assert_success() " Thomas Huth
2019-08-13 15:24   ` Eric Blake
2019-08-13 15:00 ` [Qemu-devel] [PATCH 0/6] First batch of global_qtest-removement patches for QEMU 4.2 Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190813093047.27948-5-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=amit@kernel.org \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=fam@euphon.net \
    --cc=groug@kaod.org \
    --cc=jasowang@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).