From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Laurent Vivier <lvivier@redhat.com>,
qemu-block@nongnu.org, Amit Shah <amit@kernel.org>,
Jason Wang <jasowang@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>, Greg Kurz <groug@kaod.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp()
Date: Tue, 13 Aug 2019 10:20:14 -0500 [thread overview]
Message-ID: <5b373fbe-6dbc-7a2a-a981-091fa8648ac2@redhat.com> (raw)
In-Reply-To: <20190813093047.27948-4-thuth@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 758 bytes --]
On 8/13/19 4:30 AM, Thomas Huth wrote:
> No test is using hmp() anymore, and since this function uses the disliked
> global_qtest variable, we should also make sure that nobody adds new code
> with this function again. qtest_hmp() should be used instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/libqtest.c | 11 -----------
> tests/libqtest.h | 10 ----------
> 2 files changed, 21 deletions(-)
Yay.
We could, at a later time, introduce a patch to do s/qtest_hmp/hmp/ if
it was deemed worthwhile, but I'm not sure it's worth the churn.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-13 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 9:30 [Qemu-devel] [PATCH 0/6] First batch of global_qtest-removement patches for QEMU 4.2 Thomas Huth
2019-08-13 9:30 ` [Qemu-devel] [PATCH 1/6] tests/libqos: Make generic virtio code independent from global_qtest Thomas Huth
2019-08-13 15:18 ` Eric Blake
2019-08-14 19:59 ` [Qemu-devel] [PATCH v2] " Thomas Huth
2019-08-13 9:30 ` [Qemu-devel] [PATCH 2/6] tests/libqos: Make virtio-pci " Thomas Huth
2019-08-13 15:19 ` Eric Blake
2019-08-13 9:30 ` [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp() Thomas Huth
2019-08-13 15:20 ` Eric Blake [this message]
2019-08-13 17:38 ` Thomas Huth
2019-08-13 9:30 ` [Qemu-devel] [PATCH 4/6] tests/libqtest: Clean up qtest_cb_for_every_machine() wrt global_qtest Thomas Huth
2019-08-13 15:21 ` Eric Blake
2019-08-13 9:30 ` [Qemu-devel] [PATCH 5/6] tests/libqtest: Make qtest_qmp_device_add/del independent from global_qtest Thomas Huth
2019-08-13 15:22 ` Eric Blake
2019-08-13 9:30 ` [Qemu-devel] [PATCH 6/6] tests/libqtest: Make qmp_assert_success() " Thomas Huth
2019-08-13 15:24 ` Eric Blake
2019-08-13 15:00 ` [Qemu-devel] [PATCH 0/6] First batch of global_qtest-removement patches for QEMU 4.2 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b373fbe-6dbc-7a2a-a981-091fa8648ac2@redhat.com \
--to=eblake@redhat.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=groug@kaod.org \
--cc=jasowang@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).