* [Qemu-devel] [PATCH v2] usb: reword -usb command-line option and mention xHCI
@ 2019-08-15 14:14 Stefan Hajnoczi
2019-08-15 14:16 ` Thomas Huth
2019-08-21 8:43 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-08-15 14:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth, Dr. David Alan Gilbert, Stefan Hajnoczi, kraxel
The -usb section of the man page is not very clear on what exactly -usb
does and fails to mention xHCI as a modern alternative (-device
nec-usb-xhci).
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
v2:
* Use @option{-device ...} [Thomas]
* Suggest qemu-xhci instead of nec-usb-xhci [Thomas and David]
---
qemu-options.hx | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 9621e934c0..1fb362f06f 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1436,12 +1436,15 @@ STEXI
ETEXI
DEF("usb", 0, QEMU_OPTION_usb,
- "-usb enable the USB driver (if it is not used by default yet)\n",
+ "-usb enable on-board USB host controller (if not enabled by default)\n",
QEMU_ARCH_ALL)
STEXI
@item -usb
@findex -usb
-Enable the USB driver (if it is not used by default yet).
+Enable USB emulation on machine types with an on-board USB host controller (if
+not enabled by default). Note that on-board USB host controllers may not
+support USB 3.0. In this case @option{-device qemu-xhci} can be used instead
+on machines with PCI.
ETEXI
DEF("usbdevice", HAS_ARG, QEMU_OPTION_usbdevice,
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] usb: reword -usb command-line option and mention xHCI
2019-08-15 14:14 [Qemu-devel] [PATCH v2] usb: reword -usb command-line option and mention xHCI Stefan Hajnoczi
@ 2019-08-15 14:16 ` Thomas Huth
2019-08-21 8:43 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2019-08-15 14:16 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Dr. David Alan Gilbert, kraxel
On 8/15/19 4:14 PM, Stefan Hajnoczi wrote:
> The -usb section of the man page is not very clear on what exactly -usb
> does and fails to mention xHCI as a modern alternative (-device
> nec-usb-xhci).
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> v2:
> * Use @option{-device ...} [Thomas]
> * Suggest qemu-xhci instead of nec-usb-xhci [Thomas and David]
> ---
> qemu-options.hx | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9621e934c0..1fb362f06f 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1436,12 +1436,15 @@ STEXI
> ETEXI
>
> DEF("usb", 0, QEMU_OPTION_usb,
> - "-usb enable the USB driver (if it is not used by default yet)\n",
> + "-usb enable on-board USB host controller (if not enabled by default)\n",
> QEMU_ARCH_ALL)
> STEXI
> @item -usb
> @findex -usb
> -Enable the USB driver (if it is not used by default yet).
> +Enable USB emulation on machine types with an on-board USB host controller (if
> +not enabled by default). Note that on-board USB host controllers may not
> +support USB 3.0. In this case @option{-device qemu-xhci} can be used instead
> +on machines with PCI.
> ETEXI
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] usb: reword -usb command-line option and mention xHCI
2019-08-15 14:14 [Qemu-devel] [PATCH v2] usb: reword -usb command-line option and mention xHCI Stefan Hajnoczi
2019-08-15 14:16 ` Thomas Huth
@ 2019-08-21 8:43 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2019-08-21 8:43 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Thomas Huth, qemu-devel, Dr. David Alan Gilbert
On Thu, Aug 15, 2019 at 03:14:28PM +0100, Stefan Hajnoczi wrote:
> The -usb section of the man page is not very clear on what exactly -usb
> does and fails to mention xHCI as a modern alternative (-device
> nec-usb-xhci).
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Added to usb patch queue.
thanks,
Gerd
> ---
> v2:
> * Use @option{-device ...} [Thomas]
> * Suggest qemu-xhci instead of nec-usb-xhci [Thomas and David]
> ---
> qemu-options.hx | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9621e934c0..1fb362f06f 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1436,12 +1436,15 @@ STEXI
> ETEXI
>
> DEF("usb", 0, QEMU_OPTION_usb,
> - "-usb enable the USB driver (if it is not used by default yet)\n",
> + "-usb enable on-board USB host controller (if not enabled by default)\n",
> QEMU_ARCH_ALL)
> STEXI
> @item -usb
> @findex -usb
> -Enable the USB driver (if it is not used by default yet).
> +Enable USB emulation on machine types with an on-board USB host controller (if
> +not enabled by default). Note that on-board USB host controllers may not
> +support USB 3.0. In this case @option{-device qemu-xhci} can be used instead
> +on machines with PCI.
> ETEXI
>
> DEF("usbdevice", HAS_ARG, QEMU_OPTION_usbdevice,
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-21 9:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 14:14 [Qemu-devel] [PATCH v2] usb: reword -usb command-line option and mention xHCI Stefan Hajnoczi
2019-08-15 14:16 ` Thomas Huth
2019-08-21 8:43 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).