From: David Gibson <david@gibson.dropbear.id.au>
To: "Paul A. Clarke" <pc@us.ibm.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc: Fix xsmaddmdp and friends
Date: Thu, 22 Aug 2019 08:56:01 +1000 [thread overview]
Message-ID: <20190821225601.GG20890@umbus> (raw)
In-Reply-To: <1566401321-22419-1-git-send-email-pc@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2076 bytes --]
On Wed, Aug 21, 2019 at 10:28:41AM -0500, Paul A. Clarke wrote:
> From: "Paul A. Clarke" <pc@us.ibm.com>
>
> A class of instructions of the form:
> op Target,A,B
> which operate like:
> Target = Target * A + B
> have a bit set which distinguishes them from instructions that operate as:
> Target = Target * B + A
>
> This bit is not being checked properly (using PPC_BIT macro), so all
> instructions in this class are operating incorrectly as the second form
> above. The bit was being checked as if it were part of a 64-bit
> instruction opcode, rather than a proper 32-bit opcode. Fix by using the
> macro (PPC_BIT32) which treats the opcode as a 32-bit quantity.
>
> Signed-off-by: Paul A. Clarke <pc@us.ibm.com>
Applied to ppc-for-4.2, thanks.
> ---
> target/ppc/translate/vsx-impl.inc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx-impl.inc.c
> index 3922686..8287e27 100644
> --- a/target/ppc/translate/vsx-impl.inc.c
> +++ b/target/ppc/translate/vsx-impl.inc.c
> @@ -1308,7 +1308,7 @@ static void gen_##name(DisasContext *ctx) \
> } \
> xt = gen_vsr_ptr(xT(ctx->opcode)); \
> xa = gen_vsr_ptr(xA(ctx->opcode)); \
> - if (ctx->opcode & PPC_BIT(25)) { \
> + if (ctx->opcode & PPC_BIT32(25)) { \
> /* \
> * AxT + B \
> */ \
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-22 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:28 [Qemu-devel] [PATCH] ppc: Fix xsmaddmdp and friends Paul A. Clarke
2019-08-21 22:56 ` David Gibson [this message]
2019-08-28 17:32 ` [Qemu-devel] [Qemu-ppc] " Laurent Vivier
2019-08-28 23:28 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821225601.GG20890@umbus \
--to=david@gibson.dropbear.id.au \
--cc=pc@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).