From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
"Paul A. Clarke" <pc@us.ibm.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Fix xsmaddmdp and friends
Date: Wed, 28 Aug 2019 19:32:38 +0200 [thread overview]
Message-ID: <896ff2fb-a1b5-c22b-e195-a5054fb8d354@redhat.com> (raw)
In-Reply-To: <20190821225601.GG20890@umbus>
On 22/08/2019 00:56, David Gibson wrote:
> On Wed, Aug 21, 2019 at 10:28:41AM -0500, Paul A. Clarke wrote:
>> From: "Paul A. Clarke" <pc@us.ibm.com>
>>
>> A class of instructions of the form:
>> op Target,A,B
>> which operate like:
>> Target = Target * A + B
>> have a bit set which distinguishes them from instructions that operate as:
>> Target = Target * B + A
>>
>> This bit is not being checked properly (using PPC_BIT macro), so all
>> instructions in this class are operating incorrectly as the second form
>> above. The bit was being checked as if it were part of a 64-bit
>> instruction opcode, rather than a proper 32-bit opcode. Fix by using the
>> macro (PPC_BIT32) which treats the opcode as a 32-bit quantity.
>>
>> Signed-off-by: Paul A. Clarke <pc@us.ibm.com>
>
> Applied to ppc-for-4.2, thanks.
David,
could you add:
Fixes: c9f4e4d8b632 ("target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro")
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Tested-by: Laurent Vivier <lvivier@redhat.com>
Thanks,
Laurent
next prev parent reply other threads:[~2019-08-28 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:28 [Qemu-devel] [PATCH] ppc: Fix xsmaddmdp and friends Paul A. Clarke
2019-08-21 22:56 ` David Gibson
2019-08-28 17:32 ` Laurent Vivier [this message]
2019-08-28 23:28 ` [Qemu-devel] [Qemu-ppc] " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=896ff2fb-a1b5-c22b-e195-a5054fb8d354@redhat.com \
--to=lvivier@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=pc@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).