From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] migration/qemu-file: remove check on writev_buffer in qemu_put_compression_data
Date: Fri, 23 Aug 2019 11:30:06 +0100 [thread overview]
Message-ID: <20190823103006.GE2784@work-vm> (raw)
In-Reply-To: <20190731144225.3784-2-richardw.yang@linux.intel.com>
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> The check of writev_buffer is in qemu_fflush, which means it is not
> harmful if it is NULL.
>
> And removing it will make the code consistent since all other
> add_to_iovec() is called without the check.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
So I think the real reason here is commit 11808bb which removed
support for non-iovec writers.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/qemu-file.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index 0431585502..35c22605dd 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -717,9 +717,7 @@ ssize_t qemu_put_compression_data(QEMUFile *f, z_stream *stream,
> }
>
> qemu_put_be32(f, blen);
> - if (f->ops->writev_buffer) {
> - add_to_iovec(f, f->buf + f->buf_index, blen, false);
> - }
> + add_to_iovec(f, f->buf + f->buf_index, blen, false);
> f->buf_index += blen;
> if (f->buf_index == IO_BUF_SIZE) {
> qemu_fflush(f);
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-08-23 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 14:42 [Qemu-devel] [PATCH 0/2] migration/qemu-file: cleanup and refine qemu-file Wei Yang
2019-07-31 14:42 ` [Qemu-devel] [PATCH 1/2] migration/qemu-file: remove check on writev_buffer in qemu_put_compression_data Wei Yang
2019-08-23 10:30 ` Dr. David Alan Gilbert [this message]
2019-07-31 14:42 ` [Qemu-devel] [PATCH 2/2] migration/qemu-file: fix potential buf waste for extra buf_index adjustment Wei Yang
2019-08-23 11:06 ` Dr. David Alan Gilbert
2019-08-23 11:38 ` Daniel P. Berrangé
2019-08-23 13:05 ` Dr. David Alan Gilbert
2019-08-24 16:22 ` Wei Yang
2019-09-03 13:22 ` Dr. David Alan Gilbert
2019-08-24 16:15 ` Wei Yang
2019-09-03 18:43 ` Dr. David Alan Gilbert
2019-09-11 12:26 ` Wei Yang
2019-08-19 2:36 ` [Qemu-devel] [PATCH 0/2] migration/qemu-file: cleanup and refine qemu-file Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823103006.GE2784@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).