From: Wei Yang <richard.weiyang@gmail.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, berrange@redhat.com,
Wei Yang <richardw.yang@linux.intel.com>,
Wei Yang <richard.weiyang@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] migration/qemu-file: fix potential buf waste for extra buf_index adjustment
Date: Wed, 11 Sep 2019 12:26:23 +0000 [thread overview]
Message-ID: <20190911122623.la6iixhype6ubchy@master> (raw)
In-Reply-To: <20190903184324.GA2744@work-vm>
On Tue, Sep 03, 2019 at 07:43:24PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (richard.weiyang@gmail.com) wrote:
>> On Fri, Aug 23, 2019 at 12:06:09PM +0100, Dr. David Alan Gilbert wrote:
>> >(Copying Dan in)
>> >
>> >* Wei Yang (richardw.yang@linux.intel.com) wrote:
>> >> In add_to_iovec(), qemu_fflush() will be called if iovec is full. If
>> >> this happens, buf_index is reset. Currently, this is not checked and
>> >> buf_index would always been adjust with buf size.
>> >>
>> >> This is not harmful, but will waste some space in file buffer.
>> >
>> >That's a nice find.
>> >
>> >> This patch make add_to_iovec() return 1 when it has flushed the file.
>> >> Then the caller could check the return value to see whether it is
>> >> necessary to adjust the buf_index any more.
>> >>
>> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> >
>> >Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> >
>> >(I wonder if there's a way to wrap that little add_to_iovec, check, add
>> >to index, flush in a little wrapper).
>> >
>> >Dave
>> >
>> >> ---
>> >> migration/qemu-file.c | 42 ++++++++++++++++++++++++++++--------------
>> >> 1 file changed, 28 insertions(+), 14 deletions(-)
>> >>
>> >> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
>> >> index 35c22605dd..05d9f42ddb 100644
>> >> --- a/migration/qemu-file.c
>> >> +++ b/migration/qemu-file.c
>> >> @@ -343,8 +343,16 @@ int qemu_fclose(QEMUFile *f)
>> >> return ret;
>> >> }
>> >>
>> >> -static void add_to_iovec(QEMUFile *f, const uint8_t *buf, size_t size,
>> >> - bool may_free)
>> >> +/*
>> >> + * Add buf to iovec. Do flush if iovec is full.
>> >> + *
>> >> + * Return values:
>> >> + * 1 iovec is full and flushed
>> >> + * 0 iovec is not flushed
>> >> + *
>> >> + */
>> >> +static int add_to_iovec(QEMUFile *f, const uint8_t *buf, size_t size,
>> >> + bool may_free)
>> >> {
>> >> /* check for adjacent buffer and coalesce them */
>> >> if (f->iovcnt > 0 && buf == f->iov[f->iovcnt - 1].iov_base +
>> >> @@ -362,7 +370,10 @@ static void add_to_iovec(QEMUFile *f, const uint8_t *buf, size_t size,
>> >>
>> >> if (f->iovcnt >= MAX_IOV_SIZE) {
>> >> qemu_fflush(f);
>> >> + return 1;
>> >> }
>> >> +
>> >> + return 0;
>> >> }
>> >>
>> >> void qemu_put_buffer_async(QEMUFile *f, const uint8_t *buf, size_t size,
>> >> @@ -391,10 +402,11 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, size_t size)
>> >> }
>> >> memcpy(f->buf + f->buf_index, buf, l);
>> >> f->bytes_xfer += l;
>> >> - add_to_iovec(f, f->buf + f->buf_index, l, false);
>> >> - f->buf_index += l;
>> >> - if (f->buf_index == IO_BUF_SIZE) {
>> >> - qemu_fflush(f);
>> >> + if (!add_to_iovec(f, f->buf + f->buf_index, l, false)) {
>> >> + f->buf_index += l;
>> >> + if (f->buf_index == IO_BUF_SIZE) {
>> >> + qemu_fflush(f);
>> >> + }
>>
>> You mean put these four lines into a wrapper?
>>
>> Name it as add_buf_to_iovec?
>
>Yes.
Sure, Let me prepare v2 with this.
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-09-11 12:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 14:42 [Qemu-devel] [PATCH 0/2] migration/qemu-file: cleanup and refine qemu-file Wei Yang
2019-07-31 14:42 ` [Qemu-devel] [PATCH 1/2] migration/qemu-file: remove check on writev_buffer in qemu_put_compression_data Wei Yang
2019-08-23 10:30 ` Dr. David Alan Gilbert
2019-07-31 14:42 ` [Qemu-devel] [PATCH 2/2] migration/qemu-file: fix potential buf waste for extra buf_index adjustment Wei Yang
2019-08-23 11:06 ` Dr. David Alan Gilbert
2019-08-23 11:38 ` Daniel P. Berrangé
2019-08-23 13:05 ` Dr. David Alan Gilbert
2019-08-24 16:22 ` Wei Yang
2019-09-03 13:22 ` Dr. David Alan Gilbert
2019-08-24 16:15 ` Wei Yang
2019-09-03 18:43 ` Dr. David Alan Gilbert
2019-09-11 12:26 ` Wei Yang [this message]
2019-08-19 2:36 ` [Qemu-devel] [PATCH 0/2] migration/qemu-file: cleanup and refine qemu-file Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911122623.la6iixhype6ubchy@master \
--to=richard.weiyang@gmail.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).