From: Dmitry Fomichev <dmitry.fomichev@wdc.com> To: Paolo Bonzini <pbonzini@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, "Michael S . Tsirkin" <mst@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com> Cc: Dmitry Fomichev <dmitry.fomichev@wdc.com>, Alistair Francis <alistair.francis@wdc.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org Subject: [Qemu-devel] [PATCH v5 4/4] raw: Don't open ZBDs if backend can't handle them Date: Fri, 23 Aug 2019 15:49:27 -0400 Message-ID: <20190823194927.23278-5-dmitry.fomichev@wdc.com> (raw) In-Reply-To: <20190823194927.23278-1-dmitry.fomichev@wdc.com> Abort opening a zoned device as a raw file in case the chosen block backend driver lacks proper support for this type of storage. Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com> --- block/file-posix.c | 14 ++++++++++++++ hw/block/fdc.c | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index d9f2fc5e46..090e7c4d2f 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2884,6 +2884,20 @@ static int raw_check_perm(BlockDriverState *bs, uint64_t perm, uint64_t shared, goto fail; } } + + /* + * If we are opening a zoned block device, check if the backend + * driver can properly handle such devices, abort if not. + */ + if (bdrv_is_zoned(bs) && + (shared & BLK_PERM_SUPPORT_ZONED) && + !(perm & BLK_PERM_SUPPORT_ZONED)) { + error_setg(errp, + "block backend driver doesn't support HM zoned devices"); + ret = -ENOTSUP; + goto fail; + } + return 0; fail: diff --git a/hw/block/fdc.c b/hw/block/fdc.c index c5f41b3eb6..673a8b39bc 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -570,7 +570,7 @@ static void floppy_drive_realize(DeviceState *qdev, Error **errp) dev->conf.werror = BLOCKDEV_ON_ERROR_AUTO; if (!blkconf_apply_backend_options(&dev->conf, read_only, false, false, - errp)) { + errp)) { return; } -- 2.21.0
next prev parent reply index Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-23 19:49 [Qemu-devel] [PATCH v5 0/4] virtio/block: handle zoned backing devices Dmitry Fomichev 2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 1/4] block: Add zoned device model property Dmitry Fomichev 2019-08-28 9:21 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi 2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 2/4] raw: Recognize zoned backing devices Dmitry Fomichev 2019-08-28 9:32 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi 2019-08-23 19:49 ` [Qemu-devel] [PATCH v5 3/4] block/ide/scsi: Set BLK_PERM_SUPPORT_ZONED Dmitry Fomichev 2019-08-28 9:34 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi 2019-08-23 19:49 ` Dmitry Fomichev [this message] 2019-08-28 9:38 ` [Qemu-devel] [PATCH v5 4/4] raw: Don't open ZBDs if backend can't handle them Stefan Hajnoczi 2019-08-23 20:08 ` [Qemu-devel] [PATCH v5 0/4] virtio/block: handle zoned backing devices no-reply 2019-08-28 9:41 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi 2019-09-04 21:11 ` Dmitry Fomichev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190823194927.23278-5-dmitry.fomichev@wdc.com \ --to=dmitry.fomichev@wdc.com \ --cc=alistair.francis@wdc.com \ --cc=jsnow@redhat.com \ --cc=kwolf@redhat.com \ --cc=mreitz@redhat.com \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=stefanha@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
QEMU-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git git clone --mirror https://lore.kernel.org/qemu-devel/2 qemu-devel/git/2.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \ qemu-devel@nongnu.org public-inbox-index qemu-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git