qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28
@ 2019-08-29  1:03 Cleber Rosa
  2019-08-29  1:03 ` [Qemu-devel] [PULL 1/5] tests.acceptance.avocado_qemu: Add support for powerpc Cleber Rosa
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Cleber Rosa @ 2019-08-29  1:03 UTC (permalink / raw)
  To: Peter Maydell, qemu-devel, Eduardo Habkost
  Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée, Cleber Rosa

The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4:

  Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100)

are available in the Git repository at:

  git://github.com/clebergnu/qemu.git tags/python-next-pull-request

for you to fetch changes up to d19818e50e5286f878a76a286b76d29e57140dd4:

  VNC Acceptance test: simplify test names (2019-08-28 20:42:16 -0400)

----------------------------------------------------------------

Cleber Rosa (4):
  tests/requirements.txt: pin paramiko version requirement
  Acceptance tests: drop left over usage of ":avocado: enable"
  Boot Linux Console Test: add a test for ppc64 + pseries
  VNC Acceptance test: simplify test names

Satheesh Rajendran (1):
  tests.acceptance.avocado_qemu: Add support for powerpc

 .travis.yml                               |  2 +-
 tests/acceptance/avocado_qemu/__init__.py |  3 +++
 tests/acceptance/boot_linux_console.py    | 19 +++++++++++++++++++
 tests/acceptance/migration.py             |  3 ---
 tests/acceptance/vnc.py                   |  4 ++--
 tests/requirements.txt                    |  2 +-
 6 files changed, 26 insertions(+), 7 deletions(-)

-- 
2.21.0



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Qemu-devel] [PULL 1/5] tests.acceptance.avocado_qemu: Add support for powerpc
  2019-08-29  1:03 [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28 Cleber Rosa
@ 2019-08-29  1:03 ` Cleber Rosa
  2019-08-29  1:03 ` [Qemu-devel] [PULL 2/5] tests/requirements.txt: pin paramiko version requirement Cleber Rosa
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Cleber Rosa @ 2019-08-29  1:03 UTC (permalink / raw)
  To: Peter Maydell, qemu-devel, Eduardo Habkost
  Cc: Fam Zheng, Alex Bennée, Satheesh Rajendran,
	Cédric Le Goater, Cleber Rosa, Philippe Mathieu-Daudé,
	David Gibson

From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>

Current acceptance test will not run properly in powerpc
environment due qemu target is different from arch, this
usually matches, except with bi-endian architectures like ppc64.
uname would return `ppc64` or `ppc64le` based `big` or `little`
endian but qemu `target` is always `ppc64`. Let's handle it.

Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Message-Id: <20190819082820.14817-1-sathnaga@linux.vnet.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/acceptance/avocado_qemu/__init__.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index aee5d820ed..bd41e0443c 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -39,6 +39,9 @@ def pick_default_qemu_bin(arch=None):
     """
     if arch is None:
         arch = os.uname()[4]
+    # qemu binary path does not match arch for powerpc, handle it
+    if 'ppc64le' in arch:
+        arch = 'ppc64'
     qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
                                           "qemu-system-%s" % arch)
     if is_readable_executable_file(qemu_bin_relative_path):
-- 
2.21.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Qemu-devel] [PULL 2/5] tests/requirements.txt: pin paramiko version requirement
  2019-08-29  1:03 [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28 Cleber Rosa
  2019-08-29  1:03 ` [Qemu-devel] [PULL 1/5] tests.acceptance.avocado_qemu: Add support for powerpc Cleber Rosa
@ 2019-08-29  1:03 ` Cleber Rosa
  2019-08-29  1:03 ` [Qemu-devel] [PULL 3/5] Acceptance tests: drop left over usage of ":avocado: enable" Cleber Rosa
  2019-09-03 16:19 ` [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28 Peter Maydell
  3 siblings, 0 replies; 5+ messages in thread
From: Cleber Rosa @ 2019-08-29  1:03 UTC (permalink / raw)
  To: Peter Maydell, qemu-devel, Eduardo Habkost
  Cc: Fam Zheng, Philippe Mathieu-Daudé,
	Alex Bennée, Wainer dos Santos Moschetta, Cleber Rosa

It's a good practice (I'd really say a must) to pin as much as
possible of the software versions used during test, so let's apply
that to paramiko.

According to https://pypi.org/project/paramiko/, 2.4.2 is the latest
released version.  It's also easily obtainable on systems such as
Fedora 30.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190607152223.9467-3-crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/requirements.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/requirements.txt b/tests/requirements.txt
index 3ae0e29ad7..bd1f7590ed 100644
--- a/tests/requirements.txt
+++ b/tests/requirements.txt
@@ -2,4 +2,4 @@
 # in the tests/venv Python virtual environment. For more info,
 # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
 avocado-framework==68.0
-paramiko
+paramiko==2.4.2
-- 
2.21.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Qemu-devel] [PULL 3/5] Acceptance tests: drop left over usage of ":avocado: enable"
  2019-08-29  1:03 [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28 Cleber Rosa
  2019-08-29  1:03 ` [Qemu-devel] [PULL 1/5] tests.acceptance.avocado_qemu: Add support for powerpc Cleber Rosa
  2019-08-29  1:03 ` [Qemu-devel] [PULL 2/5] tests/requirements.txt: pin paramiko version requirement Cleber Rosa
@ 2019-08-29  1:03 ` Cleber Rosa
  2019-09-03 16:19 ` [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28 Peter Maydell
  3 siblings, 0 replies; 5+ messages in thread
From: Cleber Rosa @ 2019-08-29  1:03 UTC (permalink / raw)
  To: Peter Maydell, qemu-devel, Eduardo Habkost
  Cc: Fam Zheng, Philippe Mathieu-Daudé,
	Alex Bennée, Wainer dos Santos Moschetta, Cleber Rosa

Commit 9531d26c10 removed all of ":avocado: enable" tags, but then
a new entry was added with the introduction of migration.py.

Let's remove it for consistency.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190607152223.9467-4-crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/acceptance/migration.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
index 6115cf6c24..a44c1ae58f 100644
--- a/tests/acceptance/migration.py
+++ b/tests/acceptance/migration.py
@@ -17,9 +17,6 @@ from avocado.utils import wait
 
 
 class Migration(Test):
-    """
-    :avocado: enable
-    """
 
     timeout = 10
 
-- 
2.21.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28
  2019-08-29  1:03 [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28 Cleber Rosa
                   ` (2 preceding siblings ...)
  2019-08-29  1:03 ` [Qemu-devel] [PULL 3/5] Acceptance tests: drop left over usage of ":avocado: enable" Cleber Rosa
@ 2019-09-03 16:19 ` Peter Maydell
  3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2019-09-03 16:19 UTC (permalink / raw)
  To: Cleber Rosa
  Cc: Fam Zheng, Philippe Mathieu-Daudé,
	Alex Bennée, QEMU Developers, Eduardo Habkost

On Thu, 29 Aug 2019 at 02:04, Cleber Rosa <crosa@redhat.com> wrote:
>
> The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4:
>
>   Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/clebergnu/qemu.git tags/python-next-pull-request
>
> for you to fetch changes up to d19818e50e5286f878a76a286b76d29e57140dd4:
>
>   VNC Acceptance test: simplify test names (2019-08-28 20:42:16 -0400)
>
> ----------------------------------------------------------------
>
> Cleber Rosa (4):
>   tests/requirements.txt: pin paramiko version requirement
>   Acceptance tests: drop left over usage of ":avocado: enable"
>   Boot Linux Console Test: add a test for ppc64 + pseries
>   VNC Acceptance test: simplify test names
>
> Satheesh Rajendran (1):
>   tests.acceptance.avocado_qemu: Add support for powerpc



Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-09-03 16:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-29  1:03 [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28 Cleber Rosa
2019-08-29  1:03 ` [Qemu-devel] [PULL 1/5] tests.acceptance.avocado_qemu: Add support for powerpc Cleber Rosa
2019-08-29  1:03 ` [Qemu-devel] [PULL 2/5] tests/requirements.txt: pin paramiko version requirement Cleber Rosa
2019-08-29  1:03 ` [Qemu-devel] [PULL 3/5] Acceptance tests: drop left over usage of ":avocado: enable" Cleber Rosa
2019-09-03 16:19 ` [Qemu-devel] [PULL 0/5] Python (acceptance tests) queue, 2019-08-28 Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).