* [Qemu-devel] [PATCH] ppc/pnv: fix "bmc" node name in DT
@ 2019-09-02 9:29 Cédric Le Goater
2019-09-02 10:28 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Cédric Le Goater @ 2019-09-02 9:29 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-ppc, qemu-devel, Cédric Le Goater
Fixes the dtc output :
ERROR (node_name_chars): //bmc: Bad character '/' in node name
Warning (avoid_unnecessary_addr_size): /bmc: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/ppc/pnv_bmc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c
index e5eb6e5a70da..dc5e918cb79e 100644
--- a/hw/ppc/pnv_bmc.c
+++ b/hw/ppc/pnv_bmc.c
@@ -77,13 +77,10 @@ void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt)
const struct ipmi_sdr_compact *sdr;
uint16_t nextrec;
- offset = fdt_add_subnode(fdt, 0, "/bmc");
+ offset = fdt_add_subnode(fdt, 0, "bmc");
_FDT(offset);
_FDT((fdt_setprop_string(fdt, offset, "name", "bmc")));
- _FDT((fdt_setprop_cell(fdt, offset, "#address-cells", 0x1)));
- _FDT((fdt_setprop_cell(fdt, offset, "#size-cells", 0x0)));
-
offset = fdt_add_subnode(fdt, offset, "sensors");
_FDT(offset);
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] ppc/pnv: fix "bmc" node name in DT
2019-09-02 9:29 [Qemu-devel] [PATCH] ppc/pnv: fix "bmc" node name in DT Cédric Le Goater
@ 2019-09-02 10:28 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2019-09-02 10:28 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-ppc, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On Mon, Sep 02, 2019 at 11:29:32AM +0200, Cédric Le Goater wrote:
> Fixes the dtc output :
>
> ERROR (node_name_chars): //bmc: Bad character '/' in node name
> Warning (avoid_unnecessary_addr_size): /bmc: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied to ppc-for-4.2, thanks.
> ---
> hw/ppc/pnv_bmc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c
> index e5eb6e5a70da..dc5e918cb79e 100644
> --- a/hw/ppc/pnv_bmc.c
> +++ b/hw/ppc/pnv_bmc.c
> @@ -77,13 +77,10 @@ void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt)
> const struct ipmi_sdr_compact *sdr;
> uint16_t nextrec;
>
> - offset = fdt_add_subnode(fdt, 0, "/bmc");
> + offset = fdt_add_subnode(fdt, 0, "bmc");
> _FDT(offset);
>
> _FDT((fdt_setprop_string(fdt, offset, "name", "bmc")));
> - _FDT((fdt_setprop_cell(fdt, offset, "#address-cells", 0x1)));
> - _FDT((fdt_setprop_cell(fdt, offset, "#size-cells", 0x0)));
> -
> offset = fdt_add_subnode(fdt, offset, "sensors");
> _FDT(offset);
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-02 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-02 9:29 [Qemu-devel] [PATCH] ppc/pnv: fix "bmc" node name in DT Cédric Le Goater
2019-09-02 10:28 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).