* [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c
@ 2019-09-12 18:46 Eric Blake
2019-09-13 6:25 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Eric Blake @ 2019-09-12 18:46 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth
This file is version-controlled, and not generated from a .json file.
Fixes: bf582c3461b
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index e9bbc006d39e..7de868d1eab4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,6 +41,7 @@
/qapi/qapi-types-*.[ch]
/qapi/qapi-types.[ch]
/qapi/qapi-visit-*.[ch]
+!/qapi/qapi-visit-core.c
/qapi/qapi-visit.[ch]
/qapi/qapi-doc.texi
/qemu-doc.html
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c
2019-09-12 18:46 [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c Eric Blake
@ 2019-09-13 6:25 ` Thomas Huth
2019-09-13 11:05 ` Philippe Mathieu-Daudé
2019-09-13 11:34 ` Eric Blake
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2019-09-13 6:25 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: qemu-trivial
On 12/09/2019 20.46, Eric Blake wrote:
> This file is version-controlled, and not generated from a .json file.
>
> Fixes: bf582c3461b
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index e9bbc006d39e..7de868d1eab4 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -41,6 +41,7 @@
> /qapi/qapi-types-*.[ch]
> /qapi/qapi-types.[ch]
> /qapi/qapi-visit-*.[ch]
> +!/qapi/qapi-visit-core.c
> /qapi/qapi-visit.[ch]
> /qapi/qapi-doc.texi
> /qemu-doc.html
>
Thanks!
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c
2019-09-12 18:46 [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c Eric Blake
2019-09-13 6:25 ` Thomas Huth
@ 2019-09-13 11:05 ` Philippe Mathieu-Daudé
2019-09-13 11:34 ` Eric Blake
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-09-13 11:05 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: Thomas Huth
On 9/12/19 8:46 PM, Eric Blake wrote:
> This file is version-controlled, and not generated from a .json file.
>
> Fixes: bf582c3461b
> Reported-by: Thomas Huth <thuth@redhat.com>
Good catch!
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index e9bbc006d39e..7de868d1eab4 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -41,6 +41,7 @@
> /qapi/qapi-types-*.[ch]
> /qapi/qapi-types.[ch]
> /qapi/qapi-visit-*.[ch]
> +!/qapi/qapi-visit-core.c
> /qapi/qapi-visit.[ch]
> /qapi/qapi-doc.texi
> /qemu-doc.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c
2019-09-12 18:46 [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c Eric Blake
2019-09-13 6:25 ` Thomas Huth
2019-09-13 11:05 ` Philippe Mathieu-Daudé
@ 2019-09-13 11:34 ` Eric Blake
2019-09-19 10:14 ` Laurent Vivier
2 siblings, 1 reply; 5+ messages in thread
From: Eric Blake @ 2019-09-13 11:34 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Thomas Huth
[-- Attachment #1.1: Type: text/plain, Size: 781 bytes --]
cc: qemu-trivial
On 9/12/19 1:46 PM, Eric Blake wrote:
> This file is version-controlled, and not generated from a .json file.
>
> Fixes: bf582c3461b
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index e9bbc006d39e..7de868d1eab4 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -41,6 +41,7 @@
> /qapi/qapi-types-*.[ch]
> /qapi/qapi-types.[ch]
> /qapi/qapi-visit-*.[ch]
> +!/qapi/qapi-visit-core.c
> /qapi/qapi-visit.[ch]
> /qapi/qapi-doc.texi
> /qemu-doc.html
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c
2019-09-13 11:34 ` Eric Blake
@ 2019-09-19 10:14 ` Laurent Vivier
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2019-09-19 10:14 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: qemu-trivial, Thomas Huth
[-- Attachment #1.1: Type: text/plain, Size: 791 bytes --]
Le 13/09/2019 à 13:34, Eric Blake a écrit :
> cc: qemu-trivial
>
> On 9/12/19 1:46 PM, Eric Blake wrote:
>> This file is version-controlled, and not generated from a .json file.
>>
>> Fixes: bf582c3461b
>> Reported-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>> .gitignore | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index e9bbc006d39e..7de868d1eab4 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -41,6 +41,7 @@
>> /qapi/qapi-types-*.[ch]
>> /qapi/qapi-types.[ch]
>> /qapi/qapi-visit-*.[ch]
>> +!/qapi/qapi-visit-core.c
>> /qapi/qapi-visit.[ch]
>> /qapi/qapi-doc.texi
>> /qemu-doc.html
>>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-19 10:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 18:46 [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c Eric Blake
2019-09-13 6:25 ` Thomas Huth
2019-09-13 11:05 ` Philippe Mathieu-Daudé
2019-09-13 11:34 ` Eric Blake
2019-09-19 10:14 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).