* [PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern
@ 2019-09-19 16:14 Cleber Rosa
2019-09-19 16:19 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Cleber Rosa @ 2019-09-19 16:14 UTC (permalink / raw)
To: qemu-devel
Cc: Willian Rampazzo, Philippe Mathieu-Daudé,
Eduardo Habkost, Wainer dos Santos Moschetta, Cleber Rosa
Instead of looking for a specific error, let's relax the pattern
because different errors have been seen (I'm consistenly getting 52)
and the real goal of this test is to validate the framebuffer
operation, and not to reproduce one specific error.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
tests/acceptance/machine_m68k_nextcube.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/acceptance/machine_m68k_nextcube.py b/tests/acceptance/machine_m68k_nextcube.py
index e09cab9f20..fcd2c58ee7 100644
--- a/tests/acceptance/machine_m68k_nextcube.py
+++ b/tests/acceptance/machine_m68k_nextcube.py
@@ -116,6 +116,6 @@ class NextCubeMachine(Test):
if len(line):
console_logger.debug(line)
self.assertIn('Testing the FPU, SCC', text)
- self.assertIn('System test failed. Error code 51', text)
+ self.assertIn('System test failed. Error code', text)
self.assertIn('Boot command', text)
self.assertIn('Next>', text)
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern
2019-09-19 16:14 [PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern Cleber Rosa
@ 2019-09-19 16:19 ` Philippe Mathieu-Daudé
2019-09-19 19:26 ` Thomas Huth
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-09-19 16:19 UTC (permalink / raw)
To: Cleber Rosa, qemu-devel
Cc: Thomas Huth, Willian Rampazzo, Eduardo Habkost,
Wainer dos Santos Moschetta
Cc'ing Thomas
On 9/19/19 6:14 PM, Cleber Rosa wrote:
> Instead of looking for a specific error, let's relax the pattern
> because different errors have been seen (I'm consistenly getting 52)
> and the real goal of this test is to validate the framebuffer
> operation, and not to reproduce one specific error.
This might be because I wrote this test before Thomas added the serial
controller (commit b17bed5b1727e3aa9e37fc8e8c3222130ceab22f).
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/machine_m68k_nextcube.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/acceptance/machine_m68k_nextcube.py b/tests/acceptance/machine_m68k_nextcube.py
> index e09cab9f20..fcd2c58ee7 100644
> --- a/tests/acceptance/machine_m68k_nextcube.py
> +++ b/tests/acceptance/machine_m68k_nextcube.py
> @@ -116,6 +116,6 @@ class NextCubeMachine(Test):
> if len(line):
> console_logger.debug(line)
> self.assertIn('Testing the FPU, SCC', text)
> - self.assertIn('System test failed. Error code 51', text)
> + self.assertIn('System test failed. Error code', text)
> self.assertIn('Boot command', text)
> self.assertIn('Next>', text)
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern
2019-09-19 16:19 ` Philippe Mathieu-Daudé
@ 2019-09-19 19:26 ` Thomas Huth
2019-09-19 22:20 ` Cleber Rosa
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2019-09-19 19:26 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Willian Rampazzo, Wainer dos Santos Moschetta, qemu-devel,
Eduardo Habkost, Cleber Rosa
Am Thu, 19 Sep 2019 18:19:40 +0200
schrieb Philippe Mathieu-Daudé <philmd@redhat.com>:
> Cc'ing Thomas
>
> On 9/19/19 6:14 PM, Cleber Rosa wrote:
> > Instead of looking for a specific error, let's relax the pattern
> > because different errors have been seen (I'm consistenly getting 52)
> > and the real goal of this test is to validate the framebuffer
> > operation, and not to reproduce one specific error.
>
> This might be because I wrote this test before Thomas added the serial
> controller (commit b17bed5b1727e3aa9e37fc8e8c3222130ceab22f).
That's strange, the travis job worked fine for me ... but sure, let's
drop the error number, we don't need it here.
> > Signed-off-by: Cleber Rosa <crosa@redhat.com>
> > ---
> > tests/acceptance/machine_m68k_nextcube.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/acceptance/machine_m68k_nextcube.py
> > b/tests/acceptance/machine_m68k_nextcube.py index
> > e09cab9f20..fcd2c58ee7 100644 ---
> > a/tests/acceptance/machine_m68k_nextcube.py +++
> > b/tests/acceptance/machine_m68k_nextcube.py @@ -116,6 +116,6 @@
> > class NextCubeMachine(Test): if len(line):
> > console_logger.debug(line)
> > self.assertIn('Testing the FPU, SCC', text)
> > - self.assertIn('System test failed. Error code 51', text)
> > + self.assertIn('System test failed. Error code', text)
> > self.assertIn('Boot command', text)
> > self.assertIn('Next>', text)
> >
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern
2019-09-19 19:26 ` Thomas Huth
@ 2019-09-19 22:20 ` Cleber Rosa
0 siblings, 0 replies; 4+ messages in thread
From: Cleber Rosa @ 2019-09-19 22:20 UTC (permalink / raw)
To: Thomas Huth
Cc: Willian Rampazzo, Philippe Mathieu-Daudé,
qemu-devel, Wainer dos Santos Moschetta, Eduardo Habkost
On Thu, Sep 19, 2019 at 09:26:35PM +0200, Thomas Huth wrote:
> Am Thu, 19 Sep 2019 18:19:40 +0200
> schrieb Philippe Mathieu-Daudé <philmd@redhat.com>:
>
> > Cc'ing Thomas
> >
> > On 9/19/19 6:14 PM, Cleber Rosa wrote:
> > > Instead of looking for a specific error, let's relax the pattern
> > > because different errors have been seen (I'm consistenly getting 52)
> > > and the real goal of this test is to validate the framebuffer
> > > operation, and not to reproduce one specific error.
> >
> > This might be because I wrote this test before Thomas added the serial
> > controller (commit b17bed5b1727e3aa9e37fc8e8c3222130ceab22f).
>
> That's strange, the travis job worked fine for me ... but sure, let's
> drop the error number, we don't need it here.
>
> > > Signed-off-by: Cleber Rosa <crosa@redhat.com>
> > > ---
> > > tests/acceptance/machine_m68k_nextcube.py | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/acceptance/machine_m68k_nextcube.py
> > > b/tests/acceptance/machine_m68k_nextcube.py index
> > > e09cab9f20..fcd2c58ee7 100644 ---
> > > a/tests/acceptance/machine_m68k_nextcube.py +++
> > > b/tests/acceptance/machine_m68k_nextcube.py @@ -116,6 +116,6 @@
> > > class NextCubeMachine(Test): if len(line):
> > > console_logger.debug(line)
> > > self.assertIn('Testing the FPU, SCC', text)
> > > - self.assertIn('System test failed. Error code 51', text)
> > > + self.assertIn('System test failed. Error code', text)
> > > self.assertIn('Boot command', text)
> > > self.assertIn('Next>', text)
> > >
> >
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: Thomas Huth <huth@tuxfamily.org>
Thanks for the prompt review, queueing on my python-next branch.
- Cleber.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-19 22:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-19 16:14 [PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern Cleber Rosa
2019-09-19 16:19 ` Philippe Mathieu-Daudé
2019-09-19 19:26 ` Thomas Huth
2019-09-19 22:20 ` Cleber Rosa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).