* header not included but used in vl.c
@ 2019-10-01 12:06 Toe Dev
2019-10-09 14:21 ` Stefan Hajnoczi
0 siblings, 1 reply; 4+ messages in thread
From: Toe Dev @ 2019-10-01 12:06 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
Hello,
does it have a reason why the file vl.c lacks reference
#include "qemu/module.h" ?
but still uses the defines include their(for example the enum value:
MODULE_INIT_OPTS)?
I'm using eclipse so I was notified by the IDE immediately.
Thanks for yours help :)
[-- Attachment #2: Type: text/html, Size: 451 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: header not included but used in vl.c
2019-10-01 12:06 header not included but used in vl.c Toe Dev
@ 2019-10-09 14:21 ` Stefan Hajnoczi
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2019-10-09 14:21 UTC (permalink / raw)
To: Toe Dev; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
On Tue, Oct 01, 2019 at 03:06:56PM +0300, Toe Dev wrote:
> does it have a reason why the file vl.c lacks reference
> #include "qemu/module.h" ?
> but still uses the defines include their(for example the enum value:
> MODULE_INIT_OPTS)?
> I'm using eclipse so I was notified by the IDE immediately.
Another header file probably includes it indirectly.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: header not included but used in vl.c
2019-10-01 12:12 Toe Dev
@ 2019-10-01 12:56 ` Daniel P. Berrangé
0 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2019-10-01 12:56 UTC (permalink / raw)
To: Toe Dev; +Cc: qemu-devel
On Tue, Oct 01, 2019 at 03:12:17PM +0300, Toe Dev wrote:
> Hello,
> does it have a reason why the file vl.c lacks reference
> #include "qemu/module.h" ?
> but still uses the defines include their(for example the enum value:
> MODULE_INIT_OPTS)?
qemu/module.h is included by qom/object.h which is included by many
many things in QEMU, so vl.c gets module.h indirectly which is fine.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* header not included but used in vl.c
@ 2019-10-01 12:12 Toe Dev
2019-10-01 12:56 ` Daniel P. Berrangé
0 siblings, 1 reply; 4+ messages in thread
From: Toe Dev @ 2019-10-01 12:12 UTC (permalink / raw)
To: qemu-devel
Hello,
does it have a reason why the file vl.c lacks reference
#include "qemu/module.h" ?
but still uses the defines include their(for example the enum value:
MODULE_INIT_OPTS)?
I'm using eclipse so I was notified by the IDE immediately.
Thanks for yours help :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-09 19:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 12:06 header not included but used in vl.c Toe Dev
2019-10-09 14:21 ` Stefan Hajnoczi
2019-10-01 12:12 Toe Dev
2019-10-01 12:56 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).