[PATCH 0/2] use helper when using abstract QOM parent functions

[PATCH 0/2] use helper when using abstract QOM parent functions

[Mao Zhongyi]

Philippe introduced a series of helpers to make the
device class_init() easier to understand when a device
class change the parent hooks, some devices in the
source tree missed helper, so convert it.

Cc: eric.auger@redhat.com
Cc: peter.maydell@linaro.org
Cc: hpoussin@reactos.org
Cc: f4bug@amsat.org

Mao Zhongyi (2):
  arm/smmuv3: use helpers to be more easier to understand when using
    abstract QOM parent functions.
  isa/pc87312: use helpers to be more easier to understand when using
    abstract QOM parent functions.

 hw/arm/smmuv3.c  | 3 +--
 hw/isa/pc87312.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

-- 
2.17.1

[PATCH 1/2] arm/smmuv3: use helper to be more easier to understand when using abstract QOM parent functions.

[Mao Zhongyi]

Philippe introduced a series of helpers to make the
device class_init() easier to understand when a
device class change the parent hooks, device smmuv3
missed helper, so convert it.

Cc: eric.auger@redhat.com
Cc: peter.maydell@linaro.org
Cc: f4bug@amsat.org
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
---
 hw/arm/smmuv3.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
index e2fbb8357e..65b6b158e5 100644
--- a/hw/arm/smmuv3.c
+++ b/hw/arm/smmuv3.c
@@ -1465,8 +1465,7 @@ static void smmuv3_class_init(ObjectClass *klass, void *data)
 
     dc->vmsd = &vmstate_smmuv3;
     device_class_set_parent_reset(dc, smmu_reset, &c->parent_reset);
-    c->parent_realize = dc->realize;
-    dc->realize = smmu_realize;
+    device_class_set_parent_realize(dc, smmu_realize, &c->parent_realize);
 }
 
 static int smmuv3_notify_flag_changed(IOMMUMemoryRegion *iommu,
-- 
2.17.1

[PATCH 2/2] isa/pc87312: use helper to be more easier to understand when using abstract QOM parent functions.

[Mao Zhongyi]

Philippe introduced a series of helpers to make the
device class_init() easier to understand when a
device class change the parent hooks, device pc87312
missed helper, so convert it.

Cc: hpoussin@reactos.org
Cc: f4bug@amsat.org
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
---
 hw/isa/pc87312.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c
index b9bd57471e..13c1c43d2f 100644
--- a/hw/isa/pc87312.c
+++ b/hw/isa/pc87312.c
@@ -338,8 +338,7 @@ static void pc87312_class_init(ObjectClass *klass, void *data)
     DeviceClass *dc = DEVICE_CLASS(klass);
     ISASuperIOClass *sc = ISA_SUPERIO_CLASS(klass);
 
-    sc->parent_realize = dc->realize;
-    dc->realize = pc87312_realize;
+    device_class_set_parent_realize(dc, pc87312_realize, &sc->parent_realize);
     dc->reset = pc87312_reset;
     dc->vmsd = &vmstate_pc87312;
     dc->props = pc87312_properties;
-- 
2.17.1

Re: [PATCH 0/2] use helper when using abstract QOM parent functions

[Auger Eric]

Hi,

On 10/12/19 11:43 AM, Mao Zhongyi wrote:
> Philippe introduced a series of helpers to make the
> device class_init() easier to understand when a device
> class change the parent hooks, some devices in the
> source tree missed helper, so convert it.
> 
> Cc: eric.auger@redhat.com
> Cc: peter.maydell@linaro.org
> Cc: hpoussin@reactos.org
> Cc: f4bug@amsat.org
> 
> Mao Zhongyi (2):
>   arm/smmuv3: use helpers to be more easier to understand when using
>     abstract QOM parent functions.
>   isa/pc87312: use helpers to be more easier to understand when using
>     abstract QOM parent functions.
> 
>  hw/arm/smmuv3.c  | 3 +--
>  hw/isa/pc87312.c | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 

for the series:
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric

Re: [PATCH 0/2] use helper when using abstract QOM parent functions

[maozy]

Hi,

On 10/14/19 5:12 PM, Auger Eric wrote:
> Hi,
> 
> On 10/12/19 11:43 AM, Mao Zhongyi wrote:
>> Philippe introduced a series of helpers to make the
>> device class_init() easier to understand when a device
>> class change the parent hooks, some devices in the
>> source tree missed helper, so convert it.
>>
>> Cc: eric.auger@redhat.com
>> Cc: peter.maydell@linaro.org
>> Cc: hpoussin@reactos.org
>> Cc: f4bug@amsat.org
>>
>> Mao Zhongyi (2):
>>    arm/smmuv3: use helpers to be more easier to understand when using
>>      abstract QOM parent functions.
>>    isa/pc87312: use helpers to be more easier to understand when using
>>      abstract QOM parent functions.
>>
>>   hw/arm/smmuv3.c  | 3 +--
>>   hw/isa/pc87312.c | 3 +--
>>   2 files changed, 2 insertions(+), 4 deletions(-)
>>
> 
> for the series:
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> 

ping...

> 
> Eric
>