[PULL v2 0/2] Tracing patches

[PULL v2 0/2] Tracing patches

[Stefan Hajnoczi]

The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:

  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)

are available in the Git repository at:

  https://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 403e11edbfad5da2e6d5842adc9222f60e76ee43:

  trace: avoid "is" with a literal Python 3.8 warnings (2019-10-15 09:47:16 +0100)

----------------------------------------------------------------
Pull request

v2:
 * Replaced "Launchpad:" tag with "Buglink:" as documented on the SubmitAPatch wiki page [Philippe]

----------------------------------------------------------------

Stefan Hajnoczi (2):
  trace: add --group=all to tracing.txt
  trace: avoid "is" with a literal Python 3.8 warnings

 docs/devel/tracing.txt        | 3 ++-
 scripts/tracetool/__init__.py | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.21.0

[PULL v2 1/2] trace: add --group=all to tracing.txt

[Stefan Hajnoczi]

tracetool needs to know the group name ("all", "root", or a specific
subdirectory).  Also remove the stdin redirection because tracetool.py
needs the path to the trace-events file.  Update the documentation.

Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
       ("trace: move setting of group name into Makefiles")
Buglink: https://bugs.launchpad.net/bugs/1844814
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20191009135154.10970-1-stefanha@redhat.com>
---
 docs/devel/tracing.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
index 8231bbf5d1..8c0376fefa 100644
--- a/docs/devel/tracing.txt
+++ b/docs/devel/tracing.txt
@@ -317,7 +317,8 @@ probes:
                          --binary path/to/qemu-binary \
                          --target-type system \
                          --target-name x86_64 \
-                         <trace-events-all >qemu.stp
+                         --group=all \
+                         trace-events-all >qemu.stp
 
 To facilitate simple usage of systemtap where there merely needs to be printf
 logging of certain probes, a helper script "qemu-trace-stap" is provided.
-- 
2.21.0

[PULL v2 2/2] trace: avoid "is" with a literal Python 3.8 warnings

[Stefan Hajnoczi]

The following statement produces a SyntaxWarning with Python 3.8:

  if len(format) is 0:
  scripts/tracetool/__init__.py:459: SyntaxWarning: "is" with a literal. Did you mean "=="?

Use the conventional len(x) == 0 syntax instead.

Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20191010122154.10553-1-stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 scripts/tracetool/__init__.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index 04279fa62e..44c118bc2a 100644
--- a/scripts/tracetool/__init__.py
+++ b/scripts/tracetool/__init__.py
@@ -456,12 +456,12 @@ def generate(events, group, format, backends,
     import tracetool
 
     format = str(format)
-    if len(format) is 0:
+    if len(format) == 0:
         raise TracetoolError("format not set")
     if not tracetool.format.exists(format):
         raise TracetoolError("unknown format: %s" % format)
 
-    if len(backends) is 0:
+    if len(backends) == 0:
         raise TracetoolError("no backends specified")
     for backend in backends:
         if not tracetool.backend.exists(backend):
-- 
2.21.0

Re: [PULL v2 0/2] Tracing patches

[Philippe Mathieu-Daudé]

On 10/15/19 10:49 AM, Stefan Hajnoczi wrote:
> The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
> 
>    Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
> 
> are available in the Git repository at:
> 
>    https://github.com/stefanha/qemu.git tags/tracing-pull-request
> 
> for you to fetch changes up to 403e11edbfad5da2e6d5842adc9222f60e76ee43:
> 
>    trace: avoid "is" with a literal Python 3.8 warnings (2019-10-15 09:47:16 +0100)
> 
> ----------------------------------------------------------------
> Pull request
> 
> v2:
>   * Replaced "Launchpad:" tag with "Buglink:" as documented on the SubmitAPatch wiki page [Philippe]

Thanks Stefan for this updated pullreq!

Re: [PULL v2 0/2] Tracing patches

[Stefan Hajnoczi]

On Mon, Oct 26, 2020 at 5:03 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
> On 10/26/20 5:02 PM, Stefan Hajnoczi wrote:
> > The following changes since commit 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430:
> >
> >    Merge remote-tracking branch 'remotes/kraxel/tags/modules-20201022-pull-request' into staging (2020-10-22 12:33:21 +0100)
> >
> > are available in the Git repository at:
> >
> >    https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
> >
> > for you to fetch changes up to 1e8ebf1116a7023b4dd1919d31af8b4e17321da4:
> >
> >    Add execute bit back to scripts/tracetool.py (2020-10-26 13:22:36 +0000)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > ----------------------------------------------------------------
> >
> > Anthony PERARD via (1):
> >    Add execute bit back to scripts/tracetool.py
>
> Author email is incorrect: Anthony PERARD via <qemu-devel@nongnu.org>

Thank you, sending v2.

Stefan

Re: [PULL v2 0/2] Tracing patches

[Philippe Mathieu-Daudé]

Hi Stefan,

On 10/26/20 5:02 PM, Stefan Hajnoczi wrote:
> The following changes since commit 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430:
> 
>    Merge remote-tracking branch 'remotes/kraxel/tags/modules-20201022-pull-request' into staging (2020-10-22 12:33:21 +0100)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
> 
> for you to fetch changes up to 1e8ebf1116a7023b4dd1919d31af8b4e17321da4:
> 
>    Add execute bit back to scripts/tracetool.py (2020-10-26 13:22:36 +0000)
> 
> ----------------------------------------------------------------
> Pull request
> 
> ----------------------------------------------------------------
> 
> Anthony PERARD via (1):
>    Add execute bit back to scripts/tracetool.py

Author email is incorrect: Anthony PERARD via <qemu-devel@nongnu.org>

> 
> Josh DuBois (1):
>    trace/simple: Enable tracing on startup only if the user specifies a
>      trace option
> 
>   trace/control.c      | 6 +++++-
>   scripts/tracetool.py | 0
>   2 files changed, 5 insertions(+), 1 deletion(-)
>   mode change 100644 => 100755 scripts/tracetool.py
> 

[PULL v2 0/2] Tracing patches

[Stefan Hajnoczi]

The following changes since commit 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430:

  Merge remote-tracking branch 'remotes/kraxel/tags/modules-20201022-pull-request' into staging (2020-10-22 12:33:21 +0100)

are available in the Git repository at:

  https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to 1e8ebf1116a7023b4dd1919d31af8b4e17321da4:

  Add execute bit back to scripts/tracetool.py (2020-10-26 13:22:36 +0000)

----------------------------------------------------------------
Pull request

----------------------------------------------------------------

Anthony PERARD via (1):
  Add execute bit back to scripts/tracetool.py

Josh DuBois (1):
  trace/simple: Enable tracing on startup only if the user specifies a
    trace option

 trace/control.c      | 6 +++++-
 scripts/tracetool.py | 0
 2 files changed, 5 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 scripts/tracetool.py

-- 
2.26.2