[PATCH] ui: Print available display backends with '-display help'

[PATCH] ui: Print available display backends with '-display help'

[Thomas Huth]

We already print availabled devices with "-device help", or available
backends with "-netdev help" or "-chardev help". Let's provide a way
for the users to query the available display backends, too.

Signed-off-by: Thomas Huth <huth@tuxfamily.org>
---
 include/ui/console.h |  1 +
 ui/console.c         | 12 ++++++++++++
 vl.c                 |  5 +++++
 3 files changed, 18 insertions(+)

diff --git a/include/ui/console.h b/include/ui/console.h
index f981696848..b7e1a8e6c0 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -440,6 +440,7 @@ void qemu_display_register(QemuDisplay *ui);
 bool qemu_display_find_default(DisplayOptions *opts);
 void qemu_display_early_init(DisplayOptions *opts);
 void qemu_display_init(DisplayState *ds, DisplayOptions *opts);
+void qemu_display_help(void);
 
 /* vnc.c */
 void vnc_display_init(const char *id, Error **errp);
diff --git a/ui/console.c b/ui/console.c
index 82d1ddac9c..2c92eb2377 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -2330,6 +2330,18 @@ void qemu_display_init(DisplayState *ds, DisplayOptions *opts)
     dpys[opts->type]->init(ds, opts);
 }
 
+void qemu_display_help(void)
+{
+    int idx;
+
+    printf("Available display backend types:\n");
+    for (idx = 0; idx < DISPLAY_TYPE__MAX; idx++) {
+        if (dpys[idx]) {
+            printf("%s\n",  DisplayType_str(dpys[idx]->type));
+        }
+    }
+}
+
 void qemu_chr_parse_vc(QemuOpts *opts, ChardevBackend *backend, Error **errp)
 {
     int val;
diff --git a/vl.c b/vl.c
index 4489cfb2bb..3e215beb43 100644
--- a/vl.c
+++ b/vl.c
@@ -2006,6 +2006,11 @@ static void parse_display(const char *p)
 {
     const char *opts;
 
+    if (is_help_option(p)) {
+        qemu_display_help();
+        exit(0);
+    }
+
     if (strstart(p, "sdl", &opts)) {
         /*
          * sdl DisplayType needs hand-crafted parser instead of
-- 
2.21.0

Re: [PATCH] ui: Print available display backends with '-display help'

[Gerd Hoffmann]

On Wed, Oct 23, 2019 at 03:41:51PM +0200, Thomas Huth wrote:
> We already print availabled devices with "-device help", or available
> backends with "-netdev help" or "-chardev help". Let's provide a way
> for the users to query the available display backends, too.

It isn't that simple, this fails to list backends built as module.

cheers,
  Gerd