* [PATCH v2] qemu-img.texi: Describe data_file and data_file_raw
@ 2019-10-21 1:14 Han Han
2019-10-23 15:20 ` John Snow
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Han Han @ 2019-10-21 1:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Han Han, qemu-block
https://bugzilla.redhat.com/show_bug.cgi?id=1763105
Signed-off-by: Han Han <hhan@redhat.com>
---
qemu-img.texi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/qemu-img.texi b/qemu-img.texi
index b5156d6316..983c6122f8 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't be changed to NOCOW
by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
+@item data_file
+File name of data file that is stored in the image and used as a default for
+opening the image. If the option is used, qcow2 file only stores the metadata
+for the image.
+
+@item data_file_raw
+This option requires @option{data_file}. If this option is set to @code{on},
+qemu will always keep the external data file consistent as a standalone
+read-only raw image. Default value is @code{off}.
+
@end table
@item Other
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] qemu-img.texi: Describe data_file and data_file_raw
2019-10-21 1:14 [PATCH v2] qemu-img.texi: Describe data_file and data_file_raw Han Han
@ 2019-10-23 15:20 ` John Snow
2019-10-27 8:30 ` Stefan Hajnoczi
2019-10-28 14:39 ` Max Reitz
2 siblings, 0 replies; 5+ messages in thread
From: John Snow @ 2019-10-23 15:20 UTC (permalink / raw)
To: Han Han, qemu-devel; +Cc: qemu-block
On 10/20/19 9:14 PM, Han Han wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1763105
>
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
> qemu-img.texi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/qemu-img.texi b/qemu-img.texi
> index b5156d6316..983c6122f8 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't be changed to NOCOW
> by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
> the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
>
> +@item data_file
> +File name of data file that is stored in the image and used as a default for
> +opening the image. If the option is used, qcow2 file only stores the metadata
> +for the image.
> +
> +@item data_file_raw
> +This option requires @option{data_file}. If this option is set to @code{on},
> +qemu will always keep the external data file consistent as a standalone
> +read-only raw image. Default value is @code{off}.
> +
> @end table
>
> @item Other
>
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] qemu-img.texi: Describe data_file and data_file_raw
2019-10-21 1:14 [PATCH v2] qemu-img.texi: Describe data_file and data_file_raw Han Han
2019-10-23 15:20 ` John Snow
@ 2019-10-27 8:30 ` Stefan Hajnoczi
2019-10-28 14:39 ` Max Reitz
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2019-10-27 8:30 UTC (permalink / raw)
To: Han Han; +Cc: qemu-devel, qemu-block
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
On Mon, Oct 21, 2019 at 09:14:21AM +0800, Han Han wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1763105
>
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
> qemu-img.texi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] qemu-img.texi: Describe data_file and data_file_raw
2019-10-21 1:14 [PATCH v2] qemu-img.texi: Describe data_file and data_file_raw Han Han
2019-10-23 15:20 ` John Snow
2019-10-27 8:30 ` Stefan Hajnoczi
@ 2019-10-28 14:39 ` Max Reitz
2 siblings, 0 replies; 5+ messages in thread
From: Max Reitz @ 2019-10-28 14:39 UTC (permalink / raw)
To: Han Han, qemu-devel; +Cc: qemu-block
[-- Attachment #1.1: Type: text/plain, Size: 1754 bytes --]
On 21.10.19 03:14, Han Han wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1763105
>
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
> qemu-img.texi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/qemu-img.texi b/qemu-img.texi
> index b5156d6316..983c6122f8 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't be changed to NOCOW
> by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
> the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
Usually, I try not to be pedantic about specific phrasing and the like,
but this is going in the man page, so I suppose I have to be.
> +@item data_file
> +File name of data file that is stored in the image and used as a default for
This sounds a bit like the data file itself were stored in the image.
Also, I don’t think the bit about this being a default is necessary
because several qcow2 creation options are in some way only defaults
than can be overridden at runtime (like lazy_refcounts or backing_file).
So I don’t think there is a need to make a mention of that here.
> +opening the image. If the option is used, qcow2 file only stores the metadata
> +for the image.
Maybe:
Path to a file in which to store all guest data. If this option is
used, the qcow2 file will only contain the image's metadata.
> +
> +@item data_file_raw
> +This option requires @option{data_file}. If this option is set to @code{on},
> +qemu will always keep the external data file consistent as a standalone
> +read-only raw image. Default value is @code{off}.
For this paragraph OTOH I have absolutely no complaints. :-)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] qemu-img.texi: Describe data_file and data_file_raw
@ 2019-10-21 1:07 Han Han
0 siblings, 0 replies; 5+ messages in thread
From: Han Han @ 2019-10-21 1:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Han Han, qemu-block
https://bugzilla.redhat.com/show_bug.cgi?id=1763105
Signed-off-by: Han Han <hhan@redhat.com>
---
qemu-img.texi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/qemu-img.texi b/qemu-img.texi
index b5156d6316..983c6122f8 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -763,6 +763,16 @@ file which is COW and has data blocks already, it couldn't be changed to NOCOW
by setting @code{nocow=on}. One can issue @code{lsattr filename} to check if
the NOCOW flag is set or not (Capital 'C' is NOCOW flag).
+@item data_file
+File name of data file that is stored in the image and used as a default for
+opening the image. If the option is used, qcow2 file only stores the metadata
+for the image.
+
+@item data_file_raw
+This option requires @option{data_file}. If this option is set to @code{on},
+qemu will always keep the external data file consistent as a standalone
+read-only raw image. Default value is @code{off}.
+
@end table
@item Other
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-28 14:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 1:14 [PATCH v2] qemu-img.texi: Describe data_file and data_file_raw Han Han
2019-10-23 15:20 ` John Snow
2019-10-27 8:30 ` Stefan Hajnoczi
2019-10-28 14:39 ` Max Reitz
-- strict thread matches above, loose matches on Subject: below --
2019-10-21 1:07 Han Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).