* [PATCH v1 0/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot
@ 2019-10-31 4:08 Edgar E. Iglesias
2019-10-31 4:08 ` [PATCH v1 1/1] " Edgar E. Iglesias
2019-11-01 8:25 ` [PATCH v1 0/1] " Peter Maydell
0 siblings, 2 replies; 6+ messages in thread
From: Edgar E. Iglesias @ 2019-10-31 4:08 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson,
frederic.konrad, philmd, luc.michel
I'm seeing asserts with missmatching hflags when doing direct boots
on versal. This patch fixes the problem for me, rebuilding hflags
after boot code modifes the state.
Cheers,
Edgar
Edgar E. Iglesias (1):
hw/arm/boot: Rebuild hflags when modifying CPUState at boot
hw/arm/boot.c | 1 +
1 file changed, 1 insertion(+)
--
2.19.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 1/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot
2019-10-31 4:08 [PATCH v1 0/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot Edgar E. Iglesias
@ 2019-10-31 4:08 ` Edgar E. Iglesias
2019-10-31 14:10 ` Philippe Mathieu-Daudé
` (2 more replies)
2019-11-01 8:25 ` [PATCH v1 0/1] " Peter Maydell
1 sibling, 3 replies; 6+ messages in thread
From: Edgar E. Iglesias @ 2019-10-31 4:08 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson,
frederic.konrad, philmd, luc.michel
Rebuild hflags when modifying CPUState at boot.
Fixes: e979972a6a
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
hw/arm/boot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index c264864c11..ef6724960c 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -786,6 +786,7 @@ static void do_cpu_reset(void *opaque)
info->secondary_cpu_reset_hook(cpu, info);
}
}
+ arm_rebuild_hflags(env);
}
}
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 1/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot
2019-10-31 4:08 ` [PATCH v1 1/1] " Edgar E. Iglesias
@ 2019-10-31 14:10 ` Philippe Mathieu-Daudé
2019-10-31 15:01 ` Alex Bennée
2019-10-31 18:33 ` Luc Michel
2 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-31 14:10 UTC (permalink / raw)
To: Edgar E. Iglesias, qemu-devel, qemu-arm
Cc: figlesia, peter.maydell, sstabellini, sai.pavan.boddu,
frasse.iglesias, alistair, richard.henderson, frederic.konrad,
luc.michel
On 10/31/19 5:08 AM, Edgar E. Iglesias wrote:
> Rebuild hflags when modifying CPUState at boot.
>
> Fixes: e979972a6a
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
> hw/arm/boot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/boot.c b/hw/arm/boot.c
> index c264864c11..ef6724960c 100644
> --- a/hw/arm/boot.c
> +++ b/hw/arm/boot.c
> @@ -786,6 +786,7 @@ static void do_cpu_reset(void *opaque)
> info->secondary_cpu_reset_hook(cpu, info);
> }
> }
> + arm_rebuild_hflags(env);
> }
> }
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot
2019-10-31 4:08 ` [PATCH v1 1/1] " Edgar E. Iglesias
2019-10-31 14:10 ` Philippe Mathieu-Daudé
@ 2019-10-31 15:01 ` Alex Bennée
2019-10-31 18:33 ` Luc Michel
2 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2019-10-31 15:01 UTC (permalink / raw)
To: qemu-devel
Cc: figlesia, peter.maydell, edgar.iglesias, sai.pavan.boddu,
frasse.iglesias, alistair, richard.henderson, frederic.konrad,
qemu-arm, sstabellini, philmd, luc.michel
Edgar E. Iglesias <edgar.iglesias@xilinx.com> writes:
> Rebuild hflags when modifying CPUState at boot.
>
> Fixes: e979972a6a
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
> hw/arm/boot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/boot.c b/hw/arm/boot.c
> index c264864c11..ef6724960c 100644
> --- a/hw/arm/boot.c
> +++ b/hw/arm/boot.c
> @@ -786,6 +786,7 @@ static void do_cpu_reset(void *opaque)
> info->secondary_cpu_reset_hook(cpu, info);
> }
> }
> + arm_rebuild_hflags(env);
Do we just get away with armv7m_reset because there is no futzing about
with execution state?
Anyway:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> }
> }
--
Alex Bennée
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot
2019-10-31 4:08 ` [PATCH v1 1/1] " Edgar E. Iglesias
2019-10-31 14:10 ` Philippe Mathieu-Daudé
2019-10-31 15:01 ` Alex Bennée
@ 2019-10-31 18:33 ` Luc Michel
2 siblings, 0 replies; 6+ messages in thread
From: Luc Michel @ 2019-10-31 18:33 UTC (permalink / raw)
To: Edgar E. Iglesias, qemu-devel, qemu-arm
Cc: figlesia, peter.maydell, sstabellini, sai.pavan.boddu,
frasse.iglesias, alistair, richard.henderson, frederic.konrad,
philmd
On 10/31/19 5:08 AM, Edgar E. Iglesias wrote:
> Rebuild hflags when modifying CPUState at boot.
>
> Fixes: e979972a6a
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Luc Michel <luc.michel@greensocs.com>
> ---
> hw/arm/boot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/boot.c b/hw/arm/boot.c
> index c264864c11..ef6724960c 100644
> --- a/hw/arm/boot.c
> +++ b/hw/arm/boot.c
> @@ -786,6 +786,7 @@ static void do_cpu_reset(void *opaque)
> info->secondary_cpu_reset_hook(cpu, info);
> }
> }
> + arm_rebuild_hflags(env);
> }
> }
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot
2019-10-31 4:08 [PATCH v1 0/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot Edgar E. Iglesias
2019-10-31 4:08 ` [PATCH v1 1/1] " Edgar E. Iglesias
@ 2019-11-01 8:25 ` Peter Maydell
1 sibling, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2019-11-01 8:25 UTC (permalink / raw)
To: Edgar E. Iglesias
Cc: figlesia, Stefano Stabellini, Sai Pavan Boddu,
Francisco Iglesias, Alistair Francis, Richard Henderson,
QEMU Developers, KONRAD Frederic, qemu-arm,
Philippe Mathieu-Daudé,
Luc Michel
On Thu, 31 Oct 2019 at 04:08, Edgar E. Iglesias
<edgar.iglesias@xilinx.com> wrote:
>
> I'm seeing asserts with missmatching hflags when doing direct boots
> on versal. This patch fixes the problem for me, rebuilding hflags
> after boot code modifes the state.
>
> Cheers,
> Edgar
>
> Edgar E. Iglesias (1):
> hw/arm/boot: Rebuild hflags when modifying CPUState at boot
>
> hw/arm/boot.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-01 8:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 4:08 [PATCH v1 0/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot Edgar E. Iglesias
2019-10-31 4:08 ` [PATCH v1 1/1] " Edgar E. Iglesias
2019-10-31 14:10 ` Philippe Mathieu-Daudé
2019-10-31 15:01 ` Alex Bennée
2019-10-31 18:33 ` Luc Michel
2019-11-01 8:25 ` [PATCH v1 0/1] " Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).