* [PATCH] Makefile: install bios-microvm like other binary blobs
@ 2019-11-02 11:43 Philippe Mathieu-Daudé
2019-11-02 16:57 ` Stefano Garzarella
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-11-02 11:43 UTC (permalink / raw)
To: qemu-devel, Sergio Lopez
Cc: qemu-trivial, Bruce Rogers, Michael S . Tsirkin,
Philippe Mathieu-Daudé,
Stefano Garzarella
From: Bruce Rogers <brogers@suse.com>
Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add
it to the list of blobs being installed.
Add it to the list of BLOBS that get installed.
Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot) as binary"
Signed-off-by: Bruce Rogers <brogers@suse.com>
[PMD: Reworded description]
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index bd6376d295..755aa6c5f5 100644
--- a/Makefile
+++ b/Makefile
@@ -770,7 +770,7 @@ de-ch es fo fr-ca hu ja mk pt sl tr \
bepo cz
ifdef INSTALL_BLOBS
-BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
+BLOBS=bios.bin bios-256k.bin bios-microvm.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \
vgabios-ramfb.bin vgabios-bochs-display.bin vgabios-ati.bin \
ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Makefile: install bios-microvm like other binary blobs
2019-11-02 11:43 [PATCH] Makefile: install bios-microvm like other binary blobs Philippe Mathieu-Daudé
@ 2019-11-02 16:57 ` Stefano Garzarella
2019-11-04 13:08 ` Sergio Lopez
2019-11-12 9:32 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2019-11-02 16:57 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, Bruce Rogers, qemu devel list, Sergio Lopez,
Michael S . Tsirkin
On Sat, Nov 2, 2019 at 12:43 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> From: Bruce Rogers <brogers@suse.com>
>
> Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add
> it to the list of blobs being installed.
> Add it to the list of BLOBS that get installed.
>
> Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot) as binary"
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> [PMD: Reworded description]
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The patch LGTM:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
>
> diff --git a/Makefile b/Makefile
> index bd6376d295..755aa6c5f5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -770,7 +770,7 @@ de-ch es fo fr-ca hu ja mk pt sl tr \
> bepo cz
>
> ifdef INSTALL_BLOBS
> -BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
> +BLOBS=bios.bin bios-256k.bin bios-microvm.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
> vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \
> vgabios-ramfb.bin vgabios-bochs-display.bin vgabios-ati.bin \
> ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: install bios-microvm like other binary blobs
2019-11-02 11:43 [PATCH] Makefile: install bios-microvm like other binary blobs Philippe Mathieu-Daudé
2019-11-02 16:57 ` Stefano Garzarella
@ 2019-11-04 13:08 ` Sergio Lopez
2019-11-12 9:32 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Sergio Lopez @ 2019-11-04 13:08 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, Bruce Rogers, Michael S . Tsirkin, qemu-devel,
Stefano Garzarella
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> From: Bruce Rogers <brogers@suse.com>
>
> Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add
> it to the list of blobs being installed.
> Add it to the list of BLOBS that get installed.
>
> Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot) as binary"
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> [PMD: Reworded description]
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index bd6376d295..755aa6c5f5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -770,7 +770,7 @@ de-ch es fo fr-ca hu ja mk pt sl tr \
> bepo cz
>
> ifdef INSTALL_BLOBS
> -BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
> +BLOBS=bios.bin bios-256k.bin bios-microvm.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
> vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \
> vgabios-ramfb.bin vgabios-bochs-display.bin vgabios-ati.bin \
> ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \
Thanks.
Reviewed-by: Sergio Lopez <slp@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: install bios-microvm like other binary blobs
2019-11-02 11:43 [PATCH] Makefile: install bios-microvm like other binary blobs Philippe Mathieu-Daudé
2019-11-02 16:57 ` Stefano Garzarella
2019-11-04 13:08 ` Sergio Lopez
@ 2019-11-12 9:32 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-11-12 9:32 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, Sergio Lopez
Cc: qemu-trivial, Michael S . Tsirkin, Stefano Garzarella, Bruce Rogers
Le 02/11/2019 à 12:43, Philippe Mathieu-Daudé a écrit :
> From: Bruce Rogers <brogers@suse.com>
>
> Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add
> it to the list of blobs being installed.
> Add it to the list of BLOBS that get installed.
>
> Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot) as binary"
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> [PMD: Reworded description]
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index bd6376d295..755aa6c5f5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -770,7 +770,7 @@ de-ch es fo fr-ca hu ja mk pt sl tr \
> bepo cz
>
> ifdef INSTALL_BLOBS
> -BLOBS=bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
> +BLOBS=bios.bin bios-256k.bin bios-microvm.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
> vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin \
> vgabios-ramfb.bin vgabios-bochs-display.bin vgabios-ati.bin \
> ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin \
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-12 9:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-02 11:43 [PATCH] Makefile: install bios-microvm like other binary blobs Philippe Mathieu-Daudé
2019-11-02 16:57 ` Stefano Garzarella
2019-11-04 13:08 ` Sergio Lopez
2019-11-12 9:32 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).