From: Peter Krempa <pkrempa@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: kwolf@redhat.com, mlevitsk@redhat.com, qemu-block@nongnu.org,
libvir-list@redhat.com, jsnow@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, dinechin@redhat.com, den@openvz.org,
mreitz@redhat.com, philmd@redhat.com
Subject: Re: [PATCH v2 1/2] qapi: add filter-node-name option to drive-mirror
Date: Fri, 8 Nov 2019 14:30:27 +0100 [thread overview]
Message-ID: <20191108133027.GI9577@angien.pipo.sk> (raw)
In-Reply-To: <20191108101655.10611-2-vsementsov@virtuozzo.com>
On Fri, Nov 08, 2019 at 13:16:54 +0300, Vladimir Sementsov-Ogievskiy wrote:
> To correspond to blockdev-mirror command and make it possible to
> deprecate implicit filters in the next commit.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> qapi/block-core.json | 7 +++++++
> blockdev.c | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index aa97ee2641..93530d3a13 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1992,6 +1992,12 @@
> # @on-target-error: the action to take on an error on the target,
> # default 'report' (no limitations, since this applies to
> # a different block device than @device).
> +#
> +# @filter-node-name: the node name that should be assigned to the
> +# filter driver that the mirror job inserts into the graph
> +# above @device. If this option is not given, a node name is
> +# autogenerated. (Since: 4.2)
> +#
Speaking for libvirt and based on what I've responded to patch 2 there's
no value in adding this parameter for libvirt's use.
This also kind of means that drive-mirror can be deprecated together
with deprecating -drive.
next prev parent reply other threads:[~2019-11-08 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 10:16 [PATCH v2 0/2] Deprecate implicit filters Vladimir Sementsov-Ogievskiy
2019-11-08 10:16 ` [PATCH v2 1/2] qapi: add filter-node-name option to drive-mirror Vladimir Sementsov-Ogievskiy
2019-11-08 13:30 ` Peter Krempa [this message]
2019-11-08 10:16 ` [PATCH v2 2/2] qapi: deprecate implicit filters Vladimir Sementsov-Ogievskiy
2019-11-08 13:27 ` Peter Krempa
2019-11-08 13:56 ` Vladimir Sementsov-Ogievskiy
2019-11-08 14:18 ` Peter Krempa
2019-11-08 12:00 ` [PATCH v2 0/2] Deprecate " no-reply
2019-11-08 12:17 ` Vladimir Sementsov-Ogievskiy
2019-11-08 13:06 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108133027.GI9577@angien.pipo.sk \
--to=pkrempa@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=dinechin@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).