From: Balamuruhan S <bala24@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: david@gibson.dropbear.id.au, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, groug@kaod.org
Subject: Re: [PATCH 1/5] hw/ppc/pnv: incorrect homer and occ common area size
Date: Thu, 21 Nov 2019 14:02:28 +0530 [thread overview]
Message-ID: <20191121083228.GA14854@dhcp-9-120-236-104.in.ibm.com> (raw)
In-Reply-To: <15b1557e-4bb4-434e-2554-99cd475150a4@kaod.org>
On Wed, Nov 20, 2019 at 08:13:50AM +0100, Cédric Le Goater wrote:
> On 19/11/2019 18:50, Balamuruhan S wrote:
> > Homer size is 4MB and OCC common area size is 8MB, but currently
> > it is assigned with bar mask value. Also pass on the occ sram
> > size 3 bits right shifted to initialize the size appropriately.
> >
> > Signed-off-by: Cédric Le Goater <clg@kaod.org>
> > Signed-off-by: Balamuruhan S <bala24@linux.ibm.com>
> > ---
> > hw/ppc/pnv_occ.c | 2 +-
> > include/hw/ppc/pnv.h | 8 ++++----
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/hw/ppc/pnv_occ.c b/hw/ppc/pnv_occ.c
> > index 785653bb67..05c51c9de0 100644
> > --- a/hw/ppc/pnv_occ.c
> > +++ b/hw/ppc/pnv_occ.c
> > @@ -276,7 +276,7 @@ static void pnv_occ_realize(DeviceState *dev, Error **errp)
> >
> > /* XScom region for OCC SRAM registers */
> > pnv_xscom_region_init(&occ->sram_regs, OBJECT(dev), poc->sram_ops,
> > - occ, "occ-common-area", poc->sram_size);
> > + occ, "occ-common-area", poc->sram_size >> 3);
>
> the OCC common area seems to be accessed through MMIO also. Not only XSCOM.
>
> In skiboot :
>
> bool occ_sensors_init(void)
> {
> ...
> occ_sensor_base = chip->occ_common_base + OCC_SENSOR_DATA_BLOCK_OFFSET;
> ...
> }
>
> OCC would need two regions. One for the XSCOM access and one for the MMIO.
>
> > }
Okay, I will follow it.
> >
> > static void pnv_occ_class_init(ObjectClass *klass, void *data)
> > diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h
> > index 0b4c722e6b..e9ed8b928a 100644
> > --- a/include/hw/ppc/pnv.h
> > +++ b/include/hw/ppc/pnv.h
> > @@ -203,12 +203,12 @@ void pnv_bmc_powerdown(IPMIBmc *bmc);
> > #define PNV_XSCOM_BASE(chip) \
> > (0x0003fc0000000000ull + ((uint64_t)(chip)->chip_id) * PNV_XSCOM_SIZE)
> >
> > -#define PNV_OCC_COMMON_AREA_SIZE 0x0000000000700000ull
> > +#define PNV_OCC_COMMON_AREA_SIZE 0x0000000000800000ull
>
> ok. These are the BAR sizes. Can we deduce the barmask from the size ?
Correct! we can do that, will make the respective change.
>
>
> > #define PNV_OCC_COMMON_AREA(chip) \
> > (0x7fff800000ull + ((uint64_t)PNV_CHIP_INDEX(chip) * \
> > PNV_OCC_COMMON_AREA_SIZE))
> >
> > -#define PNV_HOMER_SIZE 0x0000000000300000ull
> > +#define PNV_HOMER_SIZE 0x0000000000400000ull
> > #define PNV_HOMER_BASE(chip) \
> > (0x7ffd800000ull + ((uint64_t)PNV_CHIP_INDEX(chip)) * PNV_HOMER_SIZE)
> >
> > @@ -271,12 +271,12 @@ void pnv_bmc_powerdown(IPMIBmc *bmc);
> > #define PNV9_XSCOM_SIZE 0x0000000400000000ull
> > #define PNV9_XSCOM_BASE(chip) PNV9_CHIP_BASE(chip, 0x00603fc00000000ull)
> >
> > -#define PNV9_OCC_COMMON_AREA_SIZE 0x0000000000700000ull
> > +#define PNV9_OCC_COMMON_AREA_SIZE 0x0000000000800000ull
> > #define PNV9_OCC_COMMON_AREA(chip) \
> > (0x203fff800000ull + ((uint64_t)PNV_CHIP_INDEX(chip) * \
> > PNV9_OCC_COMMON_AREA_SIZE))
> >
> > -#define PNV9_HOMER_SIZE 0x0000000000300000ull
> > +#define PNV9_HOMER_SIZE 0x0000000000400000ull
> > #define PNV9_HOMER_BASE(chip) \
> > (0x203ffd800000ull + ((uint64_t)PNV_CHIP_INDEX(chip)) * PNV9_HOMER_SIZE)
> > #endif /* PPC_PNV_H */
> >
>
next prev parent reply other threads:[~2019-11-21 8:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 17:50 [PATCH 0/5] ppc/pnv: fix Homer/Occ mappings on multichip systems Balamuruhan S
2019-11-19 17:50 ` [PATCH 1/5] hw/ppc/pnv: incorrect homer and occ common area size Balamuruhan S
2019-11-20 7:13 ` Cédric Le Goater
2019-11-21 8:32 ` Balamuruhan S [this message]
2019-11-19 17:50 ` [PATCH 2/5] hw/ppc/pnv_xscom: PBA bar mask values are incorrect with homer/occ sizes Balamuruhan S
2019-11-19 21:56 ` David Gibson
2019-11-19 22:00 ` David Gibson
2019-11-19 22:02 ` David Gibson
2019-11-20 3:01 ` Balamuruhan S
2019-11-20 3:16 ` Balamuruhan S
2019-11-20 7:59 ` Greg Kurz
2019-11-21 8:34 ` Balamuruhan S
2019-11-20 7:18 ` Cédric Le Goater
2019-11-21 8:37 ` Balamuruhan S
2019-11-19 17:50 ` [PATCH 3/5] hw/ppc/pnv_xscom: Power8 occ common area is in PBA BAR 3 Balamuruhan S
2019-11-20 7:20 ` Cédric Le Goater
2019-11-21 8:39 ` Balamuruhan S
2019-11-19 17:50 ` [PATCH 4/5] hw/ppc/pnv_xscom: occ common area to be mapped only once Balamuruhan S
2019-11-20 7:30 ` Cédric Le Goater
2019-11-21 8:49 ` Balamuruhan S
2019-11-19 17:50 ` [PATCH 5/5] hw/ppc/pnv_xscom: add PBA BARs for Power8 slw image Balamuruhan S
2019-11-20 7:31 ` Cédric Le Goater
2019-11-21 8:50 ` Balamuruhan S
2019-11-20 7:46 ` [PATCH 0/5] ppc/pnv: fix Homer/Occ mappings on multichip systems Cédric Le Goater
2019-11-21 9:11 ` Balamuruhan S
2019-11-21 10:00 ` Cédric Le Goater
2019-11-22 16:41 ` Balamuruhan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121083228.GA14854@dhcp-9-120-236-104.in.ibm.com \
--to=bala24@linux.ibm.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).