* [PULL 0/2] Block patches for 4.2.0-rc3
@ 2019-11-26 13:29 Max Reitz
2019-11-26 13:29 ` [PULL 1/2] block/qcow2-bitmap: fix bitmap migration Max Reitz
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Max Reitz @ 2019-11-26 13:29 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, Peter Maydell, qemu-devel, Max Reitz
The following changes since commit 4ecc984210ca1bf508a96a550ec8a93a5f833f6c:
Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.2-rc3' into staging (2019-11-26 12:36:40 +0000)
are available in the Git repository at:
https://github.com/XanClic/qemu.git tags/pull-block-2019-11-26
for you to fetch changes up to d8130f4c420acafbf15a59436fa47199b82dc00e:
iotests: add new test cases to bitmap migration (2019-11-26 14:18:01 +0100)
----------------------------------------------------------------
Block patches for 4.2.0-rc3:
- Fix for shared storage migration with persistent dirty bitmaps
----------------------------------------------------------------
Vladimir Sementsov-Ogievskiy (2):
block/qcow2-bitmap: fix bitmap migration
iotests: add new test cases to bitmap migration
block/qcow2-bitmap.c | 21 ++++++++++++++++++++-
tests/qemu-iotests/169 | 22 +++++++++++++++-------
tests/qemu-iotests/169.out | 4 ++--
3 files changed, 37 insertions(+), 10 deletions(-)
--
2.23.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PULL 1/2] block/qcow2-bitmap: fix bitmap migration
2019-11-26 13:29 [PULL 0/2] Block patches for 4.2.0-rc3 Max Reitz
@ 2019-11-26 13:29 ` Max Reitz
2019-11-26 13:29 ` [PULL 2/2] iotests: add new test cases to " Max Reitz
2019-11-26 18:37 ` [PULL 0/2] Block patches for 4.2.0-rc3 Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Max Reitz @ 2019-11-26 13:29 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, Peter Maydell, qemu-devel, Max Reitz
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Fix bitmap migration with dirty-bitmaps capability enabled and shared
storage. We should ignore IN_USE bitmaps in the image on target, when
migrating bitmaps through migration channel, see new comment below.
Fixes: 74da6b943565c451
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20191125125229.13531-2-vsementsov@virtuozzo.com
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/qcow2-bitmap.c | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 809bbc5d20..8abaf632fc 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -988,7 +988,26 @@ bool qcow2_load_dirty_bitmaps(BlockDriverState *bs, Error **errp)
}
QSIMPLEQ_FOREACH(bm, bm_list, entry) {
- BdrvDirtyBitmap *bitmap = load_bitmap(bs, bm, errp);
+ BdrvDirtyBitmap *bitmap;
+
+ if ((bm->flags & BME_FLAG_IN_USE) &&
+ bdrv_find_dirty_bitmap(bs, bm->name))
+ {
+ /*
+ * We already have corresponding BdrvDirtyBitmap, and bitmap in the
+ * image is marked IN_USE. Firstly, this state is valid, no reason
+ * to consider existing BdrvDirtyBitmap to be bad. Secondly it's
+ * absolutely possible, when we do migration with shared storage
+ * with dirty-bitmaps capability enabled: if the bitmap was loaded
+ * from this storage before migration start, the storage will
+ * of-course contain IN_USE outdated version of the bitmap, and we
+ * should not load it on migration target, as we already have this
+ * bitmap, being migrated.
+ */
+ continue;
+ }
+
+ bitmap = load_bitmap(bs, bm, errp);
if (bitmap == NULL) {
goto fail;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PULL 2/2] iotests: add new test cases to bitmap migration
2019-11-26 13:29 [PULL 0/2] Block patches for 4.2.0-rc3 Max Reitz
2019-11-26 13:29 ` [PULL 1/2] block/qcow2-bitmap: fix bitmap migration Max Reitz
@ 2019-11-26 13:29 ` Max Reitz
2019-11-26 18:37 ` [PULL 0/2] Block patches for 4.2.0-rc3 Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Max Reitz @ 2019-11-26 13:29 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, Peter Maydell, qemu-devel, Max Reitz
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Add optional pre-shutdown: shutdown/launch vm before migration. This
leads to storing persistent bitmap to the storage, which breaks
migration with dirty-bitmaps capability enabled and shared storage
until fixed by previous commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20191125125229.13531-3-vsementsov@virtuozzo.com
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/169 | 22 +++++++++++++++-------
tests/qemu-iotests/169.out | 4 ++--
2 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/169
index 8c204caf20..9656a7f620 100755
--- a/tests/qemu-iotests/169
+++ b/tests/qemu-iotests/169
@@ -134,7 +134,7 @@ class TestDirtyBitmapMigration(iotests.QMPTestCase):
self.check_bitmap(self.vm_a, sha256 if persistent else False)
def do_test_migration(self, persistent, migrate_bitmaps, online,
- shared_storage):
+ shared_storage, pre_shutdown):
granularity = 512
# regions = ((start, count), ...)
@@ -142,15 +142,13 @@ class TestDirtyBitmapMigration(iotests.QMPTestCase):
(0xf0000, 0x10000),
(0xa0201, 0x1000))
- should_migrate = migrate_bitmaps or persistent and shared_storage
+ should_migrate = \
+ (migrate_bitmaps and (persistent or not pre_shutdown)) or \
+ (persistent and shared_storage)
mig_caps = [{'capability': 'events', 'state': True}]
if migrate_bitmaps:
mig_caps.append({'capability': 'dirty-bitmaps', 'state': True})
- result = self.vm_a.qmp('migrate-set-capabilities',
- capabilities=mig_caps)
- self.assert_qmp(result, 'return', {})
-
self.vm_b.add_incoming(incoming_cmd if online else "defer")
self.vm_b.add_drive(disk_a if shared_storage else disk_b)
@@ -166,6 +164,14 @@ class TestDirtyBitmapMigration(iotests.QMPTestCase):
self.vm_a.hmp_qemu_io('drive0', 'write %d %d' % r)
sha256 = self.get_bitmap_hash(self.vm_a)
+ if pre_shutdown:
+ self.vm_a.shutdown()
+ self.vm_a.launch()
+
+ result = self.vm_a.qmp('migrate-set-capabilities',
+ capabilities=mig_caps)
+ self.assert_qmp(result, 'return', {})
+
result = self.vm_a.qmp('migrate', uri=mig_cmd)
while True:
event = self.vm_a.event_wait('MIGRATION')
@@ -210,11 +216,13 @@ def inject_test_case(klass, name, method, *args, **kwargs):
mc = operator.methodcaller(method, *args, **kwargs)
setattr(klass, 'test_' + method + name, lambda self: mc(self))
-for cmb in list(itertools.product((True, False), repeat=4)):
+for cmb in list(itertools.product((True, False), repeat=5)):
name = ('_' if cmb[0] else '_not_') + 'persistent_'
name += ('_' if cmb[1] else '_not_') + 'migbitmap_'
name += '_online' if cmb[2] else '_offline'
name += '_shared' if cmb[3] else '_nonshared'
+ if (cmb[4]):
+ name += '__pre_shutdown'
inject_test_case(TestDirtyBitmapMigration, name, 'do_test_migration',
*list(cmb))
diff --git a/tests/qemu-iotests/169.out b/tests/qemu-iotests/169.out
index 3a89159833..5c26d15c0d 100644
--- a/tests/qemu-iotests/169.out
+++ b/tests/qemu-iotests/169.out
@@ -1,5 +1,5 @@
-....................
+....................................
----------------------------------------------------------------------
-Ran 20 tests
+Ran 36 tests
OK
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PULL 0/2] Block patches for 4.2.0-rc3
2019-11-26 13:29 [PULL 0/2] Block patches for 4.2.0-rc3 Max Reitz
2019-11-26 13:29 ` [PULL 1/2] block/qcow2-bitmap: fix bitmap migration Max Reitz
2019-11-26 13:29 ` [PULL 2/2] iotests: add new test cases to " Max Reitz
@ 2019-11-26 18:37 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2019-11-26 18:37 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, QEMU Developers, Qemu-block
On Tue, 26 Nov 2019 at 13:29, Max Reitz <mreitz@redhat.com> wrote:
>
> The following changes since commit 4ecc984210ca1bf508a96a550ec8a93a5f833f6c:
>
> Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.2-rc3' into staging (2019-11-26 12:36:40 +0000)
>
> are available in the Git repository at:
>
> https://github.com/XanClic/qemu.git tags/pull-block-2019-11-26
>
> for you to fetch changes up to d8130f4c420acafbf15a59436fa47199b82dc00e:
>
> iotests: add new test cases to bitmap migration (2019-11-26 14:18:01 +0100)
>
> ----------------------------------------------------------------
> Block patches for 4.2.0-rc3:
> - Fix for shared storage migration with persistent dirty bitmaps
>
> ----------------------------------------------------------------
> Vladimir Sementsov-Ogievskiy (2):
> block/qcow2-bitmap: fix bitmap migration
> iotests: add new test cases to bitmap migration
>
> block/qcow2-bitmap.c | 21 ++++++++++++++++++++-
> tests/qemu-iotests/169 | 22 +++++++++++++++-------
> tests/qemu-iotests/169.out | 4 ++--
> 3 files changed, 37 insertions(+), 10 deletions(-)
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-26 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 13:29 [PULL 0/2] Block patches for 4.2.0-rc3 Max Reitz
2019-11-26 13:29 ` [PULL 1/2] block/qcow2-bitmap: fix bitmap migration Max Reitz
2019-11-26 13:29 ` [PULL 2/2] iotests: add new test cases to " Max Reitz
2019-11-26 18:37 ` [PULL 0/2] Block patches for 4.2.0-rc3 Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).