From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Scott Cheloha <cheloha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH v2 1/2] migration: add savevm_state_handler_remove()
Date: Wed, 4 Dec 2019 16:43:05 +0000 [thread overview]
Message-ID: <20191204164305.GK3325@work-vm> (raw)
In-Reply-To: <20191017205953.13122-2-cheloha@linux.vnet.ibm.com>
* Scott Cheloha (cheloha@linux.vnet.ibm.com) wrote:
> Create a function to abstract common logic needed when removing a
> SaveStateEntry element from the savevm_state.handlers queue.
>
> For now we just remove the element. Soon it will involve additional
> cleanup.
>
> Signed-off-by: Scott Cheloha <cheloha@linux.vnet.ibm.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/savevm.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 8d95e261f6..b2e3b7222a 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -725,6 +725,11 @@ static void savevm_state_handler_insert(SaveStateEntry *nse)
> }
> }
>
> +static void savevm_state_handler_remove(SaveStateEntry *se)
> +{
> + QTAILQ_REMOVE(&savevm_state.handlers, se, entry);
> +}
> +
> /* TODO: Individual devices generally have very little idea about the rest
> of the system, so instance_id should be removed/replaced.
> Meanwhile pass -1 as instance_id if you do not already have a clearly
> @@ -777,7 +782,7 @@ void unregister_savevm(DeviceState *dev, const char *idstr, void *opaque)
>
> QTAILQ_FOREACH_SAFE(se, &savevm_state.handlers, entry, new_se) {
> if (strcmp(se->idstr, id) == 0 && se->opaque == opaque) {
> - QTAILQ_REMOVE(&savevm_state.handlers, se, entry);
> + savevm_state_handler_remove(se);
> g_free(se->compat);
> g_free(se);
> }
> @@ -841,7 +846,7 @@ void vmstate_unregister(DeviceState *dev, const VMStateDescription *vmsd,
>
> QTAILQ_FOREACH_SAFE(se, &savevm_state.handlers, entry, new_se) {
> if (se->vmsd == vmsd && se->opaque == opaque) {
> - QTAILQ_REMOVE(&savevm_state.handlers, se, entry);
> + savevm_state_handler_remove(se);
> g_free(se->compat);
> g_free(se);
> }
> --
> 2.23.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-12-04 16:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 20:59 [PATCH v2 0/2] migration: faster savevm_state_handler_insert() Scott Cheloha
2019-10-17 20:59 ` [PATCH v2 1/2] migration: add savevm_state_handler_remove() Scott Cheloha
2019-12-04 16:43 ` Dr. David Alan Gilbert [this message]
2020-01-08 19:07 ` Juan Quintela
2019-10-17 20:59 ` [PATCH v2 2/2] migration: savevm_state_handler_insert: constant-time element insertion Scott Cheloha
2019-10-18 8:16 ` Dr. David Alan Gilbert
2019-10-18 8:34 ` Laurent Vivier
2019-10-18 9:43 ` Dr. David Alan Gilbert
2019-10-18 16:38 ` Michael Roth
2019-10-18 17:26 ` Dr. David Alan Gilbert
2019-10-21 7:33 ` David Gibson
2019-10-19 10:12 ` David Gibson
2019-10-21 8:14 ` Dr. David Alan Gilbert
2019-11-20 21:48 ` Scott Cheloha
2019-12-04 16:49 ` Dr. David Alan Gilbert
2019-12-04 22:28 ` David Gibson
2019-12-04 16:47 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204164305.GK3325@work-vm \
--to=dgilbert@redhat.com \
--cc=cheloha@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).