* [PATCH-for-5.0] hw/alpha/dp264: Use the DECchip Tulip network interface
@ 2019-12-04 23:39 Philippe Mathieu-Daudé
2019-12-05 20:38 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-04 23:39 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé,
Emilio G . Cota, Sven Schnelle, Richard Henderson
Commit 34ea023d4b9 introduced the Tulip PCI NIC.
Since this better models the DP264 hardware, use it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/alpha/dp264.c | 4 ++--
hw/alpha/Kconfig | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
index 51b3cf7a61..4424551ba1 100644
--- a/hw/alpha/dp264.c
+++ b/hw/alpha/dp264.c
@@ -85,9 +85,9 @@ static void clipper_init(MachineState *machine)
/* VGA setup. Don't bother loading the bios. */
pci_vga_init(pci_bus);
- /* Network setup. e1000 is good enough, failing Tulip support. */
+ /* Network setup */
for (i = 0; i < nb_nics; i++) {
- pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL);
+ pci_nic_init_nofail(&nd_table[i], pci_bus, "tulip", NULL);
}
/* 2 82C37 (dma) */
diff --git a/hw/alpha/Kconfig b/hw/alpha/Kconfig
index 15c59ff264..552e6a4c23 100644
--- a/hw/alpha/Kconfig
+++ b/hw/alpha/Kconfig
@@ -2,7 +2,7 @@ config DP264
bool
imply PCI_DEVICES
imply TEST_DEVICES
- imply E1000_PCI
+ imply TULIP
select I82374
select I8254
select I8259
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH-for-5.0] hw/alpha/dp264: Use the DECchip Tulip network interface
2019-12-04 23:39 [PATCH-for-5.0] hw/alpha/dp264: Use the DECchip Tulip network interface Philippe Mathieu-Daudé
@ 2019-12-05 20:38 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2019-12-05 20:38 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Emilio G . Cota, Sven Schnelle, Richard Henderson
On 12/4/19 3:39 PM, Philippe Mathieu-Daudé wrote:
> Commit 34ea023d4b9 introduced the Tulip PCI NIC.
> Since this better models the DP264 hardware, use it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/alpha/dp264.c | 4 ++--
> hw/alpha/Kconfig | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
I've tested that a 5.4 kernel built for alpha is able to communicate via this
driver model.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-05 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 23:39 [PATCH-for-5.0] hw/alpha/dp264: Use the DECchip Tulip network interface Philippe Mathieu-Daudé
2019-12-05 20:38 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).