[GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

[GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e:

  Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20191206

for you to fetch changes up to e53a5569a27066a4f2f36ae368c728ab6c514352:

  pseries: Update SLOF firmware image (2019-12-06 12:20:42 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 928552 -> 931032 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

On Fri, Dec 06, 2019 at 12:25:29PM +1100, Alexey Kardashevskiy wrote:
> The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e:
> 
>   Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000)
> 
> are available in the Git repository at:
> 
>   git@github.com:aik/qemu.git tags/qemu-slof-20191206
> 
> for you to fetch changes up to e53a5569a27066a4f2f36ae368c728ab6c514352:
> 
>   pseries: Update SLOF firmware image (2019-12-06 12:20:42 +1100)

Thanks, merged into ppc-for-4.2, and I'm preparing a PR for Peter
right now.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

[Peter Maydell]

On Fri, 6 Dec 2019 at 01:26, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> *** Note: this is not for master, this is for pseries

The way to say this in a way that works with my filters for
handling pullrequests is to say "not for master" and
have the subject tag be "[PULL SUBSYSTEM name-of-subsystem]"
(see https://wiki.qemu.org/Contribute/SubmitAPullRequest
last item).

It's not a big deal, but if you use the right magic words
my email filters can skip pull requests not targeted at
master.

thanks
-- PMM

[GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 7cff77c24d8f5e558cef3538a44044d66aa225a5:

  spapr: Move SpaprIrq::nr_xirqs to SpaprMachineClass (2019-10-16 12:01:41 +1100)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20191022

for you to fetch changes up to 8e59d05f71ae783e12a8eb7eb582e0a86ba3d6dc:

  pseries: Update SLOF firmware image (2019-10-22 15:05:36 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 930640 -> 928552 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

On Tue, Oct 22, 2019 at 03:09:45PM +1100, Alexey Kardashevskiy wrote:
> The following changes since commit 7cff77c24d8f5e558cef3538a44044d66aa225a5:
> 
>   spapr: Move SpaprIrq::nr_xirqs to SpaprMachineClass (2019-10-16 12:01:41 +1100)
> 
> are available in the Git repository at:
> 
>   git@github.com:aik/qemu.git tags/qemu-slof-20191022
> 
> for you to fetch changes up to 8e59d05f71ae783e12a8eb7eb582e0a86ba3d6dc:
> 
>   pseries: Update SLOF firmware image (2019-10-22 15:05:36 +1100)

Applied to ppc-for-4.2, thanks.

> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>       pseries: Update SLOF firmware image
> 
>  pc-bios/README   |   2 +-
>  pc-bios/slof.bin | Bin 930640 -> 928552 bytes
>  roms/SLOF        |   2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

[Philippe Mathieu-Daudé]

Hi Alekey,

On 10/22/19 6:09 AM, Alexey Kardashevskiy wrote:
> The following changes since commit 7cff77c24d8f5e558cef3538a44044d66aa225a5:
> 
>    spapr: Move SpaprIrq::nr_xirqs to SpaprMachineClass (2019-10-16 12:01:41 +1100)
> 
> are available in the Git repository at:
> 
>    git@github.com:aik/qemu.git tags/qemu-slof-20191022
> 
> for you to fetch changes up to 8e59d05f71ae783e12a8eb7eb582e0a86ba3d6dc:
> 
>    pseries: Update SLOF firmware image (2019-10-22 15:05:36 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>        pseries: Update SLOF firmware image
> 
>   pc-bios/README   |   2 +-
>   pc-bios/slof.bin | Bin 930640 -> 928552 bytes
>   roms/SLOF        |   2 +-
>   3 files changed, 2 insertions(+), 2 deletions(-)

Looking at commit 8e59d05f71ae which update the SLOF submodule,
in your future updates can you include the git shortlog in the
commit description?

Simply:

   $ git shortlog qemu-slof-20190911..qemu-slof-20191022
   Alexey Kardashevskiy (3):
         pci: Align PCI node names with QEMU
         libusb: Fix compiler warnings with gcc9
         version: update to 20191022

   Thomas Huth (1):
         ipv6: Fix gcc9 warnings

Thanks,

Phil.

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 22/10/2019 19:49, Philippe Mathieu-Daudé wrote:
> Hi Alekey,
> 
> On 10/22/19 6:09 AM, Alexey Kardashevskiy wrote:
>> The following changes since commit 7cff77c24d8f5e558cef3538a44044d66aa225a5:
>>
>>    spapr: Move SpaprIrq::nr_xirqs to SpaprMachineClass (2019-10-16 12:01:41 +1100)
>>
>> are available in the Git repository at:
>>
>>    git@github.com:aik/qemu.git tags/qemu-slof-20191022
>>
>> for you to fetch changes up to 8e59d05f71ae783e12a8eb7eb582e0a86ba3d6dc:
>>
>>    pseries: Update SLOF firmware image (2019-10-22 15:05:36 +1100)
>>
>> ----------------------------------------------------------------
>> Alexey Kardashevskiy (1):
>>        pseries: Update SLOF firmware image
>>
>>   pc-bios/README   |   2 +-
>>   pc-bios/slof.bin | Bin 930640 -> 928552 bytes
>>   roms/SLOF        |   2 +-
>>   3 files changed, 2 insertions(+), 2 deletions(-)
> 
> Looking at commit 8e59d05f71ae which update the SLOF submodule,
> in your future updates can you include the git shortlog in the
> commit description?


I guess I can do that.

Is there an easy way to combine

git -C roms/SLOF shortlog qemu-slof-20190911..qemu-slof-20191022
git commit
?

After
export MYDIFF=$(git -C roms/SLOF shortlog qemu-slof-20190911..qemu-slof-20191022)
$MYDIFF looses formatting (drops \r) so it is no good for a commit log.


> 
> Simply:
> 
>   $ git shortlog qemu-slof-20190911..qemu-slof-20191022
>   Alexey Kardashevskiy (3):
>         pci: Align PCI node names with QEMU
>         libusb: Fix compiler warnings with gcc9
>         version: update to 20191022
> 
>   Thomas Huth (1):
>         ipv6: Fix gcc9 warnings
> 
> Thanks,
> 
> Phil.
> 

-- 
Alexey

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

[Eric Blake]

On 10/22/19 7:04 PM, Alexey Kardashevskiy wrote:

>> Looking at commit 8e59d05f71ae which update the SLOF submodule,
>> in your future updates can you include the git shortlog in the
>> commit description?
> 
> 
> I guess I can do that.
> 
> Is there an easy way to combine
> 
> git -C roms/SLOF shortlog qemu-slof-20190911..qemu-slof-20191022
> git commit
> ?
> 

git -C roms/SLOF shortlog qemu-slof-20190911..qemu-slof-20191022 \
   | git commit -F -


You can get something similar with less typing as:

git sumodule summary | git commit -F -


> After
> export MYDIFF=$(git -C roms/SLOF shortlog qemu-slof-20190911..qemu-slof-20191022)
> $MYDIFF looses formatting (drops \r) so it is no good for a commit log.

Potentially insufficient quoting there.

POSIX says that:

export foo=$(printf 'a  b')

can result in either of the following scenarios:

both 'foo' and 'b' are exported, foo with the value 'a', b with its 
existing value (if any, otherwise empty); bash uses this behavior [in 
POSIX terms, bash treats arguments after 'export' in an assignment context]

just 'foo' is exported, with value 'a  b'; dash uses this behavior

If you want to guarantee the latter (that is, that the shell does not 
split on whitespace or perform globbing), you have to either split it 
into two commands (so that your unquoted use of $() is guaranteed to 
occur in assignment context, without worrying whether 'export' 
introduces those contexts):

export foo
foo=$(...)

or use quoting:

export foo="$(...)"

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org