From: Andrew Jones <drjones@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: peter.maydell@linaro.org, bijan.mottahedeh@oracle.com,
David Hildenbrand <david@redhat.com>,
maz@kernel.org, Richard Henderson <rth@twiddle.net>,
Cornelia Huck <cohuck@redhat.com>,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"open list:S390 TCG CPUs" <qemu-s390x@nongnu.org>,
qemu-arm@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
guoheyi@huawei.com, "open list:sPAPR" <qemu-ppc@nongnu.org>,
msys.mizuma@gmail.com, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [RFC PATCH v2 1/5] hw: add compat machines for 5.0
Date: Fri, 13 Dec 2019 08:10:40 +0100 [thread overview]
Message-ID: <20191213071040.mc52d5mnezedyc54@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20191212192419.GB498046@habkost.net>
On Thu, Dec 12, 2019 at 04:24:19PM -0300, Eduardo Habkost wrote:
> On Thu, Dec 12, 2019 at 06:33:16PM +0100, Andrew Jones wrote:
> > Add 5.0 machine types for arm/i440fx/q35/s390x/spapr.
> >
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> >
> > ---
> >
> > Hi Eduardo,
> >
> > If we need to do something special for i440fx and q35, as
> > 9aec2e52ce9d ("hw: add compat machines for 4.2") implies, then
> > I'll need guidance as to what.
>
> Keeping default_cpu_version==1 in pc-*-5.0 (like you did) is
> correct.
>
> However, you might want to use Cornelia's patch (which is
> probably already queued in the s390 tree) instead:
> https://patchew.org/QEMU/20191112104811.30323-1-cohuck@redhat.com
>
Drat. I did search the mailing list for a posting from someone else first,
but I made the mistake of searching subjects for 'machine type' rather
than 'compat machines'. Certainly we should use Cornelia's. Mine is
just noise.
Thank you reviewers, and sorry for the duplicated effort.
drew
next prev parent reply other threads:[~2019-12-13 7:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 17:33 [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time Andrew Jones
2019-12-12 17:33 ` [RFC PATCH v2 1/5] hw: add compat machines for 5.0 Andrew Jones
2019-12-12 18:27 ` David Hildenbrand
2019-12-12 19:24 ` Eduardo Habkost
2019-12-13 7:10 ` Andrew Jones [this message]
2019-12-13 5:00 ` David Gibson
2019-12-12 17:33 ` [RFC PATCH v2 2/5] target/arm/kvm64: kvm64 cpus have timer registers Andrew Jones
2019-12-12 17:33 ` [RFC PATCH v2 3/5] target/arm/kvm: Implement virtual time adjustment Andrew Jones
2019-12-16 15:14 ` Peter Maydell
2019-12-16 15:40 ` Peter Maydell
2019-12-16 16:43 ` Andrew Jones
2019-12-16 18:06 ` Peter Maydell
2019-12-19 14:30 ` Andrew Jones
2020-01-20 9:40 ` Andrew Jones
2019-12-16 16:36 ` Andrew Jones
2019-12-12 17:33 ` [RFC PATCH v2 4/5] tests/arm-cpu-features: Check feature default values Andrew Jones
2019-12-12 17:33 ` [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property Andrew Jones
2019-12-16 15:06 ` Peter Maydell
2019-12-16 16:52 ` Andrew Jones
2019-12-16 16:57 ` Peter Maydell
2020-01-20 10:31 ` Andrew Jones
2020-02-06 12:08 ` Philippe Mathieu-Daudé
2020-02-06 12:40 ` Andrew Jones
2020-02-06 22:46 ` Philippe Mathieu-Daudé
2020-02-07 7:37 ` Andrew Jones
2019-12-16 15:33 ` [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time Peter Maydell
2019-12-16 15:44 ` Peter Maydell
2020-01-20 13:45 ` Andrew Jones
2019-12-16 16:18 ` Marc Zyngier
2019-12-16 16:59 ` Andrew Jones
2019-12-16 17:05 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213071040.mc52d5mnezedyc54@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=bijan.mottahedeh@oracle.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=guoheyi@huawei.com \
--cc=maz@kernel.org \
--cc=mst@redhat.com \
--cc=msys.mizuma@gmail.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).