From: Andrew Jones <drjones@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
bijan.mottahedeh@oracle.com,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>, Heyi Guo <guoheyi@huawei.com>,
msys.mizuma@gmail.com
Subject: Re: [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time
Date: Mon, 16 Dec 2019 17:59:20 +0100 [thread overview]
Message-ID: <20191216165920.qsx7ufviir74tbkl@kamzik.brq.redhat.com> (raw)
In-Reply-To: <4cb9bcfd47dff57c9ae6bb92bae87589@www.loen.fr>
On Mon, Dec 16, 2019 at 04:18:23PM +0000, Marc Zyngier wrote:
> On 2019-12-16 15:33, Peter Maydell wrote:
> > On Thu, 12 Dec 2019 at 17:33, Andrew Jones <drjones@redhat.com> wrote:
> >
> > > Userspace that wants to set KVM_REG_ARM_TIMER_CNT should beware that
> > > the KVM register ID is not correct. This cannot be fixed because
> > > it's
> > > UAPI and if the UAPI headers are used then it can't be a problem.
> > > However, if a userspace attempts to create the ID themselves from
> > > the
> > > register's specification, then they will get KVM_REG_ARM_TIMER_CVAL
> > > instead, as the _CNT and _CVAL definitions have their register
> > > parameters swapped.
> >
> > So, to be clear, you mean that:
> >
> > (1) the kernel headers say:
> >
> > /* EL0 Virtual Timer Registers */
> > #define KVM_REG_ARM_TIMER_CTL ARM64_SYS_REG(3, 3, 14, 3, 1)
> > #define KVM_REG_ARM_TIMER_CNT ARM64_SYS_REG(3, 3, 14, 3, 2)
> > #define KVM_REG_ARM_TIMER_CVAL ARM64_SYS_REG(3, 3, 14, 0, 2)
> >
> > (2) some of the RHSes of these are wrong
> >
> > (3) but the kernel internally is using the same 'wrong' value, so
> > userspace also needs to use that value, ie trust the #defined name
> > rather than manufacturing one ?
> >
> > That's awkward. I think it would be worth at least having a kernel
> > patch to add a comment clearly documenting this bug.
> >
> > (This error seems to only be in the 64-bit ABI, not 32-bit.)
>
> Yeah, this is pretty bad. I wonder how we managed not to notice
> this for so long... :-(.
>
> Andrew, could you please write a patch documenting this (both in
> the UAPI headers and in the documentation)?
>
Will do. I'll try to get to it this week.
Thanks,
drew
next prev parent reply other threads:[~2019-12-16 17:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 17:33 [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time Andrew Jones
2019-12-12 17:33 ` [RFC PATCH v2 1/5] hw: add compat machines for 5.0 Andrew Jones
2019-12-12 18:27 ` David Hildenbrand
2019-12-12 19:24 ` Eduardo Habkost
2019-12-13 7:10 ` Andrew Jones
2019-12-13 5:00 ` David Gibson
2019-12-12 17:33 ` [RFC PATCH v2 2/5] target/arm/kvm64: kvm64 cpus have timer registers Andrew Jones
2019-12-12 17:33 ` [RFC PATCH v2 3/5] target/arm/kvm: Implement virtual time adjustment Andrew Jones
2019-12-16 15:14 ` Peter Maydell
2019-12-16 15:40 ` Peter Maydell
2019-12-16 16:43 ` Andrew Jones
2019-12-16 18:06 ` Peter Maydell
2019-12-19 14:30 ` Andrew Jones
2020-01-20 9:40 ` Andrew Jones
2019-12-16 16:36 ` Andrew Jones
2019-12-12 17:33 ` [RFC PATCH v2 4/5] tests/arm-cpu-features: Check feature default values Andrew Jones
2019-12-12 17:33 ` [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property Andrew Jones
2019-12-16 15:06 ` Peter Maydell
2019-12-16 16:52 ` Andrew Jones
2019-12-16 16:57 ` Peter Maydell
2020-01-20 10:31 ` Andrew Jones
2020-02-06 12:08 ` Philippe Mathieu-Daudé
2020-02-06 12:40 ` Andrew Jones
2020-02-06 22:46 ` Philippe Mathieu-Daudé
2020-02-07 7:37 ` Andrew Jones
2019-12-16 15:33 ` [RFC PATCH v2 0/5] target/arm/kvm: Adjust virtual time Peter Maydell
2019-12-16 15:44 ` Peter Maydell
2020-01-20 13:45 ` Andrew Jones
2019-12-16 16:18 ` Marc Zyngier
2019-12-16 16:59 ` Andrew Jones [this message]
2019-12-16 17:05 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216165920.qsx7ufviir74tbkl@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=bijan.mottahedeh@oracle.com \
--cc=guoheyi@huawei.com \
--cc=maz@kernel.org \
--cc=msys.mizuma@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).