From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] vhost-user-fs: remove "vhostfd" property
Date: Fri, 13 Dec 2019 10:52:40 +0000 [thread overview]
Message-ID: <20191213105240.GA7302@work-vm> (raw)
In-Reply-To: <20191116112016.14872-1-marcandre.lureau@redhat.com>
* Marc-André Lureau (marcandre.lureau@redhat.com) wrote:
> The property doesn't make much sense for a vhost-user device.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Queued for virtiofs
> ---
> hw/virtio/vhost-user-fs.c | 1 -
> include/hw/virtio/vhost-user-fs.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c
> index f0df7f4746..ca0b7fc9de 100644
> --- a/hw/virtio/vhost-user-fs.c
> +++ b/hw/virtio/vhost-user-fs.c
> @@ -263,7 +263,6 @@ static Property vuf_properties[] = {
> DEFINE_PROP_UINT16("num-request-queues", VHostUserFS,
> conf.num_request_queues, 1),
> DEFINE_PROP_UINT16("queue-size", VHostUserFS, conf.queue_size, 128),
> - DEFINE_PROP_STRING("vhostfd", VHostUserFS, conf.vhostfd),
> DEFINE_PROP_END_OF_LIST(),
> };
>
> diff --git a/include/hw/virtio/vhost-user-fs.h b/include/hw/virtio/vhost-user-fs.h
> index 539885b458..9ff1bdb7cf 100644
> --- a/include/hw/virtio/vhost-user-fs.h
> +++ b/include/hw/virtio/vhost-user-fs.h
> @@ -28,7 +28,6 @@ typedef struct {
> char *tag;
> uint16_t num_request_queues;
> uint16_t queue_size;
> - char *vhostfd;
> } VHostUserFSConf;
>
> typedef struct {
> --
> 2.24.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2019-12-13 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 11:20 [PATCH] vhost-user-fs: remove "vhostfd" property Marc-André Lureau
2019-11-21 13:43 ` Stefan Hajnoczi
2019-12-13 10:52 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213105240.GA7302@work-vm \
--to=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).