* [PATCH] vhost-user-fs: remove "vhostfd" property
@ 2019-11-16 11:20 Marc-André Lureau
2019-11-21 13:43 ` Stefan Hajnoczi
2019-12-13 10:52 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 3+ messages in thread
From: Marc-André Lureau @ 2019-11-16 11:20 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, dgilbert, Michael S. Tsirkin
The property doesn't make much sense for a vhost-user device.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/virtio/vhost-user-fs.c | 1 -
include/hw/virtio/vhost-user-fs.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c
index f0df7f4746..ca0b7fc9de 100644
--- a/hw/virtio/vhost-user-fs.c
+++ b/hw/virtio/vhost-user-fs.c
@@ -263,7 +263,6 @@ static Property vuf_properties[] = {
DEFINE_PROP_UINT16("num-request-queues", VHostUserFS,
conf.num_request_queues, 1),
DEFINE_PROP_UINT16("queue-size", VHostUserFS, conf.queue_size, 128),
- DEFINE_PROP_STRING("vhostfd", VHostUserFS, conf.vhostfd),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/include/hw/virtio/vhost-user-fs.h b/include/hw/virtio/vhost-user-fs.h
index 539885b458..9ff1bdb7cf 100644
--- a/include/hw/virtio/vhost-user-fs.h
+++ b/include/hw/virtio/vhost-user-fs.h
@@ -28,7 +28,6 @@ typedef struct {
char *tag;
uint16_t num_request_queues;
uint16_t queue_size;
- char *vhostfd;
} VHostUserFSConf;
typedef struct {
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost-user-fs: remove "vhostfd" property
2019-11-16 11:20 [PATCH] vhost-user-fs: remove "vhostfd" property Marc-André Lureau
@ 2019-11-21 13:43 ` Stefan Hajnoczi
2019-12-13 10:52 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-11-21 13:43 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: Michael S. Tsirkin, qemu-devel, dgilbert
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
On Sat, Nov 16, 2019 at 03:20:16PM +0400, Marc-André Lureau wrote:
> The property doesn't make much sense for a vhost-user device.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/virtio/vhost-user-fs.c | 1 -
> include/hw/virtio/vhost-user-fs.h | 1 -
> 2 files changed, 2 deletions(-)
It was never implemented either :).
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost-user-fs: remove "vhostfd" property
2019-11-16 11:20 [PATCH] vhost-user-fs: remove "vhostfd" property Marc-André Lureau
2019-11-21 13:43 ` Stefan Hajnoczi
@ 2019-12-13 10:52 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2019-12-13 10:52 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, Michael S. Tsirkin
* Marc-André Lureau (marcandre.lureau@redhat.com) wrote:
> The property doesn't make much sense for a vhost-user device.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Queued for virtiofs
> ---
> hw/virtio/vhost-user-fs.c | 1 -
> include/hw/virtio/vhost-user-fs.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c
> index f0df7f4746..ca0b7fc9de 100644
> --- a/hw/virtio/vhost-user-fs.c
> +++ b/hw/virtio/vhost-user-fs.c
> @@ -263,7 +263,6 @@ static Property vuf_properties[] = {
> DEFINE_PROP_UINT16("num-request-queues", VHostUserFS,
> conf.num_request_queues, 1),
> DEFINE_PROP_UINT16("queue-size", VHostUserFS, conf.queue_size, 128),
> - DEFINE_PROP_STRING("vhostfd", VHostUserFS, conf.vhostfd),
> DEFINE_PROP_END_OF_LIST(),
> };
>
> diff --git a/include/hw/virtio/vhost-user-fs.h b/include/hw/virtio/vhost-user-fs.h
> index 539885b458..9ff1bdb7cf 100644
> --- a/include/hw/virtio/vhost-user-fs.h
> +++ b/include/hw/virtio/vhost-user-fs.h
> @@ -28,7 +28,6 @@ typedef struct {
> char *tag;
> uint16_t num_request_queues;
> uint16_t queue_size;
> - char *vhostfd;
> } VHostUserFSConf;
>
> typedef struct {
> --
> 2.24.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-13 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-16 11:20 [PATCH] vhost-user-fs: remove "vhostfd" property Marc-André Lureau
2019-11-21 13:43 ` Stefan Hajnoczi
2019-12-13 10:52 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).