* [Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ?
@ 2019-12-17 13:25 dcb
2019-12-17 16:27 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: dcb @ 2019-12-17 13:25 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has
identical branches [-Wduplicated-branches]
Source code is
if (other_tc == other->current_tc) {
tccause = other->CP0_Cause;
} else {
tccause = other->CP0_Cause;
}
Possible cut'n'paste error ?
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1856706
Title:
target/mips/op_helper.c:971:duplicated branches ?
Status in QEMU:
New
Bug description:
qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has
identical branches [-Wduplicated-branches]
Source code is
if (other_tc == other->current_tc) {
tccause = other->CP0_Cause;
} else {
tccause = other->CP0_Cause;
}
Possible cut'n'paste error ?
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1856706/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ?
2019-12-17 13:25 [Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ? dcb
@ 2019-12-17 16:27 ` Thomas Huth
2020-01-08 0:30 ` Edgar E. Iglesias
2020-01-07 10:52 ` [Bug 1856706] " Philippe Mathieu-Daudé
2020-08-20 14:43 ` Thomas Huth
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2019-12-17 16:27 UTC (permalink / raw)
To: Bug 1856706, qemu-devel, Edgar E. Iglesias
Cc: Aleksandar Rikalo, Philippe Mathieu-Daudé,
Aleksandar Markovic, Aurelien Jarno
On 17/12/2019 14.25, dcb wrote:
> Public bug reported:
>
> qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has
> identical branches [-Wduplicated-branches]
>
> Source code is
>
> if (other_tc == other->current_tc) {
> tccause = other->CP0_Cause;
> } else {
> tccause = other->CP0_Cause;
> }
>
> Possible cut'n'paste error ?
Hi Edgar,
you added the code in 2011 ... do you still remember the details here,
whether that was on purpose or whether it should look differently?
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 1856706] Re: target/mips/op_helper.c:971:duplicated branches ?
2019-12-17 13:25 [Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ? dcb
2019-12-17 16:27 ` Thomas Huth
@ 2020-01-07 10:52 ` Philippe Mathieu-Daudé
2020-08-20 14:43 ` Thomas Huth
2 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-07 10:52 UTC (permalink / raw)
To: qemu-devel
** Tags added: mips
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1856706
Title:
target/mips/op_helper.c:971:duplicated branches ?
Status in QEMU:
New
Bug description:
qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has
identical branches [-Wduplicated-branches]
Source code is
if (other_tc == other->current_tc) {
tccause = other->CP0_Cause;
} else {
tccause = other->CP0_Cause;
}
Possible cut'n'paste error ?
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1856706/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ?
2019-12-17 16:27 ` Thomas Huth
@ 2020-01-08 0:30 ` Edgar E. Iglesias
2020-01-08 0:30 ` Edgar E. Iglesias
0 siblings, 1 reply; 6+ messages in thread
From: Edgar E. Iglesias @ 2020-01-08 0:30 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Aleksandar Markovic, Aleksandar Rikalo,
Philippe Mathieu-Daudé,
Aurelien Jarno, Bug 1856706
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Tue, 17 Dec. 2019, 09:28 Thomas Huth, <thuth@redhat.com> wrote:
> On 17/12/2019 14.25, dcb wrote:
> > Public bug reported:
> >
> > qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has
> > identical branches [-Wduplicated-branches]
> >
> > Source code is
> >
> > if (other_tc == other->current_tc) {
> > tccause = other->CP0_Cause;
> > } else {
> > tccause = other->CP0_Cause;
> > }
> >
> > Possible cut'n'paste error ?
>
> Hi Edgar,
>
> you added the code in 2011 ... do you still remember the details here,
> whether that was on purpose or whether it should look differently?
>
> Thomas
>
Hi Thomas,
Sorry but I barely recall yesterday, 2011 was a long time ago... It does
look weird.
IIRC smp was kinda of working but the multithreading support wasn't. Some
of these paths were probably not tested too much at the time.
Cheers,
Edgar
>
>
[-- Attachment #2: Type: text/html, Size: 1728 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ?
2020-01-08 0:30 ` Edgar E. Iglesias
@ 2020-01-08 0:30 ` Edgar E. Iglesias
0 siblings, 0 replies; 6+ messages in thread
From: Edgar E. Iglesias @ 2020-01-08 0:30 UTC (permalink / raw)
To: qemu-devel
On Tue, 17 Dec. 2019, 09:28 Thomas Huth, <thuth@redhat.com> wrote:
> On 17/12/2019 14.25, dcb wrote:
> > Public bug reported:
> >
> > qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has
> > identical branches [-Wduplicated-branches]
> >
> > Source code is
> >
> > if (other_tc == other->current_tc) {
> > tccause = other->CP0_Cause;
> > } else {
> > tccause = other->CP0_Cause;
> > }
> >
> > Possible cut'n'paste error ?
>
> Hi Edgar,
>
> you added the code in 2011 ... do you still remember the details here,
> whether that was on purpose or whether it should look differently?
>
> Thomas
>
Hi Thomas,
Sorry but I barely recall yesterday, 2011 was a long time ago... It does
look weird.
IIRC smp was kinda of working but the multithreading support wasn't. Some
of these paths were probably not tested too much at the time.
Cheers,
Edgar
>
>
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1856706
Title:
target/mips/op_helper.c:971:duplicated branches ?
Status in QEMU:
New
Bug description:
qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has
identical branches [-Wduplicated-branches]
Source code is
if (other_tc == other->current_tc) {
tccause = other->CP0_Cause;
} else {
tccause = other->CP0_Cause;
}
Possible cut'n'paste error ?
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1856706/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 1856706] Re: target/mips/op_helper.c:971:duplicated branches ?
2019-12-17 13:25 [Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ? dcb
2019-12-17 16:27 ` Thomas Huth
2020-01-07 10:52 ` [Bug 1856706] " Philippe Mathieu-Daudé
@ 2020-08-20 14:43 ` Thomas Huth
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2020-08-20 14:43 UTC (permalink / raw)
To: qemu-devel
Patch has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9788e8c9b64e4cebb01
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1856706
Title:
target/mips/op_helper.c:971:duplicated branches ?
Status in QEMU:
Fix Released
Bug description:
qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has
identical branches [-Wduplicated-branches]
Source code is
if (other_tc == other->current_tc) {
tccause = other->CP0_Cause;
} else {
tccause = other->CP0_Cause;
}
Possible cut'n'paste error ?
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1856706/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-20 14:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 13:25 [Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ? dcb
2019-12-17 16:27 ` Thomas Huth
2020-01-08 0:30 ` Edgar E. Iglesias
2020-01-08 0:30 ` Edgar E. Iglesias
2020-01-07 10:52 ` [Bug 1856706] " Philippe Mathieu-Daudé
2020-08-20 14:43 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).