qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/1] travis.yml: Missing genisoimage package
@ 2020-01-10 19:12 Wainer dos Santos Moschetta
  2020-01-10 19:12 ` [PATCH 1/1] travis.yml: Install " Wainer dos Santos Moschetta
  0 siblings, 1 reply; 3+ messages in thread
From: Wainer dos Santos Moschetta @ 2020-01-10 19:12 UTC (permalink / raw)
  To: qemu-devel; +Cc: fam, alex.bennee, philmd

Let's install genisoimage package on Travis build environments so that
the cdrom-test tests run (currently they skip due the missing dependency).

As an example, on
https://travis-ci.org/qemu/qemu/jobs/635375718:

```
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64
QTEST_QEMU_IMG=qemu-img tests/cdrom-test -m=quick -k --tap < /dev/null |
./scripts/tap-driver.pl --test-name="cdrom-test" 

SKIP
```

Now with this change on
https://travis-ci.org/wainersm/qemu/jobs/635358843:

```
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}  QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 QTEST_QEMU_IMG=qemu-img tests/cdrom-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl --test-name="cdrom-test" 

PASS 1 cdrom-test /aarch64/cdrom/param/realview-eb

PASS 2 cdrom-test /aarch64/cdrom/param/realview-eb-mpcore

PASS 3 cdrom-test /aarch64/cdrom/param/realview-pb-a8

PASS 4 cdrom-test /aarch64/cdrom/param/realview-pbx-a9

PASS 5 cdrom-test /aarch64/cdrom/param/versatileab

PASS 6 cdrom-test /aarch64/cdrom/param/versatilepb

PASS 7 cdrom-test /aarch64/cdrom/param/vexpress-a15

PASS 8 cdrom-test /aarch64/cdrom/param/vexpress-a9

PASS 9 cdrom-test /aarch64/cdrom/param/virt
```

Wainer dos Santos Moschetta (1):
  travis.yml: Install genisoimage package

 .travis.yml | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.23.0



^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH 1/1] travis.yml: Install genisoimage package
  2020-01-10 19:12 [PATCH 0/1] travis.yml: Missing genisoimage package Wainer dos Santos Moschetta
@ 2020-01-10 19:12 ` Wainer dos Santos Moschetta
  2020-01-22 13:47   ` Thomas Huth
  0 siblings, 1 reply; 3+ messages in thread
From: Wainer dos Santos Moschetta @ 2020-01-10 19:12 UTC (permalink / raw)
  To: qemu-devel; +Cc: fam, alex.bennee, philmd

The genisoimage program is required for tests/cdrom-test
tests, otherwise they are skipped. The current Travis
environments do not provide it by default, so let's
explicitly require the genisoimage package.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 .travis.yml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 6c1038a0f1..131c920255 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -51,6 +51,8 @@ addons:
       - sparse
       - uuid-dev
       - gcovr
+      # Tests dependencies
+      - genisoimage
 
 
 # The channel name "irc.oftc.net#qemu" is encrypted against qemu/qemu
@@ -383,6 +385,8 @@ matrix:
           - libusb-1.0-0-dev
           - libvdeplug-dev
           - libvte-2.91-dev
+          # Tests dependencies
+          - genisoimage
       env:
         - TEST_CMD="make check check-tcg V=1"
         - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS}"
@@ -412,6 +416,8 @@ matrix:
           - libusb-1.0-0-dev
           - libvdeplug-dev
           - libvte-2.91-dev
+          # Tests dependencies
+          - genisoimage
       env:
         - TEST_CMD="make check check-tcg V=1"
         - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user"
@@ -441,6 +447,8 @@ matrix:
           - libusb-1.0-0-dev
           - libvdeplug-dev
           - libvte-2.91-dev
+          # Tests dependencies
+          - genisoimage
       env:
         - TEST_CMD="make check check-tcg V=1"
         - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},s390x-linux-user"
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] travis.yml: Install genisoimage package
  2020-01-10 19:12 ` [PATCH 1/1] travis.yml: Install " Wainer dos Santos Moschetta
@ 2020-01-22 13:47   ` Thomas Huth
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2020-01-22 13:47 UTC (permalink / raw)
  To: Wainer dos Santos Moschetta, qemu-devel
  Cc: fam, philmd, John Snow, alex.bennee

On 10/01/2020 20.12, Wainer dos Santos Moschetta wrote:
> The genisoimage program is required for tests/cdrom-test
> tests, otherwise they are skipped. The current Travis
> environments do not provide it by default, so let's
> explicitly require the genisoimage package.
> 
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
>  .travis.yml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 6c1038a0f1..131c920255 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -51,6 +51,8 @@ addons:
>        - sparse
>        - uuid-dev
>        - gcovr
> +      # Tests dependencies
> +      - genisoimage
>  
>  
>  # The channel name "irc.oftc.net#qemu" is encrypted against qemu/qemu
> @@ -383,6 +385,8 @@ matrix:
>            - libusb-1.0-0-dev
>            - libvdeplug-dev
>            - libvte-2.91-dev
> +          # Tests dependencies
> +          - genisoimage
>        env:
>          - TEST_CMD="make check check-tcg V=1"
>          - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS}"
> @@ -412,6 +416,8 @@ matrix:
>            - libusb-1.0-0-dev
>            - libvdeplug-dev
>            - libvte-2.91-dev
> +          # Tests dependencies
> +          - genisoimage
>        env:
>          - TEST_CMD="make check check-tcg V=1"
>          - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user"
> @@ -441,6 +447,8 @@ matrix:
>            - libusb-1.0-0-dev
>            - libvdeplug-dev
>            - libvte-2.91-dev
> +          # Tests dependencies
> +          - genisoimage
>        env:
>          - TEST_CMD="make check check-tcg V=1"
>          - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},s390x-linux-user"
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-22 13:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 19:12 [PATCH 0/1] travis.yml: Missing genisoimage package Wainer dos Santos Moschetta
2020-01-10 19:12 ` [PATCH 1/1] travis.yml: Install " Wainer dos Santos Moschetta
2020-01-22 13:47   ` Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).