From: Andrew Jones <drjones@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: thuth@redhat.com, ehabkost@redhat.com, philmd@redhat.com,
qemu-devel@nongnu.org, crosa@redhat.com, alex.bennee@linaro.org
Subject: Re: [PATCH v3 2/4] tests/acceptance: boot_linux_console: Add boot Linux with kvm tests
Date: Fri, 24 Jan 2020 08:54:56 +0100 [thread overview]
Message-ID: <20200124075456.ysi6ippct7xfmzzj@kamzik.brq.redhat.com> (raw)
In-Reply-To: <7106bfc9-067e-6864-c766-046372ed4bd0@redhat.com>
On Thu, Jan 23, 2020 at 07:47:19PM -0200, Wainer dos Santos Moschetta wrote:
>
> On 1/22/20 7:02 AM, Andrew Jones wrote:
> > On Tue, Jan 21, 2020 at 10:27:51PM -0300, Wainer dos Santos Moschetta wrote:
> > > + def test_aarch64_virt_kvm(self):
> > > + """
> > > + :avocado: tags=arch:aarch64
> > > + :avocado: tags=machine:virt
> > > + :avocado: tags=accel:kvm
> > > + """
> > > + self.do_test_aarch64_virt()
> > > +
> > > + def test_aarch64_virt_tcg(self):
> > > + """
> > > + :avocado: tags=arch:aarch64
> > > + :avocado: tags=machine:virt
> > > + :avocado: tags=accel:tcg
> > > + """
> > > + self.do_test_aarch64_virt()
> > > +
> > Does do_test_aarch64_virt() add more machine parameters? Also, which cpu
> > type does it choose? The reason I ask is because aarch64 virt will fail to
> > run with KVM unless the appropriate gic version is specified (the
> > gic-version machine parameter). Also the cpu type must be 'host' or 'max'.
> > 'max' is the better choice as it also works for tcg. gic-version also
> > takes 'max' allowing it to auto-select the appropriate version. So if it's
> > not already there somewhere, then please ensure aarch64 has these
> > additional parameters:
> >
> > machine:gic-version=max
> > cpu:max
>
>
> The test was passing '-cpu cortex-a56', I replaced with '-cpu max'. Also,
> now, it passes the gic version as you pointed out. I will send those changes
> on a v4.
>
> Other than that, I tried '-cpu max -machine virt' (without gic-version) and
> QEMU crashed:
>
> [root@virtlab-arm03 build]# ./aarch64-softmmu/qemu-system-aarch64 -accel kvm
> -cpu max -machine virt -display none -vga none
> qemu-system-aarch64: PMU: KVM_SET_DEVICE_ATTR: Invalid argument
> qemu-system-aarch64: failed to set irq for PMU
> Aborted (core dumped)
>
> ----
>
> Should I expect it to crash or rather nicely fail?
crash, unfortunately. I recall we once had a plan to send patches to
fail nicer, and to output a hint on how to resolve the issue, but I
guess that never happened...
Thanks,
drew
next prev parent reply other threads:[~2020-01-24 7:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 1:27 [PATCH v3 0/4] Acceptance tests: boot Linux with KVM test Wainer dos Santos Moschetta
2020-01-22 1:27 ` [PATCH v3 1/4] tests/acceptance: avocado_qemu: Introduce the 'accel' test parameter Wainer dos Santos Moschetta
2020-01-24 9:36 ` Philippe Mathieu-Daudé
2020-01-27 19:28 ` Wainer dos Santos Moschetta
2020-01-30 22:51 ` Philippe Mathieu-Daudé
2020-02-04 21:30 ` Wainer dos Santos Moschetta
2020-01-22 1:27 ` [PATCH v3 2/4] tests/acceptance: boot_linux_console: Add boot Linux with kvm tests Wainer dos Santos Moschetta
2020-01-22 9:02 ` Andrew Jones
2020-01-23 21:47 ` Wainer dos Santos Moschetta
2020-01-24 7:54 ` Andrew Jones [this message]
2020-01-24 15:45 ` Philippe Mathieu-Daudé
2020-01-24 15:47 ` Thomas Huth
2020-02-04 21:25 ` Wainer dos Santos Moschetta
2020-01-22 1:27 ` [PATCH v3 3/4] tests/acceptance: avocado_qemu: Refactor the handler of 'machine' parameter Wainer dos Santos Moschetta
2020-01-30 23:23 ` Philippe Mathieu-Daudé
2020-01-22 1:27 ` [PATCH v3 4/4] travis.yml: Enable acceptance KVM tests Wainer dos Santos Moschetta
2020-01-22 9:11 ` Thomas Huth
2020-01-22 9:22 ` Thomas Huth
2020-01-24 21:15 ` Wainer dos Santos Moschetta
2020-01-27 9:34 ` Thomas Huth
2020-01-24 9:38 ` Philippe Mathieu-Daudé
2020-01-24 9:44 ` Thomas Huth
2020-01-24 9:54 ` Philippe Mathieu-Daudé
2020-01-24 19:55 ` Wainer dos Santos Moschetta
2020-01-27 9:51 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124075456.ysi6ippct7xfmzzj@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).