Re: [PATCH v3 4/4] travis.yml: Enable acceptance KVM tests

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 1/24/20 10:44 AM, Thomas Huth wrote:
> On 24/01/2020 10.38, Philippe Mathieu-Daudé wrote:
>> On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote:
>>> Some acceptance tests require KVM or they are skipped. Travis
>>> enables nested virtualization by default with Ubuntu
>>> 18.04 (Bionic) on x86_64. So in order to run the kvm tests, this
>>> changed the acceptance builder to run in a Bionic VM. Also
>>> it was needed to ensure the current user has rw permission
>>> to /dev/kvm.
>>>
>>> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>>> ---
>>>    .travis.yml | 7 ++++++-
>>>    1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index 6c1038a0f1..c3edd0a907 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -2,6 +2,7 @@
>>>    # Additional builds with specific requirements for a full VM need to
>>>    # be added as additional matrix: entries later on
>>>    dist: xenial
>>> +sudo: true
>>>    language: c
>>>    compiler:
>>>      - gcc
>>> @@ -83,6 +84,9 @@ git:
>>>      before_script:
>>>      - if command -v ccache ; then ccache --zero-stats ; fi
>>> +  - if [[ -e /dev/kvm ]] && ! [[ -r /dev/kvm && -w /dev/kvm ]]; then
>>> +        sudo chmod o+rw /dev/kvm ;
>>> +    fi
>>>      - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
>>>      - ${SRC_DIR}/configure ${BASE_CONFIG} ${CONFIG} || { cat
>>> config.log && exit 1; }
>>>    script:
>>> @@ -272,12 +276,13 @@ matrix:
>>>            - TEST_CMD="make check-acceptance"
>>>          after_script:
>>>            - python3 -c 'import json; r =
>>> json.load(open("tests/results/latest/results.json"));
>>> [print(t["logfile"]) for t in r["tests"] if t["status"] not in
>>> ("PASS", "SKIP")]' | xargs cat
>>> +      dist: bionic
>>>          addons:
>>>            apt:
>>>              packages:
>>>                - python3-pil
>>>                - python3-pip
>>> -            - python3.5-venv
>>> +            - python3.6-venv
>>
>> This line doesn't seem related to the patch.
> 
> "dist:" has been switched from xenial to bionic, so I think it is
> required to update to python3.6 here, too?

OK, I got confused because line 4 is still "dist: xenial".

Wainer can you add a comment about this in the commit description?

I'm still not convinced we should enable "sudo: true" on all our jobs.