From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>
Subject: [PATCH v4 0/4] luks: add qemu-img measure support
Date: Fri, 21 Feb 2020 11:25:18 +0000 [thread overview]
Message-ID: <20200221112522.1497712-1-stefanha@redhat.com> (raw)
v4:
* This revision is what German speakers call "das Tüpfelchen auf dem I". "The
icing on the cake" is the English equivalent. Since I like cake and don't
want it to be half-baked, and because I like my metaphors shaken, not
stirred, I went ahead with the extra revision so I could write this message.
* Use g_autoptr(QCryptoBlock) to make the code more concise [Max]
* Use local_err consistently [Max]
* Folded in Max's Reviewed-by tags
v3:
* Move payload offset calculation function to crypto/block.c [Max]
* Zero/unallocated blocks always require disk space on encrypted files [Max]
* Update qemu-iotests 178 output when changing qemu-img measure command-line
options
v2:
* Fix uint64_t <-> size_t type mismatch in block_crypto_measure() so that
32-bit builds pass
This patch series adds qemu-img measure support to the "luks" block driver. We
just need to take into account the LUKS header when sizing the image.
Stefan Hajnoczi (4):
luks: extract qcrypto_block_calculate_payload_offset()
luks: implement .bdrv_measure()
qemu-img: allow qemu-img measure --object without a filename
iotests: add 282 luks qemu-img measure test
block/crypto.c | 62 +++++++++++++++++++++
block/qcow2.c | 74 +++++++------------------
crypto/block.c | 36 +++++++++++++
include/crypto/block.h | 22 ++++++++
qemu-img.c | 6 +--
tests/qemu-iotests/178 | 2 +-
tests/qemu-iotests/178.out.qcow2 | 8 +--
tests/qemu-iotests/178.out.raw | 8 +--
tests/qemu-iotests/282 | 93 ++++++++++++++++++++++++++++++++
tests/qemu-iotests/282.out | 30 +++++++++++
tests/qemu-iotests/group | 1 +
11 files changed, 274 insertions(+), 68 deletions(-)
create mode 100755 tests/qemu-iotests/282
create mode 100644 tests/qemu-iotests/282.out
--
2.24.1
next reply other threads:[~2020-02-21 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 11:25 Stefan Hajnoczi [this message]
2020-02-21 11:25 ` [PATCH v4 1/4] luks: extract qcrypto_block_calculate_payload_offset() Stefan Hajnoczi
2020-02-21 11:25 ` [PATCH v4 2/4] luks: implement .bdrv_measure() Stefan Hajnoczi
2020-02-21 11:25 ` [PATCH v4 3/4] qemu-img: allow qemu-img measure --object without a filename Stefan Hajnoczi
2020-02-21 11:25 ` [PATCH v4 4/4] iotests: add 282 luks qemu-img measure test Stefan Hajnoczi
2020-02-25 16:36 ` [PATCH v4 0/4] luks: add qemu-img measure support Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221112522.1497712-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).