From: Max Reitz <mreitz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH v4 0/4] luks: add qemu-img measure support
Date: Tue, 25 Feb 2020 17:36:52 +0100 [thread overview]
Message-ID: <e435f6d8-a67c-09fd-819d-c5236a32cb70@redhat.com> (raw)
In-Reply-To: <20200221112522.1497712-1-stefanha@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1167 bytes --]
On 21.02.20 12:25, Stefan Hajnoczi wrote:
> v4:
> * This revision is what German speakers call "das Tüpfelchen auf dem I". "The
> icing on the cake" is the English equivalent. Since I like cake and don't
> want it to be half-baked, and because I like my metaphors shaken, not
> stirred, I went ahead with the extra revision so I could write this message.
:)
> * Use g_autoptr(QCryptoBlock) to make the code more concise [Max]
> * Use local_err consistently [Max]
> * Folded in Max's Reviewed-by tags
> v3:
> * Move payload offset calculation function to crypto/block.c [Max]
> * Zero/unallocated blocks always require disk space on encrypted files [Max]
> * Update qemu-iotests 178 output when changing qemu-img measure command-line
> options
>
> v2:
> * Fix uint64_t <-> size_t type mismatch in block_crypto_measure() so that
> 32-bit builds pass
>
> This patch series adds qemu-img measure support to the "luks" block driver. We
> just need to take into account the LUKS header when sizing the image.
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-02-25 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 11:25 [PATCH v4 0/4] luks: add qemu-img measure support Stefan Hajnoczi
2020-02-21 11:25 ` [PATCH v4 1/4] luks: extract qcrypto_block_calculate_payload_offset() Stefan Hajnoczi
2020-02-21 11:25 ` [PATCH v4 2/4] luks: implement .bdrv_measure() Stefan Hajnoczi
2020-02-21 11:25 ` [PATCH v4 3/4] qemu-img: allow qemu-img measure --object without a filename Stefan Hajnoczi
2020-02-21 11:25 ` [PATCH v4 4/4] iotests: add 282 luks qemu-img measure test Stefan Hajnoczi
2020-02-25 16:36 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e435f6d8-a67c-09fd-819d-c5236a32cb70@redhat.com \
--to=mreitz@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).