qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu()
@ 2020-02-21 16:20 Philippe Mathieu-Daudé
  2020-02-26 11:53 ` Aleksandar Markovic
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-21 16:20 UTC (permalink / raw)
  To: qemu-devel
  Cc: Philippe Mathieu-Daudé,
	Aleksandar Rikalo, Richard Henderson, Aurelien Jarno,
	Aleksandar Markovic

Since commit d8ed887bdc, the cpu_mips_irq_request handler takes
a pointer to MIPSCPU in its opaque argument.  Directly pass the
cpu pointer.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/mips/mips_int.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
index 863ed45659..796730b11d 100644
--- a/hw/mips/mips_int.c
+++ b/hw/mips/mips_int.c
@@ -77,7 +77,7 @@ void cpu_mips_irq_init_cpu(MIPSCPU *cpu)
     qemu_irq *qi;
     int i;
 
-    qi = qemu_allocate_irqs(cpu_mips_irq_request, env_archcpu(env), 8);
+    qi = qemu_allocate_irqs(cpu_mips_irq_request, cpu, 8);
     for (i = 0; i < 8; i++) {
         env->irq[i] = qi[i];
     }
-- 
2.21.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu()
  2020-02-21 16:20 [PATCH] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu() Philippe Mathieu-Daudé
@ 2020-02-26 11:53 ` Aleksandar Markovic
  0 siblings, 0 replies; 2+ messages in thread
From: Aleksandar Markovic @ 2020-02-26 11:53 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Aleksandar Markovic, Aleksandar Rikalo, Richard Henderson,
	qemu-devel, Aurelien Jarno

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On Friday, February 21, 2020, Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:

> Since commit d8ed887bdc, the cpu_mips_irq_request handler takes
> a pointer to MIPSCPU in its opaque argument.  Directly pass the
> cpu pointer.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---


Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>

Applied to the next MIPS queue.


>  hw/mips/mips_int.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
> index 863ed45659..796730b11d 100644
> --- a/hw/mips/mips_int.c
> +++ b/hw/mips/mips_int.c
> @@ -77,7 +77,7 @@ void cpu_mips_irq_init_cpu(MIPSCPU *cpu)
>      qemu_irq *qi;
>      int i;
>
> -    qi = qemu_allocate_irqs(cpu_mips_irq_request, env_archcpu(env), 8);
> +    qi = qemu_allocate_irqs(cpu_mips_irq_request, cpu, 8);
>      for (i = 0; i < 8; i++) {
>          env->irq[i] = qi[i];
>      }
> --
> 2.21.1
>
>
>

[-- Attachment #2: Type: text/html, Size: 1511 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-26 11:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 16:20 [PATCH] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu() Philippe Mathieu-Daudé
2020-02-26 11:53 ` Aleksandar Markovic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).