From: Igor Mammedov <imammedo@redhat.com>
To: Dongjiu Geng <gengdongjiu@huawei.com>
Cc: fam@euphon.net, peter.maydell@linaro.org,
xiaoguangrong.eric@gmail.com, kvm@vger.kernel.org,
mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org,
ehabkost@redhat.com, shannon.zhaosl@gmail.com,
zhengxiang9@huawei.com, qemu-arm@nongnu.org, james.morse@arm.com,
shameerali.kolothum.thodi@huawei.com,
jonathan.cameron@huawei.com, pbonzini@redhat.com,
lersek@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v24 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob
Date: Tue, 25 Feb 2020 14:57:12 +0100 [thread overview]
Message-ID: <20200225145712.4dd410d2@redhat.com> (raw)
In-Reply-To: <20200225094804.3ae51b86@redhat.com>
On Tue, 25 Feb 2020 09:48:04 +0100
Igor Mammedov <imammedo@redhat.com> wrote:
> On Mon, 17 Feb 2020 21:12:42 +0800
> Dongjiu Geng <gengdongjiu@huawei.com> wrote:
>
> > This patch builds error_block_address and read_ack_register fields
> > in hardware errors table , the error_block_address points to Generic
> > Error Status Block(GESB) via bios_linker. The max size for one GESB
> > is 1kb in bytes, For more detailed information, please refer to
>
> s/1kb in bytes/1Kb/
>
> > document: docs/specs/acpi_hest_ghes.rst
> >
> > Now we only support one Error source, if necessary, we can extend to
> > support more.
> >
> > Suggested-by: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
> > Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com>
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
>
On the second glance,
[...]
> > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> > index bd5f771..6819fcf 100644
> > --- a/hw/arm/virt-acpi-build.c
> > +++ b/hw/arm/virt-acpi-build.c
> > @@ -48,6 +48,7 @@
> > #include "sysemu/reset.h"
> > #include "kvm_arm.h"
> > #include "migration/vmstate.h"
> > +#include "hw/acpi/ghes.h"
> >
> > #define ARM_SPI_BASE 32
> >
> > @@ -830,6 +831,11 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
> > acpi_add_table(table_offsets, tables_blob);
> > build_spcr(tables_blob, tables->linker, vms);
> >
> > + if (vms->ras) {
> > + acpi_add_table(table_offsets, tables_blob);
that doesn't look right, it's for tables that should be referenced
from XSDT
> > + build_ghes_error_table(tables->hardware_errors, tables->linker);
but this table isn't pointed by XSDT directly.
I suggest to move acpi_add_table() to the patch that adds acpi_build_hest()
> > + }
> > +
> > if (ms->numa_state->num_nodes > 0) {
> > acpi_add_table(table_offsets, tables_blob);
> > build_srat(tables_blob, tables->linker, vms);
[...]
next prev parent reply other threads:[~2020-02-25 13:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 13:12 [PATCH v24 00/10] Add ARMv8 RAS virtualization support in QEMU Dongjiu Geng
2020-02-17 13:12 ` [PATCH v24 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro Dongjiu Geng
2020-02-21 14:07 ` Peter Maydell
2020-02-17 13:12 ` [PATCH v24 02/10] hw/arm/virt: Introduce a RAS machine option Dongjiu Geng
2020-02-25 8:34 ` Igor Mammedov
2020-02-25 8:54 ` Peter Maydell
2020-02-25 10:53 ` Igor Mammedov
2020-02-17 13:12 ` [PATCH v24 03/10] docs: APEI GHES generation and CPER record description Dongjiu Geng
2020-02-17 13:12 ` [PATCH v24 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob Dongjiu Geng
2020-02-25 8:48 ` Igor Mammedov
2020-02-25 13:57 ` Igor Mammedov [this message]
2020-02-17 13:12 ` [PATCH v24 05/10] ACPI: Build Hardware Error Source Table Dongjiu Geng
2020-02-25 13:23 ` Igor Mammedov
2020-02-17 13:12 ` [PATCH v24 06/10] ACPI: Record the Generic Error Status Block address Dongjiu Geng
2020-02-25 14:11 ` Igor Mammedov
2020-02-17 13:12 ` [PATCH v24 07/10] KVM: Move hwpoison page related functions into kvm-all.c Dongjiu Geng
2020-02-17 13:12 ` [PATCH v24 08/10] ACPI: Record Generic Error Status Block(GESB) table Dongjiu Geng
2020-02-25 16:58 ` Igor Mammedov
2020-02-17 13:12 ` [PATCH v24 09/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Dongjiu Geng
2020-02-21 14:02 ` Peter Maydell
2020-02-17 13:12 ` [PATCH v24 10/10] MAINTAINERS: Add ACPI/HEST/GHES entries Dongjiu Geng
2020-02-21 14:09 ` [PATCH v24 00/10] Add ARMv8 RAS virtualization support in QEMU Peter Maydell
2020-02-24 8:37 ` gengdongjiu
2020-02-25 16:59 ` Igor Mammedov
2020-02-26 16:34 ` gengdongjiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225145712.4dd410d2@redhat.com \
--to=imammedo@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=gengdongjiu@huawei.com \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shannon.zhaosl@gmail.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).