* Re: [PULL 00/13] Block layer patches
[not found] <20200311154218.15532-1-kwolf@redhat.com>
@ 2020-03-12 13:46 ` Peter Maydell
2020-03-12 14:42 ` Kevin Wolf
2020-03-12 17:34 ` Peter Maydell
1 sibling, 1 reply; 13+ messages in thread
From: Peter Maydell @ 2020-03-12 13:46 UTC (permalink / raw)
To: Kevin Wolf; +Cc: QEMU Developers, Qemu-block
On Wed, 11 Mar 2020 at 15:42, Kevin Wolf <kwolf@redhat.com> wrote:
>
> The following changes since commit ba29883206d92a29ad5a466e679ccfc2ee6132ef:
>
> Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20200310' into staging (2020-03-10 16:50:28 +0000)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 8bb3b023f2055054ee119cb45b42d2b14be7fc8a:
>
> qemu-iotests: adding LUKS cleanup for non-UTF8 secret error (2020-03-11 15:54:38 +0100)
>
> ----------------------------------------------------------------
> Block layer patches:
>
> - Relax restrictions for blockdev-snapshot (allows libvirt to do live
> storage migration with blockdev-mirror)
> - luks: Delete created files when block_crypto_co_create_opts_luks fails
> - Fix memleaks in qmp_object_add
>
> ----------------------------------------------------------------
iotest 030 hung on x86-64 Linux (Ubuntu):
petmay01 11801 0.0 0.0 34668 26112 ? S 11:24 0:03 |
\_ make --output-sync -C build/alldbg check V=1 -j8
petmay01 15277 0.0 0.0 4628 792 ? S 11:25 0:00 |
\_ /bin/sh
/home/petmay01/linaro/qemu-for-merges/tests/check-block.sh
petmay01 15344 0.0 0.0 14172 3360 ? S 11:25 0:00 |
\_ bash ./check -makecheck -qcow2 -g auto
petmay01 27902 0.0 0.0 14172 2128 ? S 11:25 0:00 |
\_ bash ./check -makecheck -qcow2 -g
auto
petmay01 27903 0.0 0.0 52660 16400 ? S 11:25 0:00 |
\_ python3 -B 030
petmay01 1728 0.0 0.1 1011792 51604 ? Sl 11:26 0:01 |
\_
/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64
-display none -vga none -chardev
socket,id=mon,path=/tmp/tmp.QBQTAAybTi/qemu-27903-monitor.sock -mon
chardev=mon,mode=control -qtest
unix:path=/tmp/tmp.QBQTAAybTi/qemu-27903-qtest.sock -accel qtest
-nodefaults -display none -accel qtest -drive
if=virtio,id=drive0,file=blkdebug::/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads,backing.node-name=mid,backing.backing.node-name=base
I had to manually kill the offending QEMU process; resulting
output in the log:
--- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out
2019-07-15 17:18:35.251364738 +01
00
+++ /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad
2020-03-12 13:44:
43.101182680 +0000
@@ -1,5 +1,27 @@
-...........................
+........................E..
+======================================================================
+ERROR: test_stream_pause (__main__.TestSingleDrive)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "030", line 93, in test_stream_pause
+ self.pause_wait('drive0')
+ File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py",
line 927, in pause_wait
+ result = self.vm.qmp('query-block-jobs')
+ File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/../../python/qemu/machine.py",
line 405, in qmp
+ return self._qmp.cmd(cmd, args=qmp_args)
+ File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/../../python/qemu/qmp.py",
line 215, in cmd
+ return self.cmd_obj(qmp_cmd)
+ File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/../../python/qemu/qmp.py",
line 198, in cmd_obj
+ resp = self.__json_read()
+ File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/../../python/qemu/qmp.py",
line 89, in __json_read
+ data = self.__sockfile.readline()
+ File "/usr/lib/python3.6/socket.py", line 586, in readinto
+ return self._sock.recv_into(b)
+ File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py",
line 383, in timeout
+ raise Exception(self.errmsg)
+Exception: Timeout waiting for job to pause
+
----------------------------------------------------------------------
thanks
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PULL 00/13] Block layer patches
2020-03-12 13:46 ` [PULL 00/13] Block layer patches Peter Maydell
@ 2020-03-12 14:42 ` Kevin Wolf
0 siblings, 0 replies; 13+ messages in thread
From: Kevin Wolf @ 2020-03-12 14:42 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers, Qemu-block
Am 12.03.2020 um 14:46 hat Peter Maydell geschrieben:
> On Wed, 11 Mar 2020 at 15:42, Kevin Wolf <kwolf@redhat.com> wrote:
> >
> > The following changes since commit ba29883206d92a29ad5a466e679ccfc2ee6132ef:
> >
> > Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20200310' into staging (2020-03-10 16:50:28 +0000)
> >
> > are available in the Git repository at:
> >
> > git://repo.or.cz/qemu/kevin.git tags/for-upstream
> >
> > for you to fetch changes up to 8bb3b023f2055054ee119cb45b42d2b14be7fc8a:
> >
> > qemu-iotests: adding LUKS cleanup for non-UTF8 secret error (2020-03-11 15:54:38 +0100)
> >
> > ----------------------------------------------------------------
> > Block layer patches:
> >
> > - Relax restrictions for blockdev-snapshot (allows libvirt to do live
> > storage migration with blockdev-mirror)
> > - luks: Delete created files when block_crypto_co_create_opts_luks fails
> > - Fix memleaks in qmp_object_add
> >
> > ----------------------------------------------------------------
>
>
> iotest 030 hung on x86-64 Linux (Ubuntu):
>
> petmay01 11801 0.0 0.0 34668 26112 ? S 11:24 0:03 |
> \_ make --output-sync -C build/alldbg check V=1 -j8
> petmay01 15277 0.0 0.0 4628 792 ? S 11:25 0:00 |
> \_ /bin/sh
> /home/petmay01/linaro/qemu-for-merges/tests/check-block.sh
> petmay01 15344 0.0 0.0 14172 3360 ? S 11:25 0:00 |
> \_ bash ./check -makecheck -qcow2 -g auto
> petmay01 27902 0.0 0.0 14172 2128 ? S 11:25 0:00 |
> \_ bash ./check -makecheck -qcow2 -g
> auto
> petmay01 27903 0.0 0.0 52660 16400 ? S 11:25 0:00 |
> \_ python3 -B 030
> petmay01 1728 0.0 0.1 1011792 51604 ? Sl 11:26 0:01 |
> \_
> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64
> -display none -vga none -chardev
> socket,id=mon,path=/tmp/tmp.QBQTAAybTi/qemu-27903-monitor.sock -mon
> chardev=mon,mode=control -qtest
> unix:path=/tmp/tmp.QBQTAAybTi/qemu-27903-qtest.sock -accel qtest
> -nodefaults -display none -accel qtest -drive
> if=virtio,id=drive0,file=blkdebug::/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads,backing.node-name=mid,backing.backing.node-name=base
>
> I had to manually kill the offending QEMU process; resulting
> output in the log:
>
> --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out
> 2019-07-15 17:18:35.251364738 +01
> 00
> +++ /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad
> 2020-03-12 13:44:
> 43.101182680 +0000
> @@ -1,5 +1,27 @@
> -...........................
> +........................E..
> +======================================================================
> +ERROR: test_stream_pause (__main__.TestSingleDrive)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "030", line 93, in test_stream_pause
> + self.pause_wait('drive0')
> + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py",
> line 927, in pause_wait
> + result = self.vm.qmp('query-block-jobs')
> + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/../../python/qemu/machine.py",
> line 405, in qmp
> + return self._qmp.cmd(cmd, args=qmp_args)
> + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/../../python/qemu/qmp.py",
> line 215, in cmd
> + return self.cmd_obj(qmp_cmd)
> + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/../../python/qemu/qmp.py",
> line 198, in cmd_obj
> + resp = self.__json_read()
> + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/../../python/qemu/qmp.py",
> line 89, in __json_read
> + data = self.__sockfile.readline()
> + File "/usr/lib/python3.6/socket.py", line 586, in readinto
> + return self._sock.recv_into(b)
> + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py",
> line 383, in timeout
> + raise Exception(self.errmsg)
> +Exception: Timeout waiting for job to pause
> +
> ----------------------------------------------------------------------
For the record (discussed on IRC):
This seems to be intermittent failure where a short timeout (1 second)
might have been too short under heavy load. That this results in a hang
is a test case bug, but it already exists on master.
Peter will retry the test later.
Kevin
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PULL 00/13] Block layer patches
[not found] <20200311154218.15532-1-kwolf@redhat.com>
2020-03-12 13:46 ` [PULL 00/13] Block layer patches Peter Maydell
@ 2020-03-12 17:34 ` Peter Maydell
1 sibling, 0 replies; 13+ messages in thread
From: Peter Maydell @ 2020-03-12 17:34 UTC (permalink / raw)
To: Kevin Wolf; +Cc: QEMU Developers, Qemu-block
On Wed, 11 Mar 2020 at 15:42, Kevin Wolf <kwolf@redhat.com> wrote:
>
> The following changes since commit ba29883206d92a29ad5a466e679ccfc2ee6132ef:
>
> Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20200310' into staging (2020-03-10 16:50:28 +0000)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 8bb3b023f2055054ee119cb45b42d2b14be7fc8a:
>
> qemu-iotests: adding LUKS cleanup for non-UTF8 secret error (2020-03-11 15:54:38 +0100)
>
> ----------------------------------------------------------------
> Block layer patches:
>
> - Relax restrictions for blockdev-snapshot (allows libvirt to do live
> storage migration with blockdev-mirror)
> - luks: Delete created files when block_crypto_co_create_opts_luks fails
> - Fix memleaks in qmp_object_add
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PULL 00/13] Block layer patches
2022-05-04 14:25 Kevin Wolf
@ 2022-05-05 13:09 ` Richard Henderson
0 siblings, 0 replies; 13+ messages in thread
From: Richard Henderson @ 2022-05-05 13:09 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: qemu-devel
On 5/4/22 09:25, Kevin Wolf wrote:
> The following changes since commit 2e3408b3cc7de4e87a9adafc8c19bfce3abec947:
>
> Merge tag 'misc-pull-request' of gitlab.com:marcandre.lureau/qemu into staging (2022-05-03 09:13:17 -0700)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to c1fe694357a328c807ae3cc6961c19e923448fcc:
>
> coroutine-win32: use QEMU_DEFINE_STATIC_CO_TLS() (2022-05-04 15:55:23 +0200)
>
> ----------------------------------------------------------------
> Block layer patches
>
> - Fix and re-enable GLOBAL_STATE_CODE assertions
> - vhost-user: Fixes for VHOST_USER_ADD/REM_MEM_REG
> - vmdk: Fix reopening bs->file
> - coroutine: use QEMU_DEFINE_STATIC_CO_TLS()
> - docs/qemu-img: Fix list of formats which implement check
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate.
r~
>
> ----------------------------------------------------------------
> Denis V. Lunev (1):
> qemu-img: properly list formats which have consistency check implemented
>
> Hanna Reitz (6):
> block: Classify bdrv_get_flags() as I/O function
> qcow2: Do not reopen data_file in invalidate_cache
> Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions"
> iotests: Add regression test for issue 945
> block/vmdk: Fix reopening bs->file
> iotests/reopen-file: Test reopening file child
>
> Kevin Wolf (3):
> docs/vhost-user: Clarifications for VHOST_USER_ADD/REM_MEM_REG
> libvhost-user: Fix extra vu_add/rem_mem_reg reply
> vhost-user: Don't pass file descriptor for VHOST_USER_REM_MEM_REG
>
> Stefan Hajnoczi (3):
> coroutine-ucontext: use QEMU_DEFINE_STATIC_CO_TLS()
> coroutine: use QEMU_DEFINE_STATIC_CO_TLS()
> coroutine-win32: use QEMU_DEFINE_STATIC_CO_TLS()
>
> docs/interop/vhost-user.rst | 17 ++++
> docs/tools/qemu-img.rst | 4 +-
> include/block/block-global-state.h | 1 -
> include/block/block-io.h | 1 +
> include/qemu/main-loop.h | 3 +-
> block.c | 2 +-
> block/qcow2.c | 104 ++++++++++++---------
> block/vmdk.c | 56 ++++++++++-
> hw/virtio/vhost-user.c | 2 +-
> subprojects/libvhost-user/libvhost-user.c | 17 ++--
> util/coroutine-ucontext.c | 38 +++++---
> util/coroutine-win32.c | 18 +++-
> util/qemu-coroutine.c | 41 ++++----
> tests/qemu-iotests/tests/export-incoming-iothread | 81 ++++++++++++++++
> .../tests/export-incoming-iothread.out | 5 +
> tests/qemu-iotests/tests/reopen-file | 89 ++++++++++++++++++
> tests/qemu-iotests/tests/reopen-file.out | 5 +
> 17 files changed, 388 insertions(+), 96 deletions(-)
> create mode 100755 tests/qemu-iotests/tests/export-incoming-iothread
> create mode 100644 tests/qemu-iotests/tests/export-incoming-iothread.out
> create mode 100755 tests/qemu-iotests/tests/reopen-file
> create mode 100644 tests/qemu-iotests/tests/reopen-file.out
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PULL 00/13] Block layer patches
@ 2022-05-04 14:25 Kevin Wolf
2022-05-05 13:09 ` Richard Henderson
0 siblings, 1 reply; 13+ messages in thread
From: Kevin Wolf @ 2022-05-04 14:25 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, qemu-devel
The following changes since commit 2e3408b3cc7de4e87a9adafc8c19bfce3abec947:
Merge tag 'misc-pull-request' of gitlab.com:marcandre.lureau/qemu into staging (2022-05-03 09:13:17 -0700)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to c1fe694357a328c807ae3cc6961c19e923448fcc:
coroutine-win32: use QEMU_DEFINE_STATIC_CO_TLS() (2022-05-04 15:55:23 +0200)
----------------------------------------------------------------
Block layer patches
- Fix and re-enable GLOBAL_STATE_CODE assertions
- vhost-user: Fixes for VHOST_USER_ADD/REM_MEM_REG
- vmdk: Fix reopening bs->file
- coroutine: use QEMU_DEFINE_STATIC_CO_TLS()
- docs/qemu-img: Fix list of formats which implement check
----------------------------------------------------------------
Denis V. Lunev (1):
qemu-img: properly list formats which have consistency check implemented
Hanna Reitz (6):
block: Classify bdrv_get_flags() as I/O function
qcow2: Do not reopen data_file in invalidate_cache
Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions"
iotests: Add regression test for issue 945
block/vmdk: Fix reopening bs->file
iotests/reopen-file: Test reopening file child
Kevin Wolf (3):
docs/vhost-user: Clarifications for VHOST_USER_ADD/REM_MEM_REG
libvhost-user: Fix extra vu_add/rem_mem_reg reply
vhost-user: Don't pass file descriptor for VHOST_USER_REM_MEM_REG
Stefan Hajnoczi (3):
coroutine-ucontext: use QEMU_DEFINE_STATIC_CO_TLS()
coroutine: use QEMU_DEFINE_STATIC_CO_TLS()
coroutine-win32: use QEMU_DEFINE_STATIC_CO_TLS()
docs/interop/vhost-user.rst | 17 ++++
docs/tools/qemu-img.rst | 4 +-
include/block/block-global-state.h | 1 -
include/block/block-io.h | 1 +
include/qemu/main-loop.h | 3 +-
block.c | 2 +-
block/qcow2.c | 104 ++++++++++++---------
block/vmdk.c | 56 ++++++++++-
hw/virtio/vhost-user.c | 2 +-
subprojects/libvhost-user/libvhost-user.c | 17 ++--
util/coroutine-ucontext.c | 38 +++++---
util/coroutine-win32.c | 18 +++-
util/qemu-coroutine.c | 41 ++++----
tests/qemu-iotests/tests/export-incoming-iothread | 81 ++++++++++++++++
.../tests/export-incoming-iothread.out | 5 +
tests/qemu-iotests/tests/reopen-file | 89 ++++++++++++++++++
tests/qemu-iotests/tests/reopen-file.out | 5 +
17 files changed, 388 insertions(+), 96 deletions(-)
create mode 100755 tests/qemu-iotests/tests/export-incoming-iothread
create mode 100644 tests/qemu-iotests/tests/export-incoming-iothread.out
create mode 100755 tests/qemu-iotests/tests/reopen-file
create mode 100644 tests/qemu-iotests/tests/reopen-file.out
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PULL 00/13] Block layer patches
2021-11-15 20:55 ` Richard Henderson
@ 2021-11-16 8:49 ` Hanna Reitz
0 siblings, 0 replies; 13+ messages in thread
From: Hanna Reitz @ 2021-11-16 8:49 UTC (permalink / raw)
To: Richard Henderson, Kevin Wolf, qemu-block; +Cc: peter.maydell, qemu-devel
On 15.11.21 21:55, Richard Henderson wrote:
> On 11/15/21 3:53 PM, Kevin Wolf wrote:
>> The following changes since commit
>> 42f6c9179be4401974dd3a75ee72defd16b5092d:
>>
>> Merge tag 'pull-ppc-20211112' of https://github.com/legoater/qemu
>> into staging (2021-11-12 12:28:25 +0100)
>>
>> are available in the Git repository at:
>>
>> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>>
>> for you to fetch changes up to 7461272c5f6032436ef9032c091c0118539483e4:
>>
>> softmmu/qdev-monitor: fix use-after-free in qdev_set_id()
>> (2021-11-15 15:49:46 +0100)
>>
>> ----------------------------------------------------------------
>> Block layer patches
>>
>> - Fixes to image streaming job and block layer reconfiguration to make
>> iotest 030 pass again
>> - docs: Deprecate incorrectly typed device_add arguments
>> - file-posix: Fix alignment after reopen changing O_DIRECT
>>
>> ----------------------------------------------------------------
>> Hanna Reitz (10):
>> stream: Traverse graph after modification
>> block: Manipulate children list in .attach/.detach
>> block: Unite remove_empty_child and child_free
>> block: Drop detached child from ignore list
>> block: Pass BdrvChild ** to replace_child_noperm
>> block: Restructure remove_file_or_backing_child()
>> transactions: Invoke clean() after everything else
>> block: Let replace_child_tran keep indirect pointer
>> block: Let replace_child_noperm free children
>> iotests/030: Unthrottle parallel jobs in reverse
>>
>> Kevin Wolf (2):
>> docs: Deprecate incorrectly typed device_add arguments
>> file-posix: Fix alignment after reopen changing O_DIRECT
>>
>> Stefan Hajnoczi (1):
>> softmmu/qdev-monitor: fix use-after-free in qdev_set_id()
>>
>> docs/about/deprecated.rst | 14 +++
>> include/qemu/transactions.h | 3 +
>> block.c | 233
>> +++++++++++++++++++++++++++++++++-----------
>> block/file-posix.c | 20 +++-
>> block/stream.c | 7 +-
>> softmmu/qdev-monitor.c | 2 +-
>> util/transactions.c | 8 +-
>> tests/qemu-iotests/030 | 11 ++-
>> tests/qemu-iotests/142 | 22 +++++
>> tests/qemu-iotests/142.out | 15 +++
>> 10 files changed, 269 insertions(+), 66 deletions(-)
>
> This is failing iotest 142 for build-tcg-disabled.
> I did retry, in case it was transitory.
>
> https://gitlab.com/qemu-project/qemu/-/jobs/1784955950
Thanks, seems like a problem that appears on block devices with sector
sizes greater than 512 bytes. Since Kevin is on PTO, I’ll (try to) fix
the test and send a v2.
Hanna
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PULL 00/13] Block layer patches
2021-11-15 14:53 Kevin Wolf
2021-11-15 20:55 ` Richard Henderson
@ 2021-11-15 20:59 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 13+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-15 20:59 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: peter.maydell, qemu-devel
Hi Kevin,
On 11/15/21 15:53, Kevin Wolf wrote:
> The following changes since commit 42f6c9179be4401974dd3a75ee72defd16b5092d:
>
> Merge tag 'pull-ppc-20211112' of https://github.com/legoater/qemu into staging (2021-11-12 12:28:25 +0100)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 7461272c5f6032436ef9032c091c0118539483e4:
>
> softmmu/qdev-monitor: fix use-after-free in qdev_set_id() (2021-11-15 15:49:46 +0100)
>
> ----------------------------------------------------------------
> Block layer patches
>
> - Fixes to image streaming job and block layer reconfiguration to make
> iotest 030 pass again
> - docs: Deprecate incorrectly typed device_add arguments
> - file-posix: Fix alignment after reopen changing O_DIRECT
>
> ----------------------------------------------------------------
> Hanna Reitz (10):
> stream: Traverse graph after modification
> block: Manipulate children list in .attach/.detach
> block: Unite remove_empty_child and child_free
> block: Drop detached child from ignore list
> block: Pass BdrvChild ** to replace_child_noperm
> block: Restructure remove_file_or_backing_child()
> transactions: Invoke clean() after everything else
> block: Let replace_child_tran keep indirect pointer
> block: Let replace_child_noperm free children
> iotests/030: Unthrottle parallel jobs in reverse
>
> Kevin Wolf (2):
> docs: Deprecate incorrectly typed device_add arguments
> file-posix: Fix alignment after reopen changing O_DIRECT
>
> Stefan Hajnoczi (1):
> softmmu/qdev-monitor: fix use-after-free in qdev_set_id()
>
> docs/about/deprecated.rst | 14 +++
> include/qemu/transactions.h | 3 +
> block.c | 233 +++++++++++++++++++++++++++++++++-----------
> block/file-posix.c | 20 +++-
> block/stream.c | 7 +-
> softmmu/qdev-monitor.c | 2 +-
> util/transactions.c | 8 +-
> tests/qemu-iotests/030 | 11 ++-
> tests/qemu-iotests/142 | 22 +++++
> tests/qemu-iotests/142.out | 15 +++
> 10 files changed, 269 insertions(+), 66 deletions(-)
Looking at current /staging I noticed iotest#142 failed,
build-tcg-disabled job:
+++ 142.out.bad
@@ -750,6 +750,7 @@
--- Alignment after changing O_DIRECT ---
+qemu-io: Cannot get 'write' permission without 'resize': Image size is
not a multiple of request alignment
read 42/42 bytes at offset 42
42 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 42/42 bytes at offset 42
https://gitlab.com/qemu-project/qemu/-/jobs/1784955950#L2794
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PULL 00/13] Block layer patches
2021-11-15 14:53 Kevin Wolf
@ 2021-11-15 20:55 ` Richard Henderson
2021-11-16 8:49 ` Hanna Reitz
2021-11-15 20:59 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 13+ messages in thread
From: Richard Henderson @ 2021-11-15 20:55 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: peter.maydell, qemu-devel
On 11/15/21 3:53 PM, Kevin Wolf wrote:
> The following changes since commit 42f6c9179be4401974dd3a75ee72defd16b5092d:
>
> Merge tag 'pull-ppc-20211112' of https://github.com/legoater/qemu into staging (2021-11-12 12:28:25 +0100)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 7461272c5f6032436ef9032c091c0118539483e4:
>
> softmmu/qdev-monitor: fix use-after-free in qdev_set_id() (2021-11-15 15:49:46 +0100)
>
> ----------------------------------------------------------------
> Block layer patches
>
> - Fixes to image streaming job and block layer reconfiguration to make
> iotest 030 pass again
> - docs: Deprecate incorrectly typed device_add arguments
> - file-posix: Fix alignment after reopen changing O_DIRECT
>
> ----------------------------------------------------------------
> Hanna Reitz (10):
> stream: Traverse graph after modification
> block: Manipulate children list in .attach/.detach
> block: Unite remove_empty_child and child_free
> block: Drop detached child from ignore list
> block: Pass BdrvChild ** to replace_child_noperm
> block: Restructure remove_file_or_backing_child()
> transactions: Invoke clean() after everything else
> block: Let replace_child_tran keep indirect pointer
> block: Let replace_child_noperm free children
> iotests/030: Unthrottle parallel jobs in reverse
>
> Kevin Wolf (2):
> docs: Deprecate incorrectly typed device_add arguments
> file-posix: Fix alignment after reopen changing O_DIRECT
>
> Stefan Hajnoczi (1):
> softmmu/qdev-monitor: fix use-after-free in qdev_set_id()
>
> docs/about/deprecated.rst | 14 +++
> include/qemu/transactions.h | 3 +
> block.c | 233 +++++++++++++++++++++++++++++++++-----------
> block/file-posix.c | 20 +++-
> block/stream.c | 7 +-
> softmmu/qdev-monitor.c | 2 +-
> util/transactions.c | 8 +-
> tests/qemu-iotests/030 | 11 ++-
> tests/qemu-iotests/142 | 22 +++++
> tests/qemu-iotests/142.out | 15 +++
> 10 files changed, 269 insertions(+), 66 deletions(-)
This is failing iotest 142 for build-tcg-disabled.
I did retry, in case it was transitory.
https://gitlab.com/qemu-project/qemu/-/jobs/1784955950
r~
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PULL 00/13] Block layer patches
@ 2021-11-15 14:53 Kevin Wolf
2021-11-15 20:55 ` Richard Henderson
2021-11-15 20:59 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 13+ messages in thread
From: Kevin Wolf @ 2021-11-15 14:53 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, peter.maydell, qemu-devel
The following changes since commit 42f6c9179be4401974dd3a75ee72defd16b5092d:
Merge tag 'pull-ppc-20211112' of https://github.com/legoater/qemu into staging (2021-11-12 12:28:25 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to 7461272c5f6032436ef9032c091c0118539483e4:
softmmu/qdev-monitor: fix use-after-free in qdev_set_id() (2021-11-15 15:49:46 +0100)
----------------------------------------------------------------
Block layer patches
- Fixes to image streaming job and block layer reconfiguration to make
iotest 030 pass again
- docs: Deprecate incorrectly typed device_add arguments
- file-posix: Fix alignment after reopen changing O_DIRECT
----------------------------------------------------------------
Hanna Reitz (10):
stream: Traverse graph after modification
block: Manipulate children list in .attach/.detach
block: Unite remove_empty_child and child_free
block: Drop detached child from ignore list
block: Pass BdrvChild ** to replace_child_noperm
block: Restructure remove_file_or_backing_child()
transactions: Invoke clean() after everything else
block: Let replace_child_tran keep indirect pointer
block: Let replace_child_noperm free children
iotests/030: Unthrottle parallel jobs in reverse
Kevin Wolf (2):
docs: Deprecate incorrectly typed device_add arguments
file-posix: Fix alignment after reopen changing O_DIRECT
Stefan Hajnoczi (1):
softmmu/qdev-monitor: fix use-after-free in qdev_set_id()
docs/about/deprecated.rst | 14 +++
include/qemu/transactions.h | 3 +
block.c | 233 +++++++++++++++++++++++++++++++++-----------
block/file-posix.c | 20 +++-
block/stream.c | 7 +-
softmmu/qdev-monitor.c | 2 +-
util/transactions.c | 8 +-
tests/qemu-iotests/030 | 11 ++-
tests/qemu-iotests/142 | 22 +++++
tests/qemu-iotests/142.out | 15 +++
10 files changed, 269 insertions(+), 66 deletions(-)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PULL 00/13] Block layer patches
2021-10-06 10:59 Kevin Wolf
@ 2021-10-06 15:49 ` Richard Henderson
0 siblings, 0 replies; 13+ messages in thread
From: Richard Henderson @ 2021-10-06 15:49 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: peter.maydell, qemu-devel
On 10/6/21 3:59 AM, Kevin Wolf wrote:
> The following changes since commit e3acc2c1961cbe22ca474cd5da4163b7bbf7cea3:
>
> tests/docker/dockerfiles: Bump fedora-i386-cross to fedora 34 (2021-10-05 16:40:39 -0700)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 3765315d4c84f9c0799744f43a314169baaccc05:
>
> iotests: Update for pylint 2.11.1 (2021-10-06 10:25:55 +0200)
>
> ----------------------------------------------------------------
> Block layer patches
>
> - Fix I/O errors because of incorrectly detected max_iov
> - Fix not white-listed copy-before-write
> - qemu-storage-daemon: Only display FUSE help when FUSE is built-in
> - iotests: update environment and linting configuration
>
> ----------------------------------------------------------------
> Emanuele Giuseppe Esposito (1):
> include/block.h: remove outdated comment
>
> John Snow (5):
> iotests: add 'qemu' package location to PYTHONPATH in testenv
> iotests/linters: check mypy files all at once
> iotests/mirror-top-perms: Adjust imports
> iotests/migrate-bitmaps-test: delint
> iotests: Update for pylint 2.11.1
>
> Paolo Bonzini (1):
> block: introduce max_hw_iov for use in scsi-generic
>
> Philippe Mathieu-Daudé (1):
> qemu-storage-daemon: Only display FUSE help when FUSE is built-in
>
> Vladimir Sementsov-Ogievskiy (5):
> block: implement bdrv_new_open_driver_opts()
> block: bdrv_insert_node(): fix and improve error handling
> block: bdrv_insert_node(): doc and style
> block: bdrv_insert_node(): don't use bdrv_open()
> iotests/image-fleecing: declare requirement of copy-before-write
>
> include/block/block.h | 8 ++-
> include/block/block_int.h | 7 +++
> include/sysemu/block-backend.h | 1 +
> block.c | 79 ++++++++++++++++++++++-----
> block/block-backend.c | 6 ++
> block/file-posix.c | 2 +-
> block/io.c | 1 +
> hw/scsi/scsi-generic.c | 2 +-
> storage-daemon/qemu-storage-daemon.c | 2 +
> tests/qemu-iotests/iotests.py | 2 -
> tests/qemu-iotests/testenv.py | 15 +++--
> tests/qemu-iotests/testrunner.py | 7 ++-
> tests/qemu-iotests/235 | 2 -
> tests/qemu-iotests/297 | 52 +++++++-----------
> tests/qemu-iotests/300 | 5 +-
> tests/qemu-iotests/pylintrc | 6 +-
> tests/qemu-iotests/tests/image-fleecing | 1 +
> tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++++++++--------
> tests/qemu-iotests/tests/mirror-top-perms | 12 ++--
> 19 files changed, 164 insertions(+), 96 deletions(-)
Applied, thanks.
r~
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PULL 00/13] Block layer patches
@ 2021-10-06 10:59 Kevin Wolf
2021-10-06 15:49 ` Richard Henderson
0 siblings, 1 reply; 13+ messages in thread
From: Kevin Wolf @ 2021-10-06 10:59 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, peter.maydell, qemu-devel
The following changes since commit e3acc2c1961cbe22ca474cd5da4163b7bbf7cea3:
tests/docker/dockerfiles: Bump fedora-i386-cross to fedora 34 (2021-10-05 16:40:39 -0700)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to 3765315d4c84f9c0799744f43a314169baaccc05:
iotests: Update for pylint 2.11.1 (2021-10-06 10:25:55 +0200)
----------------------------------------------------------------
Block layer patches
- Fix I/O errors because of incorrectly detected max_iov
- Fix not white-listed copy-before-write
- qemu-storage-daemon: Only display FUSE help when FUSE is built-in
- iotests: update environment and linting configuration
----------------------------------------------------------------
Emanuele Giuseppe Esposito (1):
include/block.h: remove outdated comment
John Snow (5):
iotests: add 'qemu' package location to PYTHONPATH in testenv
iotests/linters: check mypy files all at once
iotests/mirror-top-perms: Adjust imports
iotests/migrate-bitmaps-test: delint
iotests: Update for pylint 2.11.1
Paolo Bonzini (1):
block: introduce max_hw_iov for use in scsi-generic
Philippe Mathieu-Daudé (1):
qemu-storage-daemon: Only display FUSE help when FUSE is built-in
Vladimir Sementsov-Ogievskiy (5):
block: implement bdrv_new_open_driver_opts()
block: bdrv_insert_node(): fix and improve error handling
block: bdrv_insert_node(): doc and style
block: bdrv_insert_node(): don't use bdrv_open()
iotests/image-fleecing: declare requirement of copy-before-write
include/block/block.h | 8 ++-
include/block/block_int.h | 7 +++
include/sysemu/block-backend.h | 1 +
block.c | 79 ++++++++++++++++++++++-----
block/block-backend.c | 6 ++
block/file-posix.c | 2 +-
block/io.c | 1 +
hw/scsi/scsi-generic.c | 2 +-
storage-daemon/qemu-storage-daemon.c | 2 +
tests/qemu-iotests/iotests.py | 2 -
tests/qemu-iotests/testenv.py | 15 +++--
tests/qemu-iotests/testrunner.py | 7 ++-
tests/qemu-iotests/235 | 2 -
tests/qemu-iotests/297 | 52 +++++++-----------
tests/qemu-iotests/300 | 5 +-
tests/qemu-iotests/pylintrc | 6 +-
tests/qemu-iotests/tests/image-fleecing | 1 +
tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++++++++--------
tests/qemu-iotests/tests/mirror-top-perms | 12 ++--
19 files changed, 164 insertions(+), 96 deletions(-)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PULL 00/13] Block layer patches
2020-01-27 17:55 Kevin Wolf
@ 2020-01-28 9:32 ` Peter Maydell
0 siblings, 0 replies; 13+ messages in thread
From: Peter Maydell @ 2020-01-28 9:32 UTC (permalink / raw)
To: Kevin Wolf; +Cc: QEMU Developers, Qemu-block
On Mon, 27 Jan 2020 at 17:56, Kevin Wolf <kwolf@redhat.com> wrote:
>
> The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into staging (2020-01-27 13:02:36 +0000)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 5fbf1d56c24018772e900a40a0955175ff82f35c:
>
> iscsi: Don't access non-existent scsi_lba_status_descriptor (2020-01-27 17:19:53 +0100)
>
> ----------------------------------------------------------------
> Block layer patches:
>
> - iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711)
> - AioContext fixes in QMP commands for backup and bitmaps
> - iotests fixes
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PULL 00/13] Block layer patches
@ 2020-01-27 17:55 Kevin Wolf
2020-01-28 9:32 ` Peter Maydell
0 siblings, 1 reply; 13+ messages in thread
From: Kevin Wolf @ 2020-01-27 17:55 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, peter.maydell, qemu-devel
The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into staging (2020-01-27 13:02:36 +0000)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to 5fbf1d56c24018772e900a40a0955175ff82f35c:
iscsi: Don't access non-existent scsi_lba_status_descriptor (2020-01-27 17:19:53 +0100)
----------------------------------------------------------------
Block layer patches:
- iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711)
- AioContext fixes in QMP commands for backup and bitmaps
- iotests fixes
----------------------------------------------------------------
Eiichi Tsukata (1):
block/backup: fix memory leak in bdrv_backup_top_append()
Felipe Franciosi (1):
iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711)
Kevin Wolf (1):
iscsi: Don't access non-existent scsi_lba_status_descriptor
Max Reitz (1):
iotests.py: Let wait_migration wait even more
Sergio Lopez (8):
blockdev: fix coding style issues in drive_backup_prepare
blockdev: unify qmp_drive_backup and drive-backup transaction paths
blockdev: unify qmp_blockdev_backup and blockdev-backup transaction paths
blockdev: honor bdrv_try_set_aio_context() context requirements
block/backup-top: Don't acquire context while dropping top
blockdev: Acquire AioContext on dirty bitmap functions
blockdev: Return bs to the proper context on snapshot abort
iotests: Test handling of AioContexts with some blockdev actions
Thomas Huth (1):
iotests: Add more "skip_if_unsupported" statements to the python tests
block/backup-top.c | 7 +-
block/backup.c | 3 +
block/iscsi.c | 7 +-
blockdev.c | 393 +++++++++++++++++++++++-------------------
tests/qemu-iotests/iotests.py | 6 +-
tests/qemu-iotests/030 | 4 +-
tests/qemu-iotests/040 | 2 +
tests/qemu-iotests/041 | 39 +----
tests/qemu-iotests/141.out | 2 +
tests/qemu-iotests/185.out | 2 +
tests/qemu-iotests/219 | 7 +-
tests/qemu-iotests/219.out | 8 +
tests/qemu-iotests/234 | 8 +-
tests/qemu-iotests/245 | 2 +
tests/qemu-iotests/262 | 4 +-
tests/qemu-iotests/280 | 2 +-
tests/qemu-iotests/281 | 247 ++++++++++++++++++++++++++
tests/qemu-iotests/281.out | 5 +
tests/qemu-iotests/group | 1 +
19 files changed, 510 insertions(+), 239 deletions(-)
create mode 100755 tests/qemu-iotests/281
create mode 100644 tests/qemu-iotests/281.out
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-05-05 13:12 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200311154218.15532-1-kwolf@redhat.com>
2020-03-12 13:46 ` [PULL 00/13] Block layer patches Peter Maydell
2020-03-12 14:42 ` Kevin Wolf
2020-03-12 17:34 ` Peter Maydell
2022-05-04 14:25 Kevin Wolf
2022-05-05 13:09 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2021-11-15 14:53 Kevin Wolf
2021-11-15 20:55 ` Richard Henderson
2021-11-16 8:49 ` Hanna Reitz
2021-11-15 20:59 ` Philippe Mathieu-Daudé
2021-10-06 10:59 Kevin Wolf
2021-10-06 15:49 ` Richard Henderson
2020-01-27 17:55 Kevin Wolf
2020-01-28 9:32 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).