* [PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth
@ 2020-03-23 18:40 Philippe Mathieu-Daudé
2020-03-23 19:58 ` Dr. David Alan Gilbert
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-23 18:40 UTC (permalink / raw)
To: qemu-devel, Alex Bennée, Dr. David Alan Gilbert
Cc: Laurent Vivier, Thomas Huth, Juan Quintela, Cornelia Huck,
Peter Xu, Halil Pasic, Christian Borntraeger, qemu-s390x,
Paolo Bonzini, Philippe Mathieu-Daudé
When using max-bandwidth=~100Mb/s, this test fails on Travis-CI
s390x when configured with --disable-tcg:
$ make check-qtest
TEST check-qtest-s390x: tests/qtest/boot-serial-test
qemu-system-s390x: -accel tcg: invalid accelerator tcg
qemu-system-s390x: falling back to KVM
TEST check-qtest-s390x: tests/qtest/pxe-test
TEST check-qtest-s390x: tests/qtest/test-netfilter
TEST check-qtest-s390x: tests/qtest/test-filter-mirror
TEST check-qtest-s390x: tests/qtest/test-filter-redirector
TEST check-qtest-s390x: tests/qtest/drive_del-test
TEST check-qtest-s390x: tests/qtest/device-plug-test
TEST check-qtest-s390x: tests/qtest/virtio-ccw-test
TEST check-qtest-s390x: tests/qtest/cpu-plug-test
TEST check-qtest-s390x: tests/qtest/migration-test
**
ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1
Per David Gilbert, "it could just be the writing is slow on s390
and the migration thread fast; in which case the autocomplete
wouldn't be needed. Perhaps we just need to reduce the bandwidth
limit."
Tuning the threshold by reducing the initial bandwidth makes the
autoconverge test pass.
Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v3: really reduce =)
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 3d6cc83b88..2568c9529c 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)
* without throttling.
*/
migrate_set_parameter_int(from, "downtime-limit", 1);
- migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s */
+ migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s */
/* To check remaining size after precopy */
migrate_set_capability(from, "pause-before-switchover", true);
--
2.21.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth
2020-03-23 18:40 [PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth Philippe Mathieu-Daudé
@ 2020-03-23 19:58 ` Dr. David Alan Gilbert
2020-03-24 10:21 ` Alex Bennée
2020-03-24 18:40 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-23 19:58 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Laurent Vivier, Thomas Huth, Juan Quintela, Cornelia Huck,
qemu-devel, Peter Xu, Halil Pasic, Christian Borntraeger,
qemu-s390x, Paolo Bonzini, Alex Bennée
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> When using max-bandwidth=~100Mb/s, this test fails on Travis-CI
> s390x when configured with --disable-tcg:
>
> $ make check-qtest
> TEST check-qtest-s390x: tests/qtest/boot-serial-test
> qemu-system-s390x: -accel tcg: invalid accelerator tcg
> qemu-system-s390x: falling back to KVM
> TEST check-qtest-s390x: tests/qtest/pxe-test
> TEST check-qtest-s390x: tests/qtest/test-netfilter
> TEST check-qtest-s390x: tests/qtest/test-filter-mirror
> TEST check-qtest-s390x: tests/qtest/test-filter-redirector
> TEST check-qtest-s390x: tests/qtest/drive_del-test
> TEST check-qtest-s390x: tests/qtest/device-plug-test
> TEST check-qtest-s390x: tests/qtest/virtio-ccw-test
> TEST check-qtest-s390x: tests/qtest/cpu-plug-test
> TEST check-qtest-s390x: tests/qtest/migration-test
> **
> ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
> ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
> make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1
>
> Per David Gilbert, "it could just be the writing is slow on s390
> and the migration thread fast; in which case the autocomplete
> wouldn't be needed. Perhaps we just need to reduce the bandwidth
> limit."
>
> Tuning the threshold by reducing the initial bandwidth makes the
> autoconverge test pass.
>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This is what I'm expecting to help, so if it passes testing lets try it.
'got_stop' being true just indicates the migration managed to complete.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> v3: really reduce =)
> ---
> tests/qtest/migration-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 3d6cc83b88..2568c9529c 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)
> * without throttling.
> */
> migrate_set_parameter_int(from, "downtime-limit", 1);
> - migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s */
> + migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s */
>
> /* To check remaining size after precopy */
> migrate_set_capability(from, "pause-before-switchover", true);
> --
> 2.21.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth
2020-03-23 18:40 [PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth Philippe Mathieu-Daudé
2020-03-23 19:58 ` Dr. David Alan Gilbert
@ 2020-03-24 10:21 ` Alex Bennée
2020-03-24 18:40 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2020-03-24 10:21 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Laurent Vivier, Thomas Huth, Juan Quintela, Cornelia Huck,
qemu-devel, Peter Xu, Dr. David Alan Gilbert, Halil Pasic,
Christian Borntraeger, qemu-s390x, Paolo Bonzini
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> When using max-bandwidth=~100Mb/s, this test fails on Travis-CI
> s390x when configured with --disable-tcg:
>
> $ make check-qtest
> TEST check-qtest-s390x: tests/qtest/boot-serial-test
> qemu-system-s390x: -accel tcg: invalid accelerator tcg
> qemu-system-s390x: falling back to KVM
> TEST check-qtest-s390x: tests/qtest/pxe-test
> TEST check-qtest-s390x: tests/qtest/test-netfilter
> TEST check-qtest-s390x: tests/qtest/test-filter-mirror
> TEST check-qtest-s390x: tests/qtest/test-filter-redirector
> TEST check-qtest-s390x: tests/qtest/drive_del-test
> TEST check-qtest-s390x: tests/qtest/device-plug-test
> TEST check-qtest-s390x: tests/qtest/virtio-ccw-test
> TEST check-qtest-s390x: tests/qtest/cpu-plug-test
> TEST check-qtest-s390x: tests/qtest/migration-test
> **
> ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
> ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
> make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1
>
> Per David Gilbert, "it could just be the writing is slow on s390
> and the migration thread fast; in which case the autocomplete
> wouldn't be needed. Perhaps we just need to reduce the bandwidth
> limit."
>
> Tuning the threshold by reducing the initial bandwidth makes the
> autoconverge test pass.
>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v3: really reduce =)
> ---
> tests/qtest/migration-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 3d6cc83b88..2568c9529c 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)
> * without throttling.
> */
> migrate_set_parameter_int(from, "downtime-limit", 1);
> - migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s */
> + migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s */
>
> /* To check remaining size after precopy */
> migrate_set_capability(from, "pause-before-switchover", true);
The vm-build tests work again.
Tested-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth
2020-03-23 18:40 [PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth Philippe Mathieu-Daudé
2020-03-23 19:58 ` Dr. David Alan Gilbert
2020-03-24 10:21 ` Alex Bennée
@ 2020-03-24 18:40 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-24 18:40 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Laurent Vivier, Thomas Huth, Juan Quintela, Cornelia Huck,
qemu-devel, Peter Xu, Halil Pasic, Christian Borntraeger,
qemu-s390x, Paolo Bonzini, Alex Bennée
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> When using max-bandwidth=~100Mb/s, this test fails on Travis-CI
> s390x when configured with --disable-tcg:
>
> $ make check-qtest
> TEST check-qtest-s390x: tests/qtest/boot-serial-test
> qemu-system-s390x: -accel tcg: invalid accelerator tcg
> qemu-system-s390x: falling back to KVM
> TEST check-qtest-s390x: tests/qtest/pxe-test
> TEST check-qtest-s390x: tests/qtest/test-netfilter
> TEST check-qtest-s390x: tests/qtest/test-filter-mirror
> TEST check-qtest-s390x: tests/qtest/test-filter-redirector
> TEST check-qtest-s390x: tests/qtest/drive_del-test
> TEST check-qtest-s390x: tests/qtest/device-plug-test
> TEST check-qtest-s390x: tests/qtest/virtio-ccw-test
> TEST check-qtest-s390x: tests/qtest/cpu-plug-test
> TEST check-qtest-s390x: tests/qtest/migration-test
> **
> ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
> ERROR - Bail out! ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE
> make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1
>
> Per David Gilbert, "it could just be the writing is slow on s390
> and the migration thread fast; in which case the autocomplete
> wouldn't be needed. Perhaps we just need to reduce the bandwidth
> limit."
>
> Tuning the threshold by reducing the initial bandwidth makes the
> autoconverge test pass.
>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Queued
> ---
> v3: really reduce =)
> ---
> tests/qtest/migration-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 3d6cc83b88..2568c9529c 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)
> * without throttling.
> */
> migrate_set_parameter_int(from, "downtime-limit", 1);
> - migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s */
> + migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s */
>
> /* To check remaining size after precopy */
> migrate_set_capability(from, "pause-before-switchover", true);
> --
> 2.21.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-24 18:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 18:40 [PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth Philippe Mathieu-Daudé
2020-03-23 19:58 ` Dr. David Alan Gilbert
2020-03-24 10:21 ` Alex Bennée
2020-03-24 18:40 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).