* [PATCH] nvme: Print 'cqid' for nvme_del_cq
@ 2020-03-24 14:06 Minwoo Im
2020-03-24 14:44 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Minwoo Im @ 2020-03-24 14:06 UTC (permalink / raw)
To: qemu-block
Cc: Kevin Wolf, qemu-devel, Max Reitz, Klaus Jensen, Minwoo Im,
Keith Busch, Javier Gonzalez
The given argument for this trace should be cqid, not sqid.
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---
hw/block/trace-events | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/trace-events b/hw/block/trace-events
index f78939fa9da1..bf6d11b58b85 100644
--- a/hw/block/trace-events
+++ b/hw/block/trace-events
@@ -37,7 +37,7 @@ nvme_rw(const char *verb, uint32_t blk_count, uint64_t byte_count, uint64_t lba)
nvme_create_sq(uint64_t addr, uint16_t sqid, uint16_t cqid, uint16_t qsize, uint16_t qflags) "create submission queue, addr=0x%"PRIx64", sqid=%"PRIu16", cqid=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16""
nvme_create_cq(uint64_t addr, uint16_t cqid, uint16_t vector, uint16_t size, uint16_t qflags, int ien) "create completion queue, addr=0x%"PRIx64", cqid=%"PRIu16", vector=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16", ien=%d"
nvme_del_sq(uint16_t qid) "deleting submission queue sqid=%"PRIu16""
-nvme_del_cq(uint16_t cqid) "deleted completion queue, sqid=%"PRIu16""
+nvme_del_cq(uint16_t cqid) "deleted completion queue, cqid=%"PRIu16""
nvme_identify_ctrl(void) "identify controller"
nvme_identify_ns(uint16_t ns) "identify namespace, nsid=%"PRIu16""
nvme_identify_nslist(uint16_t ns) "identify namespace list, nsid=%"PRIu16""
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Print 'cqid' for nvme_del_cq
2020-03-24 14:06 [PATCH] nvme: Print 'cqid' for nvme_del_cq Minwoo Im
@ 2020-03-24 14:44 ` Philippe Mathieu-Daudé
2020-03-25 8:39 ` Stefano Garzarella
2020-03-25 13:29 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-24 14:44 UTC (permalink / raw)
To: Minwoo Im, qemu-block
Cc: Kevin Wolf, qemu-devel, Max Reitz, Keith Busch, Klaus Jensen,
Javier Gonzalez
On 3/24/20 3:06 PM, Minwoo Im wrote:
> The given argument for this trace should be cqid, not sqid.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
> hw/block/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index f78939fa9da1..bf6d11b58b85 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -37,7 +37,7 @@ nvme_rw(const char *verb, uint32_t blk_count, uint64_t byte_count, uint64_t lba)
> nvme_create_sq(uint64_t addr, uint16_t sqid, uint16_t cqid, uint16_t qsize, uint16_t qflags) "create submission queue, addr=0x%"PRIx64", sqid=%"PRIu16", cqid=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16""
> nvme_create_cq(uint64_t addr, uint16_t cqid, uint16_t vector, uint16_t size, uint16_t qflags, int ien) "create completion queue, addr=0x%"PRIx64", cqid=%"PRIu16", vector=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16", ien=%d"
> nvme_del_sq(uint16_t qid) "deleting submission queue sqid=%"PRIu16""
> -nvme_del_cq(uint16_t cqid) "deleted completion queue, sqid=%"PRIu16""
> +nvme_del_cq(uint16_t cqid) "deleted completion queue, cqid=%"PRIu16""
> nvme_identify_ctrl(void) "identify controller"
> nvme_identify_ns(uint16_t ns) "identify namespace, nsid=%"PRIu16""
> nvme_identify_nslist(uint16_t ns) "identify namespace list, nsid=%"PRIu16""
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Print 'cqid' for nvme_del_cq
2020-03-24 14:06 [PATCH] nvme: Print 'cqid' for nvme_del_cq Minwoo Im
2020-03-24 14:44 ` Philippe Mathieu-Daudé
@ 2020-03-25 8:39 ` Stefano Garzarella
2020-03-25 13:29 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2020-03-25 8:39 UTC (permalink / raw)
To: Minwoo Im
Cc: Kevin Wolf, qemu-block, qemu-devel, Max Reitz, Keith Busch,
Klaus Jensen, Javier Gonzalez
On Tue, Mar 24, 2020 at 11:06:46PM +0900, Minwoo Im wrote:
> The given argument for this trace should be cqid, not sqid.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
> hw/block/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index f78939fa9da1..bf6d11b58b85 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -37,7 +37,7 @@ nvme_rw(const char *verb, uint32_t blk_count, uint64_t byte_count, uint64_t lba)
> nvme_create_sq(uint64_t addr, uint16_t sqid, uint16_t cqid, uint16_t qsize, uint16_t qflags) "create submission queue, addr=0x%"PRIx64", sqid=%"PRIu16", cqid=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16""
> nvme_create_cq(uint64_t addr, uint16_t cqid, uint16_t vector, uint16_t size, uint16_t qflags, int ien) "create completion queue, addr=0x%"PRIx64", cqid=%"PRIu16", vector=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16", ien=%d"
> nvme_del_sq(uint16_t qid) "deleting submission queue sqid=%"PRIu16""
> -nvme_del_cq(uint16_t cqid) "deleted completion queue, sqid=%"PRIu16""
> +nvme_del_cq(uint16_t cqid) "deleted completion queue, cqid=%"PRIu16""
> nvme_identify_ctrl(void) "identify controller"
> nvme_identify_ns(uint16_t ns) "identify namespace, nsid=%"PRIu16""
> nvme_identify_nslist(uint16_t ns) "identify namespace list, nsid=%"PRIu16""
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Print 'cqid' for nvme_del_cq
2020-03-24 14:06 [PATCH] nvme: Print 'cqid' for nvme_del_cq Minwoo Im
2020-03-24 14:44 ` Philippe Mathieu-Daudé
2020-03-25 8:39 ` Stefano Garzarella
@ 2020-03-25 13:29 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2020-03-25 13:29 UTC (permalink / raw)
To: Minwoo Im
Cc: qemu-block, qemu-devel, Max Reitz, Keith Busch, Klaus Jensen,
Javier Gonzalez
Am 24.03.2020 um 15:06 hat Minwoo Im geschrieben:
> The given argument for this trace should be cqid, not sqid.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-25 13:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 14:06 [PATCH] nvme: Print 'cqid' for nvme_del_cq Minwoo Im
2020-03-24 14:44 ` Philippe Mathieu-Daudé
2020-03-25 8:39 ` Stefano Garzarella
2020-03-25 13:29 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).