From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Fabien Chouteau" <chouteau@adacore.com>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Jiri Gaisler" <jiri@gaisler.se>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH-for-5.0 2/7] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP registers
Date: Tue, 31 Mar 2020 12:50:43 +0200 [thread overview]
Message-ID: <20200331105048.27989-3-f4bug@amsat.org> (raw)
In-Reply-To: <20200331105048.27989-1-f4bug@amsat.org>
Similarly to commit 158b659451 with the APB PnP registers, guests
can crash QEMU when writting to the AHB PnP registers:
$ echo 'writeb 0xfffff042 69' | qemu-system-sparc -M leon3_generic -S -bios /etc/magic -qtest stdio
[I 1571938309.932255] OPENED
[R +0.063474] writeb 0xfffff042 69
Segmentation fault (core dumped)
(gdb) bt
#0 0x0000000000000000 in ()
#1 0x0000562999110df4 in memory_region_write_with_attrs_accessor
(mr=mr@entry=0x56299aa28ea0, addr=66, value=value@entry=0x7fff6abe13b8, size=size@entry=1, shift=<optimized out>, mask=mask@entry=255, attrs=...) at memory.c:503
#2 0x000056299911095e in access_with_adjusted_size
(addr=addr@entry=66, value=value@entry=0x7fff6abe13b8, size=size@entry=1, access_size_min=<optimized out>, access_size_max=<optimized out>, access_fn=access_fn@entry=
0x562999110d70 <memory_region_write_with_attrs_accessor>, mr=0x56299aa28ea0, attrs=...) at memory.c:539
#3 0x0000562999114fba in memory_region_dispatch_write (mr=mr@entry=0x56299aa28ea0, addr=66, data=<optimized out>, op=<optimized out>, attrs=attrs@entry=...) at memory.c:1482
#4 0x00005629990c0860 in flatview_write_continue
(fv=fv@entry=0x56299aa7d8a0, addr=addr@entry=4294963266, attrs=..., ptr=ptr@entry=0x7fff6abe1540, len=len@entry=1, addr1=<optimized out>, l=<optimized out>, mr=0x56299aa28ea0)
at include/qemu/host-utils.h:164
#5 0x00005629990c0a76 in flatview_write (fv=0x56299aa7d8a0, addr=4294963266, attrs=..., buf=0x7fff6abe1540, len=1) at exec.c:3165
#6 0x00005629990c4c1b in address_space_write (as=<optimized out>, addr=<optimized out>, attrs=..., attrs@entry=..., buf=buf@entry=0x7fff6abe1540, len=len@entry=1) at exec.c:3256
#7 0x000056299910f807 in qtest_process_command (chr=chr@entry=0x5629995ee920 <qtest_chr>, words=words@entry=0x56299acfcfa0) at qtest.c:437
Instead of crashing, log the access as unimplemented.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/misc/grlib_ahb_apb_pnp.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c
index e230e25363..72a8764776 100644
--- a/hw/misc/grlib_ahb_apb_pnp.c
+++ b/hw/misc/grlib_ahb_apb_pnp.c
@@ -136,8 +136,15 @@ static uint64_t grlib_ahb_pnp_read(void *opaque, hwaddr offset, unsigned size)
return ahb_pnp->regs[offset >> 2];
}
+static void grlib_ahb_pnp_write(void *opaque, hwaddr addr,
+ uint64_t val, unsigned size)
+{
+ qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
+}
+
static const MemoryRegionOps grlib_ahb_pnp_ops = {
.read = grlib_ahb_pnp_read,
+ .write = grlib_ahb_pnp_write,
.endianness = DEVICE_BIG_ENDIAN,
};
--
2.21.1
next prev parent reply other threads:[~2020-03-31 10:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 10:50 [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test Philippe Mathieu-Daudé
2020-03-31 10:50 ` [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable " Philippe Mathieu-Daudé
2020-03-31 16:18 ` Richard Henderson
2020-03-31 20:07 ` Philippe Mathieu-Daudé
2020-04-01 17:43 ` Willian Rampazzo
2020-04-01 20:21 ` Philippe Mathieu-Daudé
2020-04-01 20:30 ` Willian Rampazzo
2020-04-01 22:01 ` Philippe Mathieu-Daudé
2020-04-02 11:08 ` Philippe Mathieu-Daudé
2020-04-02 13:25 ` Willian Rampazzo
2020-04-02 15:18 ` Philippe Mathieu-Daudé
2020-04-02 21:39 ` Philippe Mathieu-Daudé
2020-03-31 10:50 ` Philippe Mathieu-Daudé [this message]
2020-04-01 10:58 ` [PATCH-for-5.0 2/7] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP registers KONRAD Frederic
2020-03-31 10:50 ` [PATCH-for-5.0 3/7] hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses Philippe Mathieu-Daudé
2020-04-01 10:58 ` KONRAD Frederic
2020-03-31 10:50 ` [PATCH-for-5.1 4/7] hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses Philippe Mathieu-Daudé
2020-04-01 10:59 ` KONRAD Frederic
2020-03-31 10:50 ` [PATCH-for-5.1 5/7] hw/timer/grlib_gptimer: Display frequency in decimal Philippe Mathieu-Daudé
2020-04-01 10:59 ` KONRAD Frederic
2020-03-31 10:50 ` [PATCH-for-5.1 6/7] target/sparc/int32_helper: Remove DEBUG_PCALL definition Philippe Mathieu-Daudé
2020-04-01 11:04 ` KONRAD Frederic
2020-03-31 10:50 ` [PATCH-for-5.1 7/7] target/sparc/int32_helper: Extract and use excp_name_str() Philippe Mathieu-Daudé
2020-04-01 11:13 ` KONRAD Frederic
2020-04-11 17:30 ` [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test Philippe Mathieu-Daudé
2020-04-13 10:12 ` KONRAD Frederic
2020-04-13 21:07 ` Philippe Mathieu-Daudé
2020-04-14 10:00 ` KONRAD Frederic
2020-05-11 7:03 ` Philippe Mathieu-Daudé
2020-05-23 17:26 ` Philippe Mathieu-Daudé
2020-05-25 11:02 ` Fred Konrad
2020-05-26 9:50 ` Philippe Mathieu-Daudé
2020-06-08 15:20 ` Philippe Mathieu-Daudé
2020-06-08 16:08 ` Mark Cave-Ayland
2020-06-08 16:14 ` Artyom Tarasenko
2020-06-09 5:14 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331105048.27989-3-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=atar4qemu@gmail.com \
--cc=chouteau@adacore.com \
--cc=frederic.konrad@adacore.com \
--cc=jiri@gaisler.se \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).