* Re: [Qemu-devel] [PATCH V2 0/4] fix usage of bool [not found] ` <20190326081814.GF21018@stefanha-x1.localdomain> @ 2019-09-06 14:36 ` Daniel P. Berrangé 0 siblings, 0 replies; 3+ messages in thread From: Daniel P. Berrangé @ 2019-09-06 14:36 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: qemu-trivial, jusual, Jafar Abdi, qemu-devel On Tue, Mar 26, 2019 at 08:18:14AM +0000, Stefan Hajnoczi wrote: > On Sat, Mar 23, 2019 at 05:26:33PM +0300, Jafar Abdi wrote: > > Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h. > > > > FALSE and TRUE (with capital letters) are the constants defined by glib for > > being used with the "gboolean" type of glib. But some parts of the code also use > > TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>). > > CCing qemu-trivial Ping qemu-trivial - this was seems to have been missed, though patches 2 & 3 got merged via ppc tree meanwhile. The other two are still valid. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <1553351197-14581-5-git-send-email-cafer.abdi@gmail.com>]
[parent not found: <a467e1f5-b104-ae69-8ea0-10c05f1263cf@redhat.com>]
[parent not found: <471c060c-2abc-50e9-1a51-871ab62185ea@linux.ibm.com>]
* Re: [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c [not found] ` <471c060c-2abc-50e9-1a51-871ab62185ea@linux.ibm.com> @ 2020-05-07 11:52 ` Daniel P. Berrangé 2020-05-08 19:42 ` Stefan Berger 0 siblings, 1 reply; 3+ messages in thread From: Daniel P. Berrangé @ 2020-05-07 11:52 UTC (permalink / raw) To: Stefan Berger Cc: Thomas Huth, Jafar Abdi, QEMU Trivial, stefanha, qemu-devel, jusual ping, again, for either qemu-trivial or TPM maintainers to take this patch. The other three in this series are merged, but this TPM patch is still pending. On Tue, Mar 26, 2019 at 09:55:24AM -0400, Stefan Berger wrote: > On 3/24/19 3:41 PM, Thomas Huth wrote: > > On 23/03/2019 15.26, Jafar Abdi wrote: > > > Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h. > > > > > > FALSE and TRUE (with capital letters) are the constants defined by glib for > > > being used with the "gboolean" type of glib. But some parts of the code also use > > > TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>). > > > > > > Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com> > > > --- > > > hw/tpm/tpm_tis.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c > > > index fd183e8..c1eb094 100644 > > > --- a/hw/tpm/tpm_tis.c > > > +++ b/hw/tpm/tpm_tis.c > > > @@ -611,7 +611,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr, > > > while ((TPM_TIS_IS_VALID_LOCTY(s->active_locty) && > > > locty > s->active_locty) || > > > !TPM_TIS_IS_VALID_LOCTY(s->active_locty)) { > > > - bool higher_seize = FALSE; > > > + bool higher_seize = false; > > > /* already a pending SEIZE ? */ > > > if ((s->loc[locty].access & TPM_TIS_ACCESS_SEIZE)) { > > > @@ -621,7 +621,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr, > > > /* check for ongoing seize by a higher locality */ > > > for (l = locty + 1; l < TPM_TIS_NUM_LOCALITIES; l++) { > > > if ((s->loc[l].access & TPM_TIS_ACCESS_SEIZE)) { > > > - higher_seize = TRUE; > > > + higher_seize = true; > > > break; > > > } > > > } > > > > > Reviewed-by: Thomas Huth <thuth@redhat.com> > Reviewed-by: Stefan Berger <stefanb@linux.ibm.com> > > > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c 2020-05-07 11:52 ` [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c Daniel P. Berrangé @ 2020-05-08 19:42 ` Stefan Berger 0 siblings, 0 replies; 3+ messages in thread From: Stefan Berger @ 2020-05-08 19:42 UTC (permalink / raw) To: Daniel P. Berrangé Cc: Thomas Huth, Jafar Abdi, QEMU Trivial, stefanha, qemu-devel, jusual On 5/7/20 7:52 AM, Daniel P. Berrangé wrote: > ping, again, for either qemu-trivial or TPM maintainers to take this > patch. > > The other three in this series are merged, but this TPM patch is > still pending. I'll send a PR with it tonight. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-08 19:43 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1553351197-14581-1-git-send-email-cafer.abdi@gmail.com> [not found] ` <20190326081814.GF21018@stefanha-x1.localdomain> 2019-09-06 14:36 ` [Qemu-devel] [PATCH V2 0/4] fix usage of bool Daniel P. Berrangé [not found] ` <1553351197-14581-5-git-send-email-cafer.abdi@gmail.com> [not found] ` <a467e1f5-b104-ae69-8ea0-10c05f1263cf@redhat.com> [not found] ` <471c060c-2abc-50e9-1a51-871ab62185ea@linux.ibm.com> 2020-05-07 11:52 ` [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c Daniel P. Berrangé 2020-05-08 19:42 ` Stefan Berger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).