From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v5 03/15] acpi: rtc: use a single crs range
Date: Thu, 7 May 2020 15:16:28 +0200 [thread overview]
Message-ID: <20200507131640.14041-4-kraxel@redhat.com> (raw)
In-Reply-To: <20200507131640.14041-1-kraxel@redhat.com>
Use a single io range for _CRS instead of two,
following what real hardware does.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/rtc/mc146818rtc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
index 2104e0aa3b14..ab0cc59973b3 100644
--- a/hw/rtc/mc146818rtc.c
+++ b/hw/rtc/mc146818rtc.c
@@ -1013,12 +1013,14 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope)
Aml *dev;
Aml *crs;
+ /*
+ * Reserving 8 io ports here, following what physical hardware
+ * does, even though qemu only responds to the first two ports.
+ */
crs = aml_resource_template();
aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
- 0x10, 0x02));
+ 0x01, 0x08));
aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ));
- aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2,
- 0x02, 0x06));
dev = aml_device("RTC");
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
--
2.18.4
next prev parent reply other threads:[~2020-05-07 13:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 13:16 [PATCH v5 00/15] acpi: i386 tweaks Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 01/15] qtest: allow DSDT acpi table changes Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 02/15] acpi: move aml builder code for rtc device Gerd Hoffmann
2020-05-07 13:16 ` Gerd Hoffmann [this message]
2020-05-11 19:26 ` [PATCH v5 03/15] acpi: rtc: use a single crs range Igor Mammedov
2020-06-03 23:44 ` Cameron Esfahani
2020-05-07 13:16 ` [PATCH v5 04/15] acpi: serial: don't use _STA method Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 05/15] acpi: move aml builder code for serial device Gerd Hoffmann
2020-05-07 13:53 ` Philippe Mathieu-Daudé
2020-05-07 13:16 ` [PATCH v5 06/15] acpi: parallel: don't use _STA method Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 07/15] acpi: move aml builder code for parallel device Gerd Hoffmann
2020-05-07 13:54 ` Philippe Mathieu-Daudé
2020-05-07 13:16 ` [PATCH v5 08/15] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-05-07 14:05 ` Philippe Mathieu-Daudé
2020-05-13 20:43 ` John Snow
2020-05-14 5:51 ` Thomas Huth
2020-05-15 14:47 ` Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 09/15] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 10/15] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 11/15] acpi: simplify build_isa_devices_aml() Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 12/15] acpi: drop serial/parallel enable bits from dsdt Gerd Hoffmann
2020-05-11 19:33 ` Igor Mammedov
2020-05-07 13:16 ` [PATCH v5 13/15] acpi: drop build_piix4_pm() Gerd Hoffmann
2020-05-11 19:37 ` Igor Mammedov
2020-05-12 11:16 ` Gerd Hoffmann
2020-05-12 15:08 ` Igor Mammedov
2020-05-07 13:16 ` [PATCH v5 14/15] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion Gerd Hoffmann
2020-05-11 19:38 ` Igor Mammedov
2020-05-07 13:16 ` [PATCH v5 15/15] floppy: make isa_fdc_get_drive_max_chs static Gerd Hoffmann
2020-05-07 14:06 ` Philippe Mathieu-Daudé
2020-05-13 20:41 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507131640.14041-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).